Re: [PATCH 0/4] drm/xe: Add psmi support

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Jul 16, 2025 at 01:55:43PM -0700, Lucas De Marchi wrote:
> Add PSMI support to aid debugging. More information about PSMI is in the
> second patch. This brings the initial implementation to drm-tip so it's
> also easy to debug and enable things early directly upstream.
> 
> Opens:
>  - Expose the toggle via configfs rather than module param? I'm leaning
>    towards this for v2 as we may have multiple cards and want to debug a
>    single one. It also matches nicely with the latest configurations we
>    added there.

yeap, configfs seems better here.

>  - Expose the allocation request via configs rather than debugfs: this
>    would part ways with configfs being for early-init things. I'm
>    leaning against this and just leave that in debugfs

I agree , debugfs seems better here.

>  - Add match for RTP to enable WA only if certain feature is enabled
>    (like psmi): I'm leaning towards this so we don't enable WAs that are
>    not necessary in normal non-debugging scenarios

good idea!

> 
> I will start preparing a v2 soon with the items above. Opinions on those
> are appreciated.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> Badal Nilawar (1):
>       drm/xe/psmi: Enable GuC Wa_14020001231
> 
> Lucas De Marchi (2):
>       drm/xe/psmi: Add setting of PSMI feature flag
>       drm/xe/psmi: Add debugfs interface for allocation of PSMI capture buffers
> 
> Vinay Belgaumkar (1):
>       drm/xe/psmi: Add Wa_16023683509
> 
>  drivers/gpu/drm/xe/Makefile           |   1 +
>  drivers/gpu/drm/xe/abi/guc_klvs_abi.h |   1 +
>  drivers/gpu/drm/xe/xe_debugfs.c       |   3 +
>  drivers/gpu/drm/xe/xe_device.c        |   3 +
>  drivers/gpu/drm/xe/xe_device_types.h  |   7 +
>  drivers/gpu/drm/xe/xe_guc.c           |   7 +
>  drivers/gpu/drm/xe/xe_guc_ads.c       |   5 +
>  drivers/gpu/drm/xe/xe_guc_fwif.h      |   2 +
>  drivers/gpu/drm/xe/xe_module.c        |   3 +
>  drivers/gpu/drm/xe/xe_module.h        |   1 +
>  drivers/gpu/drm/xe/xe_psmi.c          | 297 ++++++++++++++++++++++++++++++++++
>  drivers/gpu/drm/xe/xe_psmi.h          |  15 ++
>  drivers/gpu/drm/xe/xe_wa_oob.rules    |   6 +
>  13 files changed, 351 insertions(+)
> 
> base-commit: cd8f387cae3dc97c924db689b4849c83249c3b9d
> change-id: 20250618-psmi-9f270bf67895
> 
> Lucas De Marchi
>