From: Zhanjun Dong <zhanjun.dong@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Zhanjun Dong <zhanjun.dong@intel.com>
Subject: [PATCH v7 5/6] drm/xe/guc: Only add GuC crash dump if available
Date: Thu, 28 Aug 2025 13:41:58 -0400 [thread overview]
Message-ID: <20250828174159.1232994-6-zhanjun.dong@intel.com> (raw)
In-Reply-To: <20250828174159.1232994-1-zhanjun.dong@intel.com>
Add GuC crash dump data empty check. LFD will only include crash dump
section when data is not empty.
Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
drivers/gpu/drm/xe/xe_guc_log.c | 45 +++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_guc_log.c b/drivers/gpu/drm/xe/xe_guc_log.c
index 3d4a49b77840..589975904153 100644
--- a/drivers/gpu/drm/xe/xe_guc_log.c
+++ b/drivers/gpu/drm/xe/xe_guc_log.c
@@ -524,6 +524,50 @@ xe_guc_log_add_log_event(struct drm_printer *p, struct xe_guc_log_snapshot *snap
return size;
}
+static int
+xe_guc_log_add_crash_dump(struct drm_printer *p, struct xe_guc_log_snapshot *snapshot,
+ struct guc_lic_save *config)
+{
+ struct guc_log_buffer_entry_list *entry;
+ int chunk_from, chunk_id;
+ int from, to, i;
+ size_t size = 0;
+ u32 *buf32;
+
+ entry = &config->entry[GUC_LOG_BUFFER_CRASH_DUMP];
+
+ /* Skip zero sized crash dump */
+ if (!entry->buf_size)
+ return 0;
+
+ /* Check if crash dump section are all zero */
+ from = entry->offset;
+ to = entry->offset + entry->buf_size;
+ chunk_from = from % GUC_LOG_CHUNK_SIZE;
+ chunk_id = from / GUC_LOG_CHUNK_SIZE;
+ buf32 = snapshot->copy[chunk_id] + chunk_from;
+
+ for (i = 0; i < entry->buf_size / sizeof(u32); i++)
+ if (buf32[i])
+ break;
+
+ /* Buffer has non-zero data? */
+ if (i < entry->buf_size / sizeof(u32)) {
+ struct guc_lfd_data lfd;
+
+ size = xe_guc_log_add_lfd_header(&lfd);
+ lfd.header |= FIELD_PREP(GUC_LFD_DATA_HEADER_MASK_TYPE, GUC_LFD_TYPE_FW_CRASH_DUMP);
+ /* Calculate data length */
+ lfd.data_count = DIV_ROUND_UP(entry->buf_size, sizeof(u32));
+ /* Output GUC_LFD_TYPE_FW_CRASH_DUMP header */
+ lfd_output_binary(p, (char *)&lfd, size);
+
+ /* rd/wr ptr is not used for crash dump */
+ xe_guc_log_print_chunks(p, snapshot, from, to);
+ }
+ return size;
+}
+
void
xe_guc_log_snapshot_print_lfd(struct xe_guc_log_snapshot *snapshot, struct drm_printer *p);
void
@@ -553,6 +597,7 @@ xe_guc_log_snapshot_print_lfd(struct xe_guc_log_snapshot *snapshot, struct drm_p
return;
xe_guc_log_add_log_event(p, snapshot, &config);
+ xe_guc_log_add_crash_dump(p, snapshot, &config);
}
/**
--
2.34.1
next prev parent reply other threads:[~2025-08-28 17:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 17:41 [PATCH v7 0/6] drm/xe/guc: Add LFD format output for guc log Zhanjun Dong
2025-08-28 17:41 ` [PATCH v7 1/6] drm/xe/guc: Add log init config abi definitions Zhanjun Dong
2025-10-09 11:49 ` Michal Wajdeczko
2025-10-20 23:11 ` Julia Filipchuk
2025-08-28 17:41 ` [PATCH v7 2/6] drm/xe/guc: Add LFD related " Zhanjun Dong
2025-10-20 23:11 ` Julia Filipchuk
2025-08-28 17:41 ` [PATCH v7 3/6] drm/xe/guc: Add GuC log init config in LFD format Zhanjun Dong
2025-10-20 23:44 ` Julia Filipchuk
2025-11-25 18:19 ` Dong, Zhanjun
2025-11-25 19:47 ` Julia Filipchuk
2025-08-28 17:41 ` [PATCH v7 4/6] drm/xe/guc: Add GuC log event buffer output " Zhanjun Dong
2025-10-20 23:36 ` Julia Filipchuk
2025-11-26 23:05 ` Dong, Zhanjun
2025-08-28 17:41 ` Zhanjun Dong [this message]
2025-10-20 23:11 ` [PATCH v7 5/6] drm/xe/guc: Only add GuC crash dump if available Julia Filipchuk
2025-11-26 22:59 ` Dong, Zhanjun
2025-08-28 17:41 ` [PATCH v7 6/6] drm/xe/guc: Add new debugfs entry for lfd format output Zhanjun Dong
2025-10-20 23:12 ` Julia Filipchuk
2025-08-28 19:17 ` ✗ CI.checkpatch: warning for drm/xe/guc: Add LFD format output for guc log (rev7) Patchwork
2025-08-28 19:19 ` ✓ CI.KUnit: success " Patchwork
2025-08-28 19:56 ` ✓ Xe.CI.BAT: " Patchwork
2025-08-29 3:03 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250828174159.1232994-6-zhanjun.dong@intel.com \
--to=zhanjun.dong@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox