Re: [PATCH v7 4/6] drm/xe/guc: Add GuC log event buffer output in LFD format

["Dong, Zhanjun" <zhanjun.dong@intel.com>]

On 2025-10-20 7:36 p.m., Julia Filipchuk wrote:
> 
>> +static void
>> +xe_guc_log_print_chunks(struct drm_printer *p, struct xe_guc_log_snapshot *snapshot,
>> +			u32 from, u32 to)
>> +{
>> +	int chunk_from = from % GUC_LOG_CHUNK_SIZE;
>> +	int chunk_id = from / GUC_LOG_CHUNK_SIZE;
>> +	int to_chunk_id = to / GUC_LOG_CHUNK_SIZE;
>> +	int chunk_to = to % GUC_LOG_CHUNK_SIZE;
>> +	int pos = from;
>> +
>> +	do {
>> +		size_t size = (to_chunk_id > chunk_id ? GUC_LOG_CHUNK_SIZE : chunk_to) - chunk_from;
> This check looks incorrect. Should be >= in comparison for last case to use the
> chunk_to.
Yes, should be >=
> 
>>   	/* Output LFD stream */
>>   	xe_guc_log_load_lic(snapshot->copy[0], &config);
>> -	xe_guc_log_output_lfd_init(p, snapshot, &config);
>> +	size = xe_guc_log_output_lfd_init(p, snapshot, &config);
>> +	if (size < 0)
>> +		return;
> This should check for only equal to zero since the size is accumulated?
Yes, should check for zero as size_t never less than 0.

Will correct above 2 in next rev.

Regards,
Zhanjun Dong
> 
>