Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v3 4/4] drm/i915/psr: Add poll for checking PSR is idle before starting update
Date: Fri,  5 Sep 2025 10:27:08 +0300	[thread overview]
Message-ID: <20250905072708.2659411-5-jouni.hogander@intel.com> (raw)
In-Reply-To: <20250905072708.2659411-1-jouni.hogander@intel.com>

We are currently observing crc failures after we started using dsb for PSR
updates as well. This seems to happen because PSR HW is still sending
couple of updates using old framebuffers on wake-up.

Fix this by adding poll ensuring PSR is idle before starting update.

v2: pass new_crtc_state->dsb_commit to intel_psr_wait_for_idle_dsb

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index c1a3a95c65f0..5dca7f96b425 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7271,6 +7271,9 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,
 		intel_psr_trigger_frame_change_event(new_crtc_state->dsb_commit,
 						     state, crtc);
 
+		intel_psr_wait_for_idle_dsb(new_crtc_state->dsb_commit,
+					    new_crtc_state);
+
 		if (new_crtc_state->use_dsb)
 			intel_dsb_vblank_evade(state, new_crtc_state->dsb_commit);
 
-- 
2.43.0


  parent reply	other threads:[~2025-09-05  7:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05  7:27 [PATCH v3 0/4] Wait PSR idle before on dsb commit Jouni Högander
2025-09-05  7:27 ` [PATCH v3 1/4] drm/i915/psr: Pass intel_crtc_state instead of intel_dp in wait_for_idle Jouni Högander
2025-09-05  7:27 ` [PATCH v3 2/4] drm/i915/psr: Add new define for PSR idle timeout Jouni Högander
2025-09-05  7:27 ` [PATCH v3 3/4] drm/i915/psr: New interface adding PSR idle poll into dsb commit Jouni Högander
2025-09-05  7:27 ` Jouni Högander [this message]
2025-09-05  9:17   ` [PATCH v3 4/4] drm/i915/psr: Add poll for checking PSR is idle before starting update Ville Syrjälä
2025-09-05  8:00 ` ✓ CI.KUnit: success for Wait PSR idle before on dsb commit (rev3) Patchwork
2025-09-05  8:15 ` ✗ CI.checksparse: warning " Patchwork
2025-09-05 18:02 ` ✗ Xe.CI.Full: failure " Patchwork
2025-09-08  5:09 ` ✓ CI.KUnit: success for Wait PSR idle before on dsb commit (rev4) Patchwork
2025-09-08  5:24 ` ✗ CI.checksparse: warning " Patchwork
2025-09-08  5:41 ` ✓ Xe.CI.BAT: success " Patchwork
2025-09-08  6:54 ` ✓ Xe.CI.Full: " Patchwork
2025-09-08  7:32 ` [PATCH v3 0/4] Wait PSR idle before on dsb commit Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250905072708.2659411-5-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox