Re: [PATCH 3/4] drm/xe/pf: Update LMTT to use tile-based messages

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on nie [2025-paź-05 15:36:39 +0200]:
> Since now we have tile-based SR-IOV printk macros, there is no
> need to manually prepare the LMTT specific warning message (that
> is now upgraded to proper error level message) nor to use generic
> debug message without tile/LMTT identification.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_lmtt.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_lmtt.c b/drivers/gpu/drm/xe/xe_lmtt.c
> index 62fc5a1a332d..4dc1de482eee 100644
> --- a/drivers/gpu/drm/xe/xe_lmtt.c
> +++ b/drivers/gpu/drm/xe/xe_lmtt.c
> @@ -17,7 +17,7 @@
>  #include "xe_mmio.h"
>  #include "xe_res_cursor.h"
>  #include "xe_sriov.h"
> -#include "xe_sriov_printk.h"
> +#include "xe_tile_sriov_printk.h"
>  
>  /**
>   * DOC: Local Memory Translation Table
> @@ -32,7 +32,7 @@
>   */
>  
>  #define lmtt_assert(lmtt, condition)	xe_tile_assert(lmtt_to_tile(lmtt), condition)
> -#define lmtt_debug(lmtt, msg...)	xe_sriov_dbg_verbose(lmtt_to_xe(lmtt), "LMTT: " msg)
> +#define lmtt_debug(lmtt, msg...)	xe_tile_sriov_dbg_verbose(lmtt_to_tile(lmtt), "LMTT: " msg)
>  
>  static bool xe_has_multi_level_lmtt(struct xe_device *xe)
>  {
> @@ -267,15 +267,14 @@ static int lmtt_invalidate_hw(struct xe_lmtt *lmtt)
>   */
>  void xe_lmtt_invalidate_hw(struct xe_lmtt *lmtt)
>  {
> -	struct xe_device *xe = lmtt_to_xe(lmtt);
>  	int err;
>  
> -	lmtt_assert(lmtt, IS_SRIOV_PF(xe));
> +	lmtt_assert(lmtt, IS_SRIOV_PF(lmtt_to_xe(lmtt)));
>  
>  	err = lmtt_invalidate_hw(lmtt);
>  	if (err)
> -		xe_sriov_warn(xe, "LMTT%u invalidation failed (%pe)",
> -			      lmtt_to_tile(lmtt)->id, ERR_PTR(err));
> +		xe_tile_sriov_err(lmtt_to_tile(lmtt), "LMTT invalidation failed (%pe)",
> +				  ERR_PTR(err));
>  }

LGTM:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

>  
>  static void lmtt_write_pte(struct xe_lmtt *lmtt, struct xe_lmtt_pt *pt,
> -- 
> 2.47.1
> 

--