Re: [PATCH 4/4] drm/xe: Update MEMIRQ to use tile-based printk macros

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on nie [2025-paź-05 15:36:40 +0200]:
> We already have tile-based printk macros, there is no need to
> manually prepare MEMIRQ specific messages to include tile id.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_memirq.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_memirq.c b/drivers/gpu/drm/xe/xe_memirq.c
> index 49c45ec3e83c..0affede05820 100644
> --- a/drivers/gpu/drm/xe/xe_memirq.c
> +++ b/drivers/gpu/drm/xe/xe_memirq.c
> @@ -14,16 +14,15 @@
>  #include "xe_device.h"
>  #include "xe_device_types.h"
>  #include "xe_gt.h"
> -#include "xe_gt_printk.h"
>  #include "xe_guc.h"
>  #include "xe_hw_engine.h"
>  #include "xe_map.h"
>  #include "xe_memirq.h"
> +#include "xe_tile_printk.h"
>  
>  #define memirq_assert(m, condition)	xe_tile_assert(memirq_to_tile(m), condition)
>  #define memirq_printk(m, _level, _fmt, ...)			\
> -	drm_##_level(&memirq_to_xe(m)->drm, "MEMIRQ%u: " _fmt,	\
> -		     memirq_to_tile(m)->id, ##__VA_ARGS__)
> +	xe_tile_##_level(memirq_to_tile(m), "MEMIRQ: " _fmt, ##__VA_ARGS__)
>  
>  #ifdef CONFIG_DRM_XE_DEBUG_MEMIRQ
>  #define memirq_debug(m, _fmt, ...)	memirq_printk(m, dbg, _fmt, ##__VA_ARGS__)

LGTM:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

> -- 
> 2.47.1
> 

--