* [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex.
@ 2025-07-23 14:24 Maarten Lankhorst
2025-07-23 17:53 ` ✗ CI.checkpatch: warning for devcoredump: Fix circular locking dependency with devcd->mutex. (rev3) Patchwork
` (6 more replies)
0 siblings, 7 replies; 13+ messages in thread
From: Maarten Lankhorst @ 2025-07-23 14:24 UTC (permalink / raw)
To: linux-kernel
Cc: intel-xe, Maarten Lankhorst, Mukesh Ojha, Greg Kroah-Hartman,
Johannes Berg, Rafael J. Wysocki, Danilo Krummrich, stable,
Matthew Brost
The original code causes a circular locking dependency found by lockdep.
======================================================
WARNING: possible circular locking dependency detected
6.16.0-rc6-lgci-xe-xe-pw-151626v3+ #1 Tainted: G S U
------------------------------------------------------
xe_fault_inject/5091 is trying to acquire lock:
ffff888156815688 ((work_completion)(&(&devcd->del_wk)->work)){+.+.}-{0:0}, at: __flush_work+0x25d/0x660
but task is already holding lock:
ffff888156815620 (&devcd->mutex){+.+.}-{3:3}, at: dev_coredump_put+0x3f/0xa0
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&devcd->mutex){+.+.}-{3:3}:
mutex_lock_nested+0x4e/0xc0
devcd_data_write+0x27/0x90
sysfs_kf_bin_write+0x80/0xf0
kernfs_fop_write_iter+0x169/0x220
vfs_write+0x293/0x560
ksys_write+0x72/0xf0
__x64_sys_write+0x19/0x30
x64_sys_call+0x2bf/0x2660
do_syscall_64+0x93/0xb60
entry_SYSCALL_64_after_hwframe+0x76/0x7e
-> #1 (kn->active#236){++++}-{0:0}:
kernfs_drain+0x1e2/0x200
__kernfs_remove+0xae/0x400
kernfs_remove_by_name_ns+0x5d/0xc0
remove_files+0x54/0x70
sysfs_remove_group+0x3d/0xa0
sysfs_remove_groups+0x2e/0x60
device_remove_attrs+0xc7/0x100
device_del+0x15d/0x3b0
devcd_del+0x19/0x30
process_one_work+0x22b/0x6f0
worker_thread+0x1e8/0x3d0
kthread+0x11c/0x250
ret_from_fork+0x26c/0x2e0
ret_from_fork_asm+0x1a/0x30
-> #0 ((work_completion)(&(&devcd->del_wk)->work)){+.+.}-{0:0}:
__lock_acquire+0x1661/0x2860
lock_acquire+0xc4/0x2f0
__flush_work+0x27a/0x660
flush_delayed_work+0x5d/0xa0
dev_coredump_put+0x63/0xa0
xe_driver_devcoredump_fini+0x12/0x20 [xe]
devm_action_release+0x12/0x30
release_nodes+0x3a/0x120
devres_release_all+0x8a/0xd0
device_unbind_cleanup+0x12/0x80
device_release_driver_internal+0x23a/0x280
device_driver_detach+0x14/0x20
unbind_store+0xaf/0xc0
drv_attr_store+0x21/0x50
sysfs_kf_write+0x4a/0x80
kernfs_fop_write_iter+0x169/0x220
vfs_write+0x293/0x560
ksys_write+0x72/0xf0
__x64_sys_write+0x19/0x30
x64_sys_call+0x2bf/0x2660
do_syscall_64+0x93/0xb60
entry_SYSCALL_64_after_hwframe+0x76/0x7e
other info that might help us debug this:
Chain exists of: (work_completion)(&(&devcd->del_wk)->work) --> kn->active#236 --> &devcd->mutex
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&devcd->mutex);
lock(kn->active#236);
lock(&devcd->mutex);
lock((work_completion)(&(&devcd->del_wk)->work));
*** DEADLOCK ***
5 locks held by xe_fault_inject/5091:
#0: ffff8881129f9488 (sb_writers#5){.+.+}-{0:0}, at: ksys_write+0x72/0xf0
#1: ffff88810c755078 (&of->mutex#2){+.+.}-{3:3}, at: kernfs_fop_write_iter+0x123/0x220
#2: ffff8881054811a0 (&dev->mutex){....}-{3:3}, at: device_release_driver_internal+0x55/0x280
#3: ffff888156815620 (&devcd->mutex){+.+.}-{3:3}, at: dev_coredump_put+0x3f/0xa0
#4: ffffffff8359e020 (rcu_read_lock){....}-{1:2}, at: __flush_work+0x72/0x660
stack backtrace:
CPU: 14 UID: 0 PID: 5091 Comm: xe_fault_inject Tainted: G S U 6.16.0-rc6-lgci-xe-xe-pw-151626v3+ #1 PREEMPT_{RT,(lazy)}
Tainted: [S]=CPU_OUT_OF_SPEC, [U]=USER
Hardware name: Micro-Star International Co., Ltd. MS-7D25/PRO Z690-A DDR4(MS-7D25), BIOS 1.10 12/13/2021
Call Trace:
<TASK>
dump_stack_lvl+0x91/0xf0
dump_stack+0x10/0x20
print_circular_bug+0x285/0x360
check_noncircular+0x135/0x150
? register_lock_class+0x48/0x4a0
__lock_acquire+0x1661/0x2860
lock_acquire+0xc4/0x2f0
? __flush_work+0x25d/0x660
? mark_held_locks+0x46/0x90
? __flush_work+0x25d/0x660
__flush_work+0x27a/0x660
? __flush_work+0x25d/0x660
? trace_hardirqs_on+0x1e/0xd0
? __pfx_wq_barrier_func+0x10/0x10
flush_delayed_work+0x5d/0xa0
dev_coredump_put+0x63/0xa0
xe_driver_devcoredump_fini+0x12/0x20 [xe]
devm_action_release+0x12/0x30
release_nodes+0x3a/0x120
devres_release_all+0x8a/0xd0
device_unbind_cleanup+0x12/0x80
device_release_driver_internal+0x23a/0x280
? bus_find_device+0xa8/0xe0
device_driver_detach+0x14/0x20
unbind_store+0xaf/0xc0
drv_attr_store+0x21/0x50
sysfs_kf_write+0x4a/0x80
kernfs_fop_write_iter+0x169/0x220
vfs_write+0x293/0x560
ksys_write+0x72/0xf0
__x64_sys_write+0x19/0x30
x64_sys_call+0x2bf/0x2660
do_syscall_64+0x93/0xb60
? __f_unlock_pos+0x15/0x20
? __x64_sys_getdents64+0x9b/0x130
? __pfx_filldir64+0x10/0x10
? do_syscall_64+0x1a2/0xb60
? clear_bhb_loop+0x30/0x80
? clear_bhb_loop+0x30/0x80
entry_SYSCALL_64_after_hwframe+0x76/0x7e
RIP: 0033:0x76e292edd574
Code: c7 00 16 00 00 00 b8 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 80 3d d5 ea 0e 00 00 74 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 55 48 89 e5 48 83 ec 20 48 89
RSP: 002b:00007fffe247a828 EFLAGS: 00000202 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 000076e292edd574
RDX: 000000000000000c RSI: 00006267f6306063 RDI: 000000000000000b
RBP: 000000000000000c R08: 000076e292fc4b20 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000202 R12: 00006267f6306063
R13: 000000000000000b R14: 00006267e6859c00 R15: 000076e29322a000
</TASK>
xe 0000:03:00.0: [drm] Xe device coredump has been deleted.
Fixes: 01daccf74832 ("devcoredump : Serialize devcd_del work")
Cc: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: linux-kernel@vger.kernel.org
Cc: <stable@vger.kernel.org> # v6.1+
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
Cc: Matthew Brost <matthew.brost@intel.com>
---
drivers/base/devcoredump.c | 136 ++++++++++++++++++++++---------------
1 file changed, 83 insertions(+), 53 deletions(-)
diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c
index 03a39c417dc41..ad4bddde12ccb 100644
--- a/drivers/base/devcoredump.c
+++ b/drivers/base/devcoredump.c
@@ -23,50 +23,46 @@ struct devcd_entry {
void *data;
size_t datalen;
/*
- * Here, mutex is required to serialize the calls to del_wk work between
- * user/kernel space which happens when devcd is added with device_add()
- * and that sends uevent to user space. User space reads the uevents,
- * and calls to devcd_data_write() which try to modify the work which is
- * not even initialized/queued from devcoredump.
+ * There are 2 races for which mutex is required.
*
+ * The first race is between device creation and userspace writing to
+ * schedule immediately destruction.
*
+ * This race is handled by arming the timer before device creation, but
+ * when device creation fails the timer still exists.
*
- * cpu0(X) cpu1(Y)
+ * To solve this, hold the mutex during device_add(), and set
+ * init_completed on success before releasing the mutex.
*
- * dev_coredump() uevent sent to user space
- * device_add() ======================> user space process Y reads the
- * uevents writes to devcd fd
- * which results into writes to
+ * That way the timer will never fire until device_add() is called,
+ * it will do nothing if init_completed is not set. The timer is also
+ * cancelled in that case.
*
- * devcd_data_write()
- * mod_delayed_work()
- * try_to_grab_pending()
- * timer_delete()
- * debug_assert_init()
- * INIT_DELAYED_WORK()
- * schedule_delayed_work()
- *
- *
- * Also, mutex alone would not be enough to avoid scheduling of
- * del_wk work after it get flush from a call to devcd_free()
- * mentioned as below.
- *
- * disabled_store()
- * devcd_free()
- * mutex_lock() devcd_data_write()
- * flush_delayed_work()
- * mutex_unlock()
- * mutex_lock()
- * mod_delayed_work()
- * mutex_unlock()
- * So, delete_work flag is required.
+ * The second race involves multiple parallel invocations of devcd_free(),
+ * add a deleted flag so only 1 can call the destructor.
*/
struct mutex mutex;
- bool delete_work;
+ bool init_completed, deleted;
struct module *owner;
ssize_t (*read)(char *buffer, loff_t offset, size_t count,
void *data, size_t datalen);
void (*free)(void *data);
+ /*
+ * If nothing interferes and device_add() was returns success,
+ * del_wk will destroy the device after the timer fires.
+ *
+ * Multiple userspace processes can interfere in the working of the timer:
+ * - Writing to the coredump will reschedule the timer to run immediately,
+ * if still armed.
+ *
+ * This is handled by using "if (cancel_delayed_work()) {
+ * schedule_delayed_work() }", to prevent re-arming after having
+ * been previously fired.
+ * - Writing to /sys/class/devcoredump/disabled will destroy the
+ * coredump synchronously.
+ * This is handled by using disable_delayed_work_sync(), and then
+ * checking if deleted flag is set with &devcd->mutex held.
+ */
struct delayed_work del_wk;
struct device *failing_dev;
};
@@ -95,14 +91,27 @@ static void devcd_dev_release(struct device *dev)
kfree(devcd);
}
+static void __devcd_del(struct devcd_entry *devcd)
+{
+ devcd->deleted = true;
+ device_del(&devcd->devcd_dev);
+ put_device(&devcd->devcd_dev);
+}
+
static void devcd_del(struct work_struct *wk)
{
struct devcd_entry *devcd;
+ bool init_completed;
devcd = container_of(wk, struct devcd_entry, del_wk.work);
- device_del(&devcd->devcd_dev);
- put_device(&devcd->devcd_dev);
+ /* devcd->mutex serializes against dev_coredumpm_timeout */
+ mutex_lock(&devcd->mutex);
+ init_completed = devcd->init_completed;
+ mutex_unlock(&devcd->mutex);
+
+ if (init_completed)
+ __devcd_del(devcd);
}
static ssize_t devcd_data_read(struct file *filp, struct kobject *kobj,
@@ -122,12 +131,12 @@ static ssize_t devcd_data_write(struct file *filp, struct kobject *kobj,
struct device *dev = kobj_to_dev(kobj);
struct devcd_entry *devcd = dev_to_devcd(dev);
- mutex_lock(&devcd->mutex);
- if (!devcd->delete_work) {
- devcd->delete_work = true;
- mod_delayed_work(system_wq, &devcd->del_wk, 0);
- }
- mutex_unlock(&devcd->mutex);
+ /*
+ * Although it's tempting to use mod_delayed work here,
+ * that will cause a reschedule if the timer already fired.
+ */
+ if (cancel_delayed_work(&devcd->del_wk))
+ schedule_delayed_work(&devcd->del_wk, 0);
return count;
}
@@ -151,11 +160,21 @@ static int devcd_free(struct device *dev, void *data)
{
struct devcd_entry *devcd = dev_to_devcd(dev);
+ /*
+ * To prevent a race with devcd_data_write(), disable work and
+ * complete manually instead.
+ *
+ * We cannot rely on the return value of
+ * disable_delayed_work_sync() here, because it might be in the
+ * middle of a cancel_delayed_work + schedule_delayed_work pair.
+ *
+ * devcd->mutex here guards against multiple parallel invocations
+ * of devcd_free().
+ */
+ disable_delayed_work_sync(&devcd->del_wk);
mutex_lock(&devcd->mutex);
- if (!devcd->delete_work)
- devcd->delete_work = true;
-
- flush_delayed_work(&devcd->del_wk);
+ if (!devcd->deleted)
+ __devcd_del(devcd);
mutex_unlock(&devcd->mutex);
return 0;
}
@@ -179,12 +198,10 @@ static ssize_t disabled_show(const struct class *class, const struct class_attri
* put_device() <- last reference
* error = fn(dev, data) devcd_dev_release()
* devcd_free(dev, data) kfree(devcd)
- * mutex_lock(&devcd->mutex);
*
*
* In the above diagram, it looks like disabled_store() would be racing with parallelly
- * running devcd_del() and result in memory abort while acquiring devcd->mutex which
- * is called after kfree of devcd memory after dropping its last reference with
+ * running devcd_del() and result in memory abort after dropping its last reference with
* put_device(). However, this will not happens as fn(dev, data) runs
* with its own reference to device via klist_node so it is not its last reference.
* so, above situation would not occur.
@@ -374,7 +391,7 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
devcd->read = read;
devcd->free = free;
devcd->failing_dev = get_device(dev);
- devcd->delete_work = false;
+ devcd->deleted = false;
mutex_init(&devcd->mutex);
device_initialize(&devcd->devcd_dev);
@@ -383,8 +400,14 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
atomic_inc_return(&devcd_count));
devcd->devcd_dev.class = &devcd_class;
- mutex_lock(&devcd->mutex);
dev_set_uevent_suppress(&devcd->devcd_dev, true);
+
+ /* devcd->mutex prevents devcd_del() completing until init finishes */
+ mutex_lock(&devcd->mutex);
+ devcd->init_completed = false;
+ INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
+ schedule_delayed_work(&devcd->del_wk, timeout);
+
if (device_add(&devcd->devcd_dev))
goto put_device;
@@ -401,13 +424,20 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
dev_set_uevent_suppress(&devcd->devcd_dev, false);
kobject_uevent(&devcd->devcd_dev.kobj, KOBJ_ADD);
- INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
- schedule_delayed_work(&devcd->del_wk, timeout);
+
+ /*
+ * Safe to run devcd_del() now that we are done with devcd_dev.
+ * Alternatively we could have taken a ref on devcd_dev before
+ * dropping the lock.
+ */
+ devcd->init_completed = true;
mutex_unlock(&devcd->mutex);
return;
put_device:
- put_device(&devcd->devcd_dev);
mutex_unlock(&devcd->mutex);
+ cancel_delayed_work_sync(&devcd->del_wk);
+ put_device(&devcd->devcd_dev);
+
put_module:
module_put(owner);
free:
--
2.45.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
* ✗ CI.checkpatch: warning for devcoredump: Fix circular locking dependency with devcd->mutex. (rev3)
2025-07-23 14:24 [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex Maarten Lankhorst
@ 2025-07-23 17:53 ` Patchwork
2025-07-23 17:54 ` ✓ CI.KUnit: success " Patchwork
` (5 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2025-07-23 17:53 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-xe
== Series Details ==
Series: devcoredump: Fix circular locking dependency with devcd->mutex. (rev3)
URL : https://patchwork.freedesktop.org/series/151901/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
63535c743231a7497a612c53f6edbb8a7d14412d
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit ecb78369a34cd5c014f9b5879fd7e6f53070cf8b
Author: Maarten Lankhorst <dev@lankhorst.se>
Date: Wed Jul 23 16:24:16 2025 +0200
devcoredump: Fix circular locking dependency with devcd->mutex.
The original code causes a circular locking dependency found by lockdep.
======================================================
WARNING: possible circular locking dependency detected
6.16.0-rc6-lgci-xe-xe-pw-151626v3+ #1 Tainted: G S U
------------------------------------------------------
xe_fault_inject/5091 is trying to acquire lock:
ffff888156815688 ((work_completion)(&(&devcd->del_wk)->work)){+.+.}-{0:0}, at: __flush_work+0x25d/0x660
but task is already holding lock:
ffff888156815620 (&devcd->mutex){+.+.}-{3:3}, at: dev_coredump_put+0x3f/0xa0
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&devcd->mutex){+.+.}-{3:3}:
mutex_lock_nested+0x4e/0xc0
devcd_data_write+0x27/0x90
sysfs_kf_bin_write+0x80/0xf0
kernfs_fop_write_iter+0x169/0x220
vfs_write+0x293/0x560
ksys_write+0x72/0xf0
__x64_sys_write+0x19/0x30
x64_sys_call+0x2bf/0x2660
do_syscall_64+0x93/0xb60
entry_SYSCALL_64_after_hwframe+0x76/0x7e
-> #1 (kn->active#236){++++}-{0:0}:
kernfs_drain+0x1e2/0x200
__kernfs_remove+0xae/0x400
kernfs_remove_by_name_ns+0x5d/0xc0
remove_files+0x54/0x70
sysfs_remove_group+0x3d/0xa0
sysfs_remove_groups+0x2e/0x60
device_remove_attrs+0xc7/0x100
device_del+0x15d/0x3b0
devcd_del+0x19/0x30
process_one_work+0x22b/0x6f0
worker_thread+0x1e8/0x3d0
kthread+0x11c/0x250
ret_from_fork+0x26c/0x2e0
ret_from_fork_asm+0x1a/0x30
-> #0 ((work_completion)(&(&devcd->del_wk)->work)){+.+.}-{0:0}:
__lock_acquire+0x1661/0x2860
lock_acquire+0xc4/0x2f0
__flush_work+0x27a/0x660
flush_delayed_work+0x5d/0xa0
dev_coredump_put+0x63/0xa0
xe_driver_devcoredump_fini+0x12/0x20 [xe]
devm_action_release+0x12/0x30
release_nodes+0x3a/0x120
devres_release_all+0x8a/0xd0
device_unbind_cleanup+0x12/0x80
device_release_driver_internal+0x23a/0x280
device_driver_detach+0x14/0x20
unbind_store+0xaf/0xc0
drv_attr_store+0x21/0x50
sysfs_kf_write+0x4a/0x80
kernfs_fop_write_iter+0x169/0x220
vfs_write+0x293/0x560
ksys_write+0x72/0xf0
__x64_sys_write+0x19/0x30
x64_sys_call+0x2bf/0x2660
do_syscall_64+0x93/0xb60
entry_SYSCALL_64_after_hwframe+0x76/0x7e
other info that might help us debug this:
Chain exists of: (work_completion)(&(&devcd->del_wk)->work) --> kn->active#236 --> &devcd->mutex
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&devcd->mutex);
lock(kn->active#236);
lock(&devcd->mutex);
lock((work_completion)(&(&devcd->del_wk)->work));
*** DEADLOCK ***
5 locks held by xe_fault_inject/5091:
#0: ffff8881129f9488 (sb_writers#5){.+.+}-{0:0}, at: ksys_write+0x72/0xf0
#1: ffff88810c755078 (&of->mutex#2){+.+.}-{3:3}, at: kernfs_fop_write_iter+0x123/0x220
#2: ffff8881054811a0 (&dev->mutex){....}-{3:3}, at: device_release_driver_internal+0x55/0x280
#3: ffff888156815620 (&devcd->mutex){+.+.}-{3:3}, at: dev_coredump_put+0x3f/0xa0
#4: ffffffff8359e020 (rcu_read_lock){....}-{1:2}, at: __flush_work+0x72/0x660
stack backtrace:
CPU: 14 UID: 0 PID: 5091 Comm: xe_fault_inject Tainted: G S U 6.16.0-rc6-lgci-xe-xe-pw-151626v3+ #1 PREEMPT_{RT,(lazy)}
Tainted: [S]=CPU_OUT_OF_SPEC, [U]=USER
Hardware name: Micro-Star International Co., Ltd. MS-7D25/PRO Z690-A DDR4(MS-7D25), BIOS 1.10 12/13/2021
Call Trace:
<TASK>
dump_stack_lvl+0x91/0xf0
dump_stack+0x10/0x20
print_circular_bug+0x285/0x360
check_noncircular+0x135/0x150
? register_lock_class+0x48/0x4a0
__lock_acquire+0x1661/0x2860
lock_acquire+0xc4/0x2f0
? __flush_work+0x25d/0x660
? mark_held_locks+0x46/0x90
? __flush_work+0x25d/0x660
__flush_work+0x27a/0x660
? __flush_work+0x25d/0x660
? trace_hardirqs_on+0x1e/0xd0
? __pfx_wq_barrier_func+0x10/0x10
flush_delayed_work+0x5d/0xa0
dev_coredump_put+0x63/0xa0
xe_driver_devcoredump_fini+0x12/0x20 [xe]
devm_action_release+0x12/0x30
release_nodes+0x3a/0x120
devres_release_all+0x8a/0xd0
device_unbind_cleanup+0x12/0x80
device_release_driver_internal+0x23a/0x280
? bus_find_device+0xa8/0xe0
device_driver_detach+0x14/0x20
unbind_store+0xaf/0xc0
drv_attr_store+0x21/0x50
sysfs_kf_write+0x4a/0x80
kernfs_fop_write_iter+0x169/0x220
vfs_write+0x293/0x560
ksys_write+0x72/0xf0
__x64_sys_write+0x19/0x30
x64_sys_call+0x2bf/0x2660
do_syscall_64+0x93/0xb60
? __f_unlock_pos+0x15/0x20
? __x64_sys_getdents64+0x9b/0x130
? __pfx_filldir64+0x10/0x10
? do_syscall_64+0x1a2/0xb60
? clear_bhb_loop+0x30/0x80
? clear_bhb_loop+0x30/0x80
entry_SYSCALL_64_after_hwframe+0x76/0x7e
RIP: 0033:0x76e292edd574
Code: c7 00 16 00 00 00 b8 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 80 3d d5 ea 0e 00 00 74 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 55 48 89 e5 48 83 ec 20 48 89
RSP: 002b:00007fffe247a828 EFLAGS: 00000202 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 000076e292edd574
RDX: 000000000000000c RSI: 00006267f6306063 RDI: 000000000000000b
RBP: 000000000000000c R08: 000076e292fc4b20 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000202 R12: 00006267f6306063
R13: 000000000000000b R14: 00006267e6859c00 R15: 000076e29322a000
</TASK>
xe 0000:03:00.0: [drm] Xe device coredump has been deleted.
Fixes: 01daccf74832 ("devcoredump : Serialize devcd_del work")
Cc: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: linux-kernel@vger.kernel.org
Cc: <stable@vger.kernel.org> # v6.1+
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
Cc: Matthew Brost <matthew.brost@intel.com>
+ /mt/dim checkpatch 22160d1b26a745a0a939dbc792485a2404aea536 drm-intel
ecb78369a34c devcoredump: Fix circular locking dependency with devcd->mutex.
-:18: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#18:
ffff888156815620 (&devcd->mutex){+.+.}-{3:3}, at: dev_coredump_put+0x3f/0xa0
total: 0 errors, 1 warnings, 0 checks, 210 lines checked
^ permalink raw reply [flat|nested] 13+ messages in thread
* ✓ CI.KUnit: success for devcoredump: Fix circular locking dependency with devcd->mutex. (rev3)
2025-07-23 14:24 [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex Maarten Lankhorst
2025-07-23 17:53 ` ✗ CI.checkpatch: warning for devcoredump: Fix circular locking dependency with devcd->mutex. (rev3) Patchwork
@ 2025-07-23 17:54 ` Patchwork
2025-07-23 19:20 ` ✓ Xe.CI.BAT: " Patchwork
` (4 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2025-07-23 17:54 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-xe
== Series Details ==
Series: devcoredump: Fix circular locking dependency with devcd->mutex. (rev3)
URL : https://patchwork.freedesktop.org/series/151901/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[17:53:11] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[17:53:15] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[17:53:42] Starting KUnit Kernel (1/1)...
[17:53:42] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[17:53:42] ================== guc_buf (11 subtests) ===================
[17:53:42] [PASSED] test_smallest
[17:53:42] [PASSED] test_largest
[17:53:42] [PASSED] test_granular
[17:53:42] [PASSED] test_unique
[17:53:42] [PASSED] test_overlap
[17:53:42] [PASSED] test_reusable
[17:53:42] [PASSED] test_too_big
[17:53:42] [PASSED] test_flush
[17:53:42] [PASSED] test_lookup
[17:53:42] [PASSED] test_data
[17:53:42] [PASSED] test_class
[17:53:42] ===================== [PASSED] guc_buf =====================
[17:53:42] =================== guc_dbm (7 subtests) ===================
[17:53:42] [PASSED] test_empty
[17:53:42] [PASSED] test_default
[17:53:42] ======================== test_size ========================
[17:53:42] [PASSED] 4
[17:53:42] [PASSED] 8
[17:53:42] [PASSED] 32
[17:53:42] [PASSED] 256
[17:53:42] ==================== [PASSED] test_size ====================
[17:53:42] ======================= test_reuse ========================
[17:53:42] [PASSED] 4
[17:53:42] [PASSED] 8
[17:53:42] [PASSED] 32
[17:53:42] [PASSED] 256
[17:53:42] =================== [PASSED] test_reuse ====================
[17:53:42] =================== test_range_overlap ====================
[17:53:42] [PASSED] 4
[17:53:42] [PASSED] 8
[17:53:42] [PASSED] 32
[17:53:42] [PASSED] 256
[17:53:42] =============== [PASSED] test_range_overlap ================
[17:53:42] =================== test_range_compact ====================
[17:53:42] [PASSED] 4
[17:53:42] [PASSED] 8
[17:53:42] [PASSED] 32
[17:53:42] [PASSED] 256
[17:53:42] =============== [PASSED] test_range_compact ================
[17:53:42] ==================== test_range_spare =====================
[17:53:42] [PASSED] 4
[17:53:42] [PASSED] 8
[17:53:42] [PASSED] 32
[17:53:42] [PASSED] 256
[17:53:42] ================ [PASSED] test_range_spare =================
[17:53:42] ===================== [PASSED] guc_dbm =====================
[17:53:42] =================== guc_idm (6 subtests) ===================
[17:53:42] [PASSED] bad_init
[17:53:42] [PASSED] no_init
[17:53:42] [PASSED] init_fini
[17:53:42] [PASSED] check_used
[17:53:42] [PASSED] check_quota
[17:53:42] [PASSED] check_all
[17:53:42] ===================== [PASSED] guc_idm =====================
[17:53:42] ================== no_relay (3 subtests) ===================
[17:53:42] [PASSED] xe_drops_guc2pf_if_not_ready
[17:53:42] [PASSED] xe_drops_guc2vf_if_not_ready
[17:53:42] [PASSED] xe_rejects_send_if_not_ready
[17:53:42] ==================== [PASSED] no_relay =====================
[17:53:42] ================== pf_relay (14 subtests) ==================
[17:53:42] [PASSED] pf_rejects_guc2pf_too_short
[17:53:42] [PASSED] pf_rejects_guc2pf_too_long
[17:53:42] [PASSED] pf_rejects_guc2pf_no_payload
[17:53:42] [PASSED] pf_fails_no_payload
[17:53:42] [PASSED] pf_fails_bad_origin
[17:53:42] [PASSED] pf_fails_bad_type
[17:53:42] [PASSED] pf_txn_reports_error
[17:53:42] [PASSED] pf_txn_sends_pf2guc
[17:53:42] [PASSED] pf_sends_pf2guc
[17:53:42] [SKIPPED] pf_loopback_nop
[17:53:42] [SKIPPED] pf_loopback_echo
[17:53:42] [SKIPPED] pf_loopback_fail
[17:53:42] [SKIPPED] pf_loopback_busy
[17:53:42] [SKIPPED] pf_loopback_retry
[17:53:42] ==================== [PASSED] pf_relay =====================
[17:53:42] ================== vf_relay (3 subtests) ===================
[17:53:42] [PASSED] vf_rejects_guc2vf_too_short
[17:53:42] [PASSED] vf_rejects_guc2vf_too_long
[17:53:42] [PASSED] vf_rejects_guc2vf_no_payload
[17:53:42] ==================== [PASSED] vf_relay =====================
[17:53:42] ===================== lmtt (1 subtest) =====================
[17:53:42] ======================== test_ops =========================
[17:53:42] [PASSED] 2-level
[17:53:42] [PASSED] multi-level
[17:53:42] ==================== [PASSED] test_ops =====================
[17:53:42] ====================== [PASSED] lmtt =======================
[17:53:42] ================= pf_service (11 subtests) =================
[17:53:42] [PASSED] pf_negotiate_any
[17:53:42] [PASSED] pf_negotiate_base_match
[17:53:42] [PASSED] pf_negotiate_base_newer
[17:53:42] [PASSED] pf_negotiate_base_next
[17:53:42] [SKIPPED] pf_negotiate_base_older
[17:53:43] [PASSED] pf_negotiate_base_prev
[17:53:43] [PASSED] pf_negotiate_latest_match
[17:53:43] [PASSED] pf_negotiate_latest_newer
[17:53:43] [PASSED] pf_negotiate_latest_next
[17:53:43] [SKIPPED] pf_negotiate_latest_older
[17:53:43] [SKIPPED] pf_negotiate_latest_prev
[17:53:43] =================== [PASSED] pf_service ====================
[17:53:43] =================== xe_mocs (2 subtests) ===================
[17:53:43] ================ xe_live_mocs_kernel_kunit ================
[17:53:43] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[17:53:43] ================ xe_live_mocs_reset_kunit =================
[17:53:43] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[17:53:43] ==================== [SKIPPED] xe_mocs =====================
[17:53:43] ================= xe_migrate (2 subtests) ==================
[17:53:43] ================= xe_migrate_sanity_kunit =================
[17:53:43] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[17:53:43] ================== xe_validate_ccs_kunit ==================
[17:53:43] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[17:53:43] =================== [SKIPPED] xe_migrate ===================
[17:53:43] ================== xe_dma_buf (1 subtest) ==================
[17:53:43] ==================== xe_dma_buf_kunit =====================
[17:53:43] ================ [SKIPPED] xe_dma_buf_kunit ================
[17:53:43] =================== [SKIPPED] xe_dma_buf ===================
[17:53:43] ================= xe_bo_shrink (1 subtest) =================
[17:53:43] =================== xe_bo_shrink_kunit ====================
[17:53:43] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[17:53:43] ================== [SKIPPED] xe_bo_shrink ==================
[17:53:43] ==================== xe_bo (2 subtests) ====================
[17:53:43] ================== xe_ccs_migrate_kunit ===================
[17:53:43] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[17:53:43] ==================== xe_bo_evict_kunit ====================
[17:53:43] =============== [SKIPPED] xe_bo_evict_kunit ================
[17:53:43] ===================== [SKIPPED] xe_bo ======================
[17:53:43] ==================== args (11 subtests) ====================
[17:53:43] [PASSED] count_args_test
[17:53:43] [PASSED] call_args_example
[17:53:43] [PASSED] call_args_test
[17:53:43] [PASSED] drop_first_arg_example
[17:53:43] [PASSED] drop_first_arg_test
[17:53:43] [PASSED] first_arg_example
[17:53:43] [PASSED] first_arg_test
[17:53:43] [PASSED] last_arg_example
[17:53:43] [PASSED] last_arg_test
[17:53:43] [PASSED] pick_arg_example
[17:53:43] [PASSED] sep_comma_example
[17:53:43] ====================== [PASSED] args =======================
[17:53:43] =================== xe_pci (3 subtests) ====================
[17:53:43] ==================== check_graphics_ip ====================
[17:53:43] [PASSED] 12.70 Xe_LPG
[17:53:43] [PASSED] 12.71 Xe_LPG
[17:53:43] [PASSED] 12.74 Xe_LPG+
[17:53:43] [PASSED] 20.01 Xe2_HPG
[17:53:43] [PASSED] 20.02 Xe2_HPG
[17:53:43] [PASSED] 20.04 Xe2_LPG
[17:53:43] [PASSED] 30.00 Xe3_LPG
[17:53:43] [PASSED] 30.01 Xe3_LPG
[17:53:43] [PASSED] 30.03 Xe3_LPG
[17:53:43] ================ [PASSED] check_graphics_ip ================
[17:53:43] ===================== check_media_ip ======================
[17:53:43] [PASSED] 13.00 Xe_LPM+
[17:53:43] [PASSED] 13.01 Xe2_HPM
[17:53:43] [PASSED] 20.00 Xe2_LPM
[17:53:43] [PASSED] 30.00 Xe3_LPM
[17:53:43] [PASSED] 30.02 Xe3_LPM
[17:53:43] ================= [PASSED] check_media_ip ==================
[17:53:43] ================= check_platform_gt_count =================
[17:53:43] [PASSED] 0x9A60 (TIGERLAKE)
[17:53:43] [PASSED] 0x9A68 (TIGERLAKE)
[17:53:43] [PASSED] 0x9A70 (TIGERLAKE)
[17:53:43] [PASSED] 0x9A40 (TIGERLAKE)
[17:53:43] [PASSED] 0x9A49 (TIGERLAKE)
[17:53:43] [PASSED] 0x9A59 (TIGERLAKE)
[17:53:43] [PASSED] 0x9A78 (TIGERLAKE)
[17:53:43] [PASSED] 0x9AC0 (TIGERLAKE)
[17:53:43] [PASSED] 0x9AC9 (TIGERLAKE)
[17:53:43] [PASSED] 0x9AD9 (TIGERLAKE)
[17:53:43] [PASSED] 0x9AF8 (TIGERLAKE)
[17:53:43] [PASSED] 0x4C80 (ROCKETLAKE)
[17:53:43] [PASSED] 0x4C8A (ROCKETLAKE)
[17:53:43] [PASSED] 0x4C8B (ROCKETLAKE)
[17:53:43] [PASSED] 0x4C8C (ROCKETLAKE)
[17:53:43] [PASSED] 0x4C90 (ROCKETLAKE)
[17:53:43] [PASSED] 0x4C9A (ROCKETLAKE)
[17:53:43] [PASSED] 0x4680 (ALDERLAKE_S)
[17:53:43] [PASSED] 0x4682 (ALDERLAKE_S)
[17:53:43] [PASSED] 0x4688 (ALDERLAKE_S)
[17:53:43] [PASSED] 0x468A (ALDERLAKE_S)
[17:53:43] [PASSED] 0x468B (ALDERLAKE_S)
[17:53:43] [PASSED] 0x4690 (ALDERLAKE_S)
[17:53:43] [PASSED] 0x4692 (ALDERLAKE_S)
[17:53:43] [PASSED] 0x4693 (ALDERLAKE_S)
[17:53:43] [PASSED] 0x46A0 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46A1 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46A2 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46A3 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46A6 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46A8 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46AA (ALDERLAKE_P)
[17:53:43] [PASSED] 0x462A (ALDERLAKE_P)
[17:53:43] [PASSED] 0x4626 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x4628 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46B0 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46B1 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46B2 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46B3 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46C0 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46C1 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46C2 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46C3 (ALDERLAKE_P)
[17:53:43] [PASSED] 0x46D0 (ALDERLAKE_N)
[17:53:43] [PASSED] 0x46D1 (ALDERLAKE_N)
[17:53:43] [PASSED] 0x46D2 (ALDERLAKE_N)
[17:53:43] [PASSED] 0x46D3 (ALDERLAKE_N)
[17:53:43] [PASSED] 0x46D4 (ALDERLAKE_N)
[17:53:43] [PASSED] 0xA721 (ALDERLAKE_P)
[17:53:43] [PASSED] 0xA7A1 (ALDERLAKE_P)
[17:53:43] [PASSED] 0xA7A9 (ALDERLAKE_P)
[17:53:43] [PASSED] 0xA7AC (ALDERLAKE_P)
[17:53:43] [PASSED] 0xA7AD (ALDERLAKE_P)
[17:53:43] [PASSED] 0xA720 (ALDERLAKE_P)
[17:53:43] [PASSED] 0xA7A0 (ALDERLAKE_P)
[17:53:43] [PASSED] 0xA7A8 (ALDERLAKE_P)
[17:53:43] [PASSED] 0xA7AA (ALDERLAKE_P)
[17:53:43] [PASSED] 0xA7AB (ALDERLAKE_P)
[17:53:43] [PASSED] 0xA780 (ALDERLAKE_S)
[17:53:43] [PASSED] 0xA781 (ALDERLAKE_S)
[17:53:43] [PASSED] 0xA782 (ALDERLAKE_S)
[17:53:43] [PASSED] 0xA783 (ALDERLAKE_S)
[17:53:43] [PASSED] 0xA788 (ALDERLAKE_S)
[17:53:43] [PASSED] 0xA789 (ALDERLAKE_S)
[17:53:43] [PASSED] 0xA78A (ALDERLAKE_S)
[17:53:43] [PASSED] 0xA78B (ALDERLAKE_S)
[17:53:43] [PASSED] 0x4905 (DG1)
[17:53:43] [PASSED] 0x4906 (DG1)
[17:53:43] [PASSED] 0x4907 (DG1)
[17:53:43] [PASSED] 0x4908 (DG1)
[17:53:43] [PASSED] 0x4909 (DG1)
[17:53:43] [PASSED] 0x56C0 (DG2)
[17:53:43] [PASSED] 0x56C2 (DG2)
[17:53:43] [PASSED] 0x56C1 (DG2)
[17:53:43] [PASSED] 0x7D51 (METEORLAKE)
[17:53:43] [PASSED] 0x7DD1 (METEORLAKE)
[17:53:43] [PASSED] 0x7D41 (METEORLAKE)
[17:53:43] [PASSED] 0x7D67 (METEORLAKE)
[17:53:43] [PASSED] 0xB640 (METEORLAKE)
[17:53:43] [PASSED] 0x56A0 (DG2)
[17:53:43] [PASSED] 0x56A1 (DG2)
[17:53:43] [PASSED] 0x56A2 (DG2)
[17:53:43] [PASSED] 0x56BE (DG2)
[17:53:43] [PASSED] 0x56BF (DG2)
[17:53:43] [PASSED] 0x5690 (DG2)
[17:53:43] [PASSED] 0x5691 (DG2)
[17:53:43] [PASSED] 0x5692 (DG2)
[17:53:43] [PASSED] 0x56A5 (DG2)
[17:53:43] [PASSED] 0x56A6 (DG2)
[17:53:43] [PASSED] 0x56B0 (DG2)
[17:53:43] [PASSED] 0x56B1 (DG2)
[17:53:43] [PASSED] 0x56BA (DG2)
[17:53:43] [PASSED] 0x56BB (DG2)
[17:53:43] [PASSED] 0x56BC (DG2)
[17:53:43] [PASSED] 0x56BD (DG2)
[17:53:43] [PASSED] 0x5693 (DG2)
[17:53:43] [PASSED] 0x5694 (DG2)
[17:53:43] [PASSED] 0x5695 (DG2)
[17:53:43] [PASSED] 0x56A3 (DG2)
[17:53:43] [PASSED] 0x56A4 (DG2)
[17:53:43] [PASSED] 0x56B2 (DG2)
[17:53:43] [PASSED] 0x56B3 (DG2)
[17:53:43] [PASSED] 0x5696 (DG2)
[17:53:43] [PASSED] 0x5697 (DG2)
[17:53:43] [PASSED] 0xB69 (PVC)
[17:53:43] [PASSED] 0xB6E (PVC)
[17:53:43] [PASSED] 0xBD4 (PVC)
[17:53:43] [PASSED] 0xBD5 (PVC)
[17:53:43] [PASSED] 0xBD6 (PVC)
[17:53:43] [PASSED] 0xBD7 (PVC)
[17:53:43] [PASSED] 0xBD8 (PVC)
[17:53:43] [PASSED] 0xBD9 (PVC)
[17:53:43] [PASSED] 0xBDA (PVC)
[17:53:43] [PASSED] 0xBDB (PVC)
[17:53:43] [PASSED] 0xBE0 (PVC)
[17:53:43] [PASSED] 0xBE1 (PVC)
[17:53:43] [PASSED] 0xBE5 (PVC)
[17:53:43] [PASSED] 0x7D40 (METEORLAKE)
[17:53:43] [PASSED] 0x7D45 (METEORLAKE)
[17:53:43] [PASSED] 0x7D55 (METEORLAKE)
[17:53:43] [PASSED] 0x7D60 (METEORLAKE)
[17:53:43] [PASSED] 0x7DD5 (METEORLAKE)
[17:53:43] [PASSED] 0x6420 (LUNARLAKE)
[17:53:43] [PASSED] 0x64A0 (LUNARLAKE)
[17:53:43] [PASSED] 0x64B0 (LUNARLAKE)
[17:53:43] [PASSED] 0xE202 (BATTLEMAGE)
[17:53:43] [PASSED] 0xE209 (BATTLEMAGE)
[17:53:43] [PASSED] 0xE20B (BATTLEMAGE)
[17:53:43] [PASSED] 0xE20C (BATTLEMAGE)
[17:53:43] [PASSED] 0xE20D (BATTLEMAGE)
[17:53:43] [PASSED] 0xE210 (BATTLEMAGE)
[17:53:43] [PASSED] 0xE211 (BATTLEMAGE)
[17:53:43] [PASSED] 0xE212 (BATTLEMAGE)
[17:53:43] [PASSED] 0xE216 (BATTLEMAGE)
[17:53:43] [PASSED] 0xE220 (BATTLEMAGE)
[17:53:43] [PASSED] 0xE221 (BATTLEMAGE)
[17:53:43] [PASSED] 0xE222 (BATTLEMAGE)
[17:53:43] [PASSED] 0xE223 (BATTLEMAGE)
[17:53:43] [PASSED] 0xB080 (PANTHERLAKE)
[17:53:43] [PASSED] 0xB081 (PANTHERLAKE)
[17:53:43] [PASSED] 0xB082 (PANTHERLAKE)
[17:53:43] [PASSED] 0xB083 (PANTHERLAKE)
[17:53:43] [PASSED] 0xB084 (PANTHERLAKE)
[17:53:43] [PASSED] 0xB085 (PANTHERLAKE)
[17:53:43] [PASSED] 0xB086 (PANTHERLAKE)
[17:53:43] [PASSED] 0xB087 (PANTHERLAKE)
[17:53:43] [PASSED] 0xB08F (PANTHERLAKE)
[17:53:43] [PASSED] 0xB090 (PANTHERLAKE)
[17:53:43] [PASSED] 0xB0A0 (PANTHERLAKE)
[17:53:43] [PASSED] 0xB0B0 (PANTHERLAKE)
[17:53:43] [PASSED] 0xFD80 (PANTHERLAKE)
[17:53:43] [PASSED] 0xFD81 (PANTHERLAKE)
[17:53:43] ============= [PASSED] check_platform_gt_count =============
[17:53:43] ===================== [PASSED] xe_pci ======================
[17:53:43] =================== xe_rtp (2 subtests) ====================
[17:53:43] =============== xe_rtp_process_to_sr_tests ================
[17:53:43] [PASSED] coalesce-same-reg
[17:53:43] [PASSED] no-match-no-add
[17:53:43] [PASSED] match-or
[17:53:43] [PASSED] match-or-xfail
[17:53:43] [PASSED] no-match-no-add-multiple-rules
[17:53:43] [PASSED] two-regs-two-entries
[17:53:43] [PASSED] clr-one-set-other
[17:53:43] [PASSED] set-field
[17:53:43] [PASSED] conflict-duplicate
[17:53:43] [PASSED] conflict-not-disjoint
[17:53:43] [PASSED] conflict-reg-type
[17:53:43] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[17:53:43] ================== xe_rtp_process_tests ===================
[17:53:43] [PASSED] active1
[17:53:43] [PASSED] active2
[17:53:43] [PASSED] active-inactive
[17:53:43] [PASSED] inactive-active
[17:53:43] [PASSED] inactive-1st_or_active-inactive
[17:53:43] [PASSED] inactive-2nd_or_active-inactive
[17:53:43] [PASSED] inactive-last_or_active-inactive
[17:53:43] [PASSED] inactive-no_or_active-inactive
[17:53:43] ============== [PASSED] xe_rtp_process_tests ===============
[17:53:43] ===================== [PASSED] xe_rtp ======================
[17:53:43] ==================== xe_wa (1 subtest) =====================
[17:53:43] ======================== xe_wa_gt =========================
[17:53:43] [PASSED] TIGERLAKE (B0)
[17:53:43] [PASSED] DG1 (A0)
[17:53:43] [PASSED] DG1 (B0)
[17:53:43] [PASSED] ALDERLAKE_S (A0)
[17:53:43] [PASSED] ALDERLAKE_S (B0)
[17:53:43] [PASSED] ALDERLAKE_S (C0)
[17:53:43] [PASSED] ALDERLAKE_S (D0)
[17:53:43] [PASSED] ALDERLAKE_P (A0)
[17:53:43] [PASSED] ALDERLAKE_P (B0)
[17:53:43] [PASSED] ALDERLAKE_P (C0)
[17:53:43] [PASSED] ALDERLAKE_S_RPLS (D0)
[17:53:43] [PASSED] ALDERLAKE_P_RPLU (E0)
[17:53:43] [PASSED] DG2_G10 (C0)
[17:53:43] [PASSED] DG2_G11 (B1)
[17:53:43] [PASSED] DG2_G12 (A1)
[17:53:43] [PASSED] METEORLAKE (g:A0, m:A0)
[17:53:43] [PASSED] METEORLAKE (g:A0, m:A0)
[17:53:43] [PASSED] METEORLAKE (g:A0, m:A0)
[17:53:43] [PASSED] LUNARLAKE (g:A0, m:A0)
[17:53:43] [PASSED] LUNARLAKE (g:B0, m:A0)
stty: 'standard input': Inappropriate ioctl for device
[17:53:43] [PASSED] BATTLEMAGE (g:A0, m:A1)
[17:53:43] ==================== [PASSED] xe_wa_gt =====================
[17:53:43] ====================== [PASSED] xe_wa ======================
[17:53:43] ============================================================
[17:53:43] Testing complete. Ran 297 tests: passed: 281, skipped: 16
[17:53:43] Elapsed time: 31.608s total, 4.202s configuring, 27.039s building, 0.326s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[17:53:43] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[17:53:44] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[17:54:06] Starting KUnit Kernel (1/1)...
[17:54:06] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[17:54:06] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[17:54:06] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[17:54:06] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[17:54:06] =========== drm_validate_clone_mode (2 subtests) ===========
[17:54:06] ============== drm_test_check_in_clone_mode ===============
[17:54:06] [PASSED] in_clone_mode
[17:54:06] [PASSED] not_in_clone_mode
[17:54:06] ========== [PASSED] drm_test_check_in_clone_mode ===========
[17:54:06] =============== drm_test_check_valid_clones ===============
[17:54:06] [PASSED] not_in_clone_mode
[17:54:06] [PASSED] valid_clone
[17:54:06] [PASSED] invalid_clone
[17:54:06] =========== [PASSED] drm_test_check_valid_clones ===========
[17:54:06] ============= [PASSED] drm_validate_clone_mode =============
[17:54:06] ============= drm_validate_modeset (1 subtest) =============
[17:54:06] [PASSED] drm_test_check_connector_changed_modeset
[17:54:06] ============== [PASSED] drm_validate_modeset ===============
[17:54:06] ====== drm_test_bridge_get_current_state (2 subtests) ======
[17:54:06] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[17:54:06] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[17:54:06] ======== [PASSED] drm_test_bridge_get_current_state ========
[17:54:06] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[17:54:06] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[17:54:06] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[17:54:06] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[17:54:06] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[17:54:06] ============== drm_bridge_alloc (2 subtests) ===============
[17:54:06] [PASSED] drm_test_drm_bridge_alloc_basic
[17:54:06] [PASSED] drm_test_drm_bridge_alloc_get_put
[17:54:06] ================ [PASSED] drm_bridge_alloc =================
[17:54:06] ================== drm_buddy (7 subtests) ==================
[17:54:06] [PASSED] drm_test_buddy_alloc_limit
[17:54:06] [PASSED] drm_test_buddy_alloc_optimistic
[17:54:06] [PASSED] drm_test_buddy_alloc_pessimistic
[17:54:06] [PASSED] drm_test_buddy_alloc_pathological
[17:54:06] [PASSED] drm_test_buddy_alloc_contiguous
[17:54:06] [PASSED] drm_test_buddy_alloc_clear
[17:54:06] [PASSED] drm_test_buddy_alloc_range_bias
[17:54:06] ==================== [PASSED] drm_buddy ====================
[17:54:06] ============= drm_cmdline_parser (40 subtests) =============
[17:54:06] [PASSED] drm_test_cmdline_force_d_only
[17:54:06] [PASSED] drm_test_cmdline_force_D_only_dvi
[17:54:06] [PASSED] drm_test_cmdline_force_D_only_hdmi
[17:54:06] [PASSED] drm_test_cmdline_force_D_only_not_digital
[17:54:06] [PASSED] drm_test_cmdline_force_e_only
[17:54:06] [PASSED] drm_test_cmdline_res
[17:54:06] [PASSED] drm_test_cmdline_res_vesa
[17:54:06] [PASSED] drm_test_cmdline_res_vesa_rblank
[17:54:06] [PASSED] drm_test_cmdline_res_rblank
[17:54:06] [PASSED] drm_test_cmdline_res_bpp
[17:54:06] [PASSED] drm_test_cmdline_res_refresh
[17:54:06] [PASSED] drm_test_cmdline_res_bpp_refresh
[17:54:06] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[17:54:06] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[17:54:06] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[17:54:06] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[17:54:06] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[17:54:06] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[17:54:06] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[17:54:06] [PASSED] drm_test_cmdline_res_margins_force_on
[17:54:06] [PASSED] drm_test_cmdline_res_vesa_margins
[17:54:06] [PASSED] drm_test_cmdline_name
[17:54:06] [PASSED] drm_test_cmdline_name_bpp
[17:54:06] [PASSED] drm_test_cmdline_name_option
[17:54:06] [PASSED] drm_test_cmdline_name_bpp_option
[17:54:06] [PASSED] drm_test_cmdline_rotate_0
[17:54:06] [PASSED] drm_test_cmdline_rotate_90
[17:54:06] [PASSED] drm_test_cmdline_rotate_180
[17:54:06] [PASSED] drm_test_cmdline_rotate_270
[17:54:06] [PASSED] drm_test_cmdline_hmirror
[17:54:06] [PASSED] drm_test_cmdline_vmirror
[17:54:06] [PASSED] drm_test_cmdline_margin_options
[17:54:06] [PASSED] drm_test_cmdline_multiple_options
[17:54:06] [PASSED] drm_test_cmdline_bpp_extra_and_option
[17:54:06] [PASSED] drm_test_cmdline_extra_and_option
[17:54:06] [PASSED] drm_test_cmdline_freestanding_options
[17:54:06] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[17:54:06] [PASSED] drm_test_cmdline_panel_orientation
[17:54:06] ================ drm_test_cmdline_invalid =================
[17:54:06] [PASSED] margin_only
[17:54:06] [PASSED] interlace_only
[17:54:06] [PASSED] res_missing_x
[17:54:06] [PASSED] res_missing_y
[17:54:06] [PASSED] res_bad_y
[17:54:06] [PASSED] res_missing_y_bpp
[17:54:06] [PASSED] res_bad_bpp
[17:54:06] [PASSED] res_bad_refresh
[17:54:06] [PASSED] res_bpp_refresh_force_on_off
[17:54:06] [PASSED] res_invalid_mode
[17:54:06] [PASSED] res_bpp_wrong_place_mode
[17:54:06] [PASSED] name_bpp_refresh
[17:54:06] [PASSED] name_refresh
[17:54:06] [PASSED] name_refresh_wrong_mode
[17:54:06] [PASSED] name_refresh_invalid_mode
[17:54:06] [PASSED] rotate_multiple
[17:54:06] [PASSED] rotate_invalid_val
[17:54:06] [PASSED] rotate_truncated
[17:54:06] [PASSED] invalid_option
[17:54:06] [PASSED] invalid_tv_option
[17:54:06] [PASSED] truncated_tv_option
[17:54:06] ============ [PASSED] drm_test_cmdline_invalid =============
[17:54:06] =============== drm_test_cmdline_tv_options ===============
[17:54:06] [PASSED] NTSC
[17:54:06] [PASSED] NTSC_443
[17:54:06] [PASSED] NTSC_J
[17:54:06] [PASSED] PAL
[17:54:06] [PASSED] PAL_M
[17:54:06] [PASSED] PAL_N
[17:54:06] [PASSED] SECAM
[17:54:06] [PASSED] MONO_525
[17:54:06] [PASSED] MONO_625
[17:54:06] =========== [PASSED] drm_test_cmdline_tv_options ===========
[17:54:06] =============== [PASSED] drm_cmdline_parser ================
[17:54:06] ========== drmm_connector_hdmi_init (20 subtests) ==========
[17:54:06] [PASSED] drm_test_connector_hdmi_init_valid
[17:54:06] [PASSED] drm_test_connector_hdmi_init_bpc_8
[17:54:06] [PASSED] drm_test_connector_hdmi_init_bpc_10
[17:54:06] [PASSED] drm_test_connector_hdmi_init_bpc_12
[17:54:06] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[17:54:06] [PASSED] drm_test_connector_hdmi_init_bpc_null
[17:54:06] [PASSED] drm_test_connector_hdmi_init_formats_empty
[17:54:06] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[17:54:06] === drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[17:54:06] [PASSED] supported_formats=0x9 yuv420_allowed=1
[17:54:06] [PASSED] supported_formats=0x9 yuv420_allowed=0
[17:54:06] [PASSED] supported_formats=0x3 yuv420_allowed=1
[17:54:06] [PASSED] supported_formats=0x3 yuv420_allowed=0
[17:54:06] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[17:54:06] [PASSED] drm_test_connector_hdmi_init_null_ddc
[17:54:06] [PASSED] drm_test_connector_hdmi_init_null_product
[17:54:06] [PASSED] drm_test_connector_hdmi_init_null_vendor
[17:54:06] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[17:54:06] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[17:54:06] [PASSED] drm_test_connector_hdmi_init_product_valid
[17:54:06] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[17:54:06] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[17:54:06] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[17:54:06] ========= drm_test_connector_hdmi_init_type_valid =========
[17:54:06] [PASSED] HDMI-A
[17:54:06] [PASSED] HDMI-B
[17:54:06] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[17:54:06] ======== drm_test_connector_hdmi_init_type_invalid ========
[17:54:06] [PASSED] Unknown
[17:54:06] [PASSED] VGA
[17:54:06] [PASSED] DVI-I
[17:54:06] [PASSED] DVI-D
[17:54:06] [PASSED] DVI-A
[17:54:06] [PASSED] Composite
[17:54:06] [PASSED] SVIDEO
[17:54:06] [PASSED] LVDS
[17:54:06] [PASSED] Component
[17:54:06] [PASSED] DIN
[17:54:06] [PASSED] DP
[17:54:06] [PASSED] TV
[17:54:06] [PASSED] eDP
[17:54:06] [PASSED] Virtual
[17:54:06] [PASSED] DSI
[17:54:06] [PASSED] DPI
[17:54:06] [PASSED] Writeback
[17:54:06] [PASSED] SPI
[17:54:06] [PASSED] USB
[17:54:06] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[17:54:06] ============ [PASSED] drmm_connector_hdmi_init =============
[17:54:06] ============= drmm_connector_init (3 subtests) =============
[17:54:06] [PASSED] drm_test_drmm_connector_init
[17:54:06] [PASSED] drm_test_drmm_connector_init_null_ddc
[17:54:06] ========= drm_test_drmm_connector_init_type_valid =========
[17:54:06] [PASSED] Unknown
[17:54:06] [PASSED] VGA
[17:54:06] [PASSED] DVI-I
[17:54:06] [PASSED] DVI-D
[17:54:06] [PASSED] DVI-A
[17:54:06] [PASSED] Composite
[17:54:06] [PASSED] SVIDEO
[17:54:06] [PASSED] LVDS
[17:54:06] [PASSED] Component
[17:54:06] [PASSED] DIN
[17:54:06] [PASSED] DP
[17:54:06] [PASSED] HDMI-A
[17:54:06] [PASSED] HDMI-B
[17:54:06] [PASSED] TV
[17:54:06] [PASSED] eDP
[17:54:06] [PASSED] Virtual
[17:54:06] [PASSED] DSI
[17:54:06] [PASSED] DPI
[17:54:06] [PASSED] Writeback
[17:54:06] [PASSED] SPI
[17:54:06] [PASSED] USB
[17:54:06] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[17:54:06] =============== [PASSED] drmm_connector_init ===============
[17:54:06] ========= drm_connector_dynamic_init (6 subtests) ==========
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_init
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_init_properties
[17:54:06] ===== drm_test_drm_connector_dynamic_init_type_valid ======
[17:54:06] [PASSED] Unknown
[17:54:06] [PASSED] VGA
[17:54:06] [PASSED] DVI-I
[17:54:06] [PASSED] DVI-D
[17:54:06] [PASSED] DVI-A
[17:54:06] [PASSED] Composite
[17:54:06] [PASSED] SVIDEO
[17:54:06] [PASSED] LVDS
[17:54:06] [PASSED] Component
[17:54:06] [PASSED] DIN
[17:54:06] [PASSED] DP
[17:54:06] [PASSED] HDMI-A
[17:54:06] [PASSED] HDMI-B
[17:54:06] [PASSED] TV
[17:54:06] [PASSED] eDP
[17:54:06] [PASSED] Virtual
[17:54:06] [PASSED] DSI
[17:54:06] [PASSED] DPI
[17:54:06] [PASSED] Writeback
[17:54:06] [PASSED] SPI
[17:54:06] [PASSED] USB
[17:54:06] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[17:54:06] ======== drm_test_drm_connector_dynamic_init_name =========
[17:54:06] [PASSED] Unknown
[17:54:06] [PASSED] VGA
[17:54:06] [PASSED] DVI-I
[17:54:06] [PASSED] DVI-D
[17:54:06] [PASSED] DVI-A
[17:54:06] [PASSED] Composite
[17:54:06] [PASSED] SVIDEO
[17:54:06] [PASSED] LVDS
[17:54:06] [PASSED] Component
[17:54:06] [PASSED] DIN
[17:54:06] [PASSED] DP
[17:54:06] [PASSED] HDMI-A
[17:54:06] [PASSED] HDMI-B
[17:54:06] [PASSED] TV
[17:54:06] [PASSED] eDP
[17:54:06] [PASSED] Virtual
[17:54:06] [PASSED] DSI
[17:54:06] [PASSED] DPI
[17:54:06] [PASSED] Writeback
[17:54:06] [PASSED] SPI
[17:54:06] [PASSED] USB
[17:54:06] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[17:54:06] =========== [PASSED] drm_connector_dynamic_init ============
[17:54:06] ==== drm_connector_dynamic_register_early (4 subtests) =====
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[17:54:06] ====== [PASSED] drm_connector_dynamic_register_early =======
[17:54:06] ======= drm_connector_dynamic_register (7 subtests) ========
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[17:54:06] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[17:54:06] ========= [PASSED] drm_connector_dynamic_register ==========
[17:54:06] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[17:54:06] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[17:54:06] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[17:54:06] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[17:54:06] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[17:54:06] ========== drm_test_get_tv_mode_from_name_valid ===========
[17:54:06] [PASSED] NTSC
[17:54:06] [PASSED] NTSC-443
[17:54:06] [PASSED] NTSC-J
[17:54:06] [PASSED] PAL
[17:54:06] [PASSED] PAL-M
[17:54:06] [PASSED] PAL-N
[17:54:06] [PASSED] SECAM
[17:54:06] [PASSED] Mono
[17:54:06] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[17:54:06] [PASSED] drm_test_get_tv_mode_from_name_truncated
[17:54:06] ============ [PASSED] drm_get_tv_mode_from_name ============
[17:54:06] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[17:54:06] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[17:54:06] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[17:54:06] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[17:54:06] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[17:54:06] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[17:54:06] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[17:54:06] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid =
[17:54:06] [PASSED] VIC 96
[17:54:06] [PASSED] VIC 97
[17:54:06] [PASSED] VIC 101
[17:54:06] [PASSED] VIC 102
[17:54:06] [PASSED] VIC 106
[17:54:06] [PASSED] VIC 107
[17:54:06] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[17:54:06] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[17:54:06] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[17:54:06] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[17:54:06] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[17:54:06] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[17:54:06] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[17:54:06] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[17:54:06] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ====
[17:54:06] [PASSED] Automatic
[17:54:06] [PASSED] Full
[17:54:06] [PASSED] Limited 16:235
[17:54:06] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[17:54:06] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[17:54:06] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[17:54:06] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[17:54:06] === drm_test_drm_hdmi_connector_get_output_format_name ====
[17:54:06] [PASSED] RGB
[17:54:06] [PASSED] YUV 4:2:0
[17:54:06] [PASSED] YUV 4:2:2
[17:54:06] [PASSED] YUV 4:4:4
[17:54:06] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[17:54:06] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[17:54:06] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[17:54:06] ============= drm_damage_helper (21 subtests) ==============
[17:54:06] [PASSED] drm_test_damage_iter_no_damage
[17:54:06] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[17:54:06] [PASSED] drm_test_damage_iter_no_damage_src_moved
[17:54:06] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[17:54:06] [PASSED] drm_test_damage_iter_no_damage_not_visible
[17:54:06] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[17:54:06] [PASSED] drm_test_damage_iter_no_damage_no_fb
[17:54:06] [PASSED] drm_test_damage_iter_simple_damage
[17:54:06] [PASSED] drm_test_damage_iter_single_damage
[17:54:06] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[17:54:06] [PASSED] drm_test_damage_iter_single_damage_outside_src
[17:54:06] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[17:54:06] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[17:54:06] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[17:54:06] [PASSED] drm_test_damage_iter_single_damage_src_moved
[17:54:06] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[17:54:06] [PASSED] drm_test_damage_iter_damage
[17:54:06] [PASSED] drm_test_damage_iter_damage_one_intersect
[17:54:06] [PASSED] drm_test_damage_iter_damage_one_outside
[17:54:06] [PASSED] drm_test_damage_iter_damage_src_moved
[17:54:06] [PASSED] drm_test_damage_iter_damage_not_visible
[17:54:06] ================ [PASSED] drm_damage_helper ================
[17:54:06] ============== drm_dp_mst_helper (3 subtests) ==============
[17:54:06] ============== drm_test_dp_mst_calc_pbn_mode ==============
[17:54:06] [PASSED] Clock 154000 BPP 30 DSC disabled
[17:54:06] [PASSED] Clock 234000 BPP 30 DSC disabled
[17:54:06] [PASSED] Clock 297000 BPP 24 DSC disabled
[17:54:06] [PASSED] Clock 332880 BPP 24 DSC enabled
[17:54:06] [PASSED] Clock 324540 BPP 24 DSC enabled
[17:54:06] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[17:54:06] ============== drm_test_dp_mst_calc_pbn_div ===============
[17:54:06] [PASSED] Link rate 2000000 lane count 4
[17:54:06] [PASSED] Link rate 2000000 lane count 2
[17:54:06] [PASSED] Link rate 2000000 lane count 1
[17:54:06] [PASSED] Link rate 1350000 lane count 4
[17:54:06] [PASSED] Link rate 1350000 lane count 2
[17:54:06] [PASSED] Link rate 1350000 lane count 1
[17:54:06] [PASSED] Link rate 1000000 lane count 4
[17:54:06] [PASSED] Link rate 1000000 lane count 2
[17:54:06] [PASSED] Link rate 1000000 lane count 1
[17:54:06] [PASSED] Link rate 810000 lane count 4
[17:54:06] [PASSED] Link rate 810000 lane count 2
[17:54:06] [PASSED] Link rate 810000 lane count 1
[17:54:06] [PASSED] Link rate 540000 lane count 4
[17:54:06] [PASSED] Link rate 540000 lane count 2
[17:54:06] [PASSED] Link rate 540000 lane count 1
[17:54:06] [PASSED] Link rate 270000 lane count 4
[17:54:06] [PASSED] Link rate 270000 lane count 2
[17:54:06] [PASSED] Link rate 270000 lane count 1
[17:54:06] [PASSED] Link rate 162000 lane count 4
[17:54:06] [PASSED] Link rate 162000 lane count 2
[17:54:06] [PASSED] Link rate 162000 lane count 1
[17:54:06] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[17:54:06] ========= drm_test_dp_mst_sideband_msg_req_decode =========
[17:54:06] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[17:54:06] [PASSED] DP_POWER_UP_PHY with port number
[17:54:06] [PASSED] DP_POWER_DOWN_PHY with port number
[17:54:06] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[17:54:06] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[17:54:06] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[17:54:06] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[17:54:06] [PASSED] DP_QUERY_PAYLOAD with port number
[17:54:06] [PASSED] DP_QUERY_PAYLOAD with VCPI
[17:54:06] [PASSED] DP_REMOTE_DPCD_READ with port number
[17:54:06] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[17:54:06] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[17:54:06] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[17:54:06] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[17:54:06] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[17:54:06] [PASSED] DP_REMOTE_I2C_READ with port number
[17:54:06] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[17:54:06] [PASSED] DP_REMOTE_I2C_READ with transactions array
[17:54:06] [PASSED] DP_REMOTE_I2C_WRITE with port number
[17:54:06] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[17:54:06] [PASSED] DP_REMOTE_I2C_WRITE with data array
[17:54:06] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[17:54:06] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[17:54:06] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[17:54:06] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[17:54:06] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[17:54:06] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[17:54:06] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[17:54:06] ================ [PASSED] drm_dp_mst_helper ================
[17:54:06] ================== drm_exec (7 subtests) ===================
[17:54:06] [PASSED] sanitycheck
[17:54:06] [PASSED] test_lock
[17:54:06] [PASSED] test_lock_unlock
[17:54:06] [PASSED] test_duplicates
[17:54:06] [PASSED] test_prepare
[17:54:06] [PASSED] test_prepare_array
[17:54:06] [PASSED] test_multiple_loops
[17:54:06] ==================== [PASSED] drm_exec =====================
[17:54:06] =========== drm_format_helper_test (17 subtests) ===========
[17:54:06] ============== drm_test_fb_xrgb8888_to_gray8 ==============
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[17:54:06] ============= drm_test_fb_xrgb8888_to_rgb332 ==============
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[17:54:06] ============= drm_test_fb_xrgb8888_to_rgb565 ==============
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[17:54:06] ============ drm_test_fb_xrgb8888_to_xrgb1555 =============
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[17:54:06] ============ drm_test_fb_xrgb8888_to_argb1555 =============
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[17:54:06] ============ drm_test_fb_xrgb8888_to_rgba5551 =============
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[17:54:06] ============= drm_test_fb_xrgb8888_to_rgb888 ==============
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[17:54:06] ============= drm_test_fb_xrgb8888_to_bgr888 ==============
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[17:54:06] ============ drm_test_fb_xrgb8888_to_argb8888 =============
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[17:54:06] =========== drm_test_fb_xrgb8888_to_xrgb2101010 ===========
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[17:54:06] =========== drm_test_fb_xrgb8888_to_argb2101010 ===========
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[17:54:06] ============== drm_test_fb_xrgb8888_to_mono ===============
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[17:54:06] ==================== drm_test_fb_swab =====================
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ================ [PASSED] drm_test_fb_swab =================
[17:54:06] ============ drm_test_fb_xrgb8888_to_xbgr8888 =============
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[17:54:06] ============ drm_test_fb_xrgb8888_to_abgr8888 =============
[17:54:06] [PASSED] single_pixel_source_buffer
[17:54:06] [PASSED] single_pixel_clip_rectangle
[17:54:06] [PASSED] well_known_colors
[17:54:06] [PASSED] destination_pitch
[17:54:06] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[17:54:06] ================= drm_test_fb_clip_offset =================
[17:54:06] [PASSED] pass through
[17:54:06] [PASSED] horizontal offset
[17:54:06] [PASSED] vertical offset
[17:54:06] [PASSED] horizontal and vertical offset
[17:54:06] [PASSED] horizontal offset (custom pitch)
[17:54:06] [PASSED] vertical offset (custom pitch)
[17:54:06] [PASSED] horizontal and vertical offset (custom pitch)
[17:54:06] ============= [PASSED] drm_test_fb_clip_offset =============
[17:54:06] =================== drm_test_fb_memcpy ====================
[17:54:06] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[17:54:06] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[17:54:06] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[17:54:06] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[17:54:06] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[17:54:06] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[17:54:06] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[17:54:06] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[17:54:06] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[17:54:06] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[17:54:06] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[17:54:06] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[17:54:06] =============== [PASSED] drm_test_fb_memcpy ================
[17:54:06] ============= [PASSED] drm_format_helper_test ==============
[17:54:06] ================= drm_format (18 subtests) =================
[17:54:06] [PASSED] drm_test_format_block_width_invalid
[17:54:06] [PASSED] drm_test_format_block_width_one_plane
[17:54:06] [PASSED] drm_test_format_block_width_two_plane
[17:54:06] [PASSED] drm_test_format_block_width_three_plane
[17:54:06] [PASSED] drm_test_format_block_width_tiled
[17:54:06] [PASSED] drm_test_format_block_height_invalid
[17:54:06] [PASSED] drm_test_format_block_height_one_plane
[17:54:06] [PASSED] drm_test_format_block_height_two_plane
[17:54:06] [PASSED] drm_test_format_block_height_three_plane
[17:54:06] [PASSED] drm_test_format_block_height_tiled
[17:54:06] [PASSED] drm_test_format_min_pitch_invalid
[17:54:06] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[17:54:06] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[17:54:06] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[17:54:06] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[17:54:06] [PASSED] drm_test_format_min_pitch_two_plane
[17:54:06] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[17:54:06] [PASSED] drm_test_format_min_pitch_tiled
[17:54:06] =================== [PASSED] drm_format ====================
[17:54:06] ============== drm_framebuffer (10 subtests) ===============
[17:54:06] ========== drm_test_framebuffer_check_src_coords ==========
[17:54:06] [PASSED] Success: source fits into fb
[17:54:06] [PASSED] Fail: overflowing fb with x-axis coordinate
[17:54:06] [PASSED] Fail: overflowing fb with y-axis coordinate
[17:54:06] [PASSED] Fail: overflowing fb with source width
[17:54:06] [PASSED] Fail: overflowing fb with source height
[17:54:06] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[17:54:06] [PASSED] drm_test_framebuffer_cleanup
[17:54:06] =============== drm_test_framebuffer_create ===============
[17:54:06] [PASSED] ABGR8888 normal sizes
[17:54:06] [PASSED] ABGR8888 max sizes
[17:54:06] [PASSED] ABGR8888 pitch greater than min required
[17:54:06] [PASSED] ABGR8888 pitch less than min required
[17:54:06] [PASSED] ABGR8888 Invalid width
[17:54:06] [PASSED] ABGR8888 Invalid buffer handle
[17:54:06] [PASSED] No pixel format
[17:54:06] [PASSED] ABGR8888 Width 0
[17:54:06] [PASSED] ABGR8888 Height 0
[17:54:06] [PASSED] ABGR8888 Out of bound height * pitch combination
[17:54:06] [PASSED] ABGR8888 Large buffer offset
[17:54:06] [PASSED] ABGR8888 Buffer offset for inexistent plane
[17:54:06] [PASSED] ABGR8888 Invalid flag
[17:54:06] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[17:54:06] [PASSED] ABGR8888 Valid buffer modifier
[17:54:06] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[17:54:06] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[17:54:06] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[17:54:06] [PASSED] NV12 Normal sizes
[17:54:06] [PASSED] NV12 Max sizes
[17:54:06] [PASSED] NV12 Invalid pitch
[17:54:06] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[17:54:06] [PASSED] NV12 different modifier per-plane
[17:54:06] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[17:54:06] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[17:54:06] [PASSED] NV12 Modifier for inexistent plane
[17:54:06] [PASSED] NV12 Handle for inexistent plane
[17:54:06] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[17:54:06] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[17:54:06] [PASSED] YVU420 Normal sizes
[17:54:06] [PASSED] YVU420 Max sizes
[17:54:06] [PASSED] YVU420 Invalid pitch
[17:54:06] [PASSED] YVU420 Different pitches
[17:54:06] [PASSED] YVU420 Different buffer offsets/pitches
[17:54:06] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[17:54:06] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[17:54:06] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[17:54:06] [PASSED] YVU420 Valid modifier
[17:54:06] [PASSED] YVU420 Different modifiers per plane
[17:54:06] [PASSED] YVU420 Modifier for inexistent plane
[17:54:06] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[17:54:06] [PASSED] X0L2 Normal sizes
[17:54:06] [PASSED] X0L2 Max sizes
[17:54:06] [PASSED] X0L2 Invalid pitch
[17:54:06] [PASSED] X0L2 Pitch greater than minimum required
[17:54:06] [PASSED] X0L2 Handle for inexistent plane
[17:54:06] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[17:54:06] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[17:54:06] [PASSED] X0L2 Valid modifier
[17:54:06] [PASSED] X0L2 Modifier for inexistent plane
[17:54:06] =========== [PASSED] drm_test_framebuffer_create ===========
[17:54:06] [PASSED] drm_test_framebuffer_free
[17:54:06] [PASSED] drm_test_framebuffer_init
[17:54:06] [PASSED] drm_test_framebuffer_init_bad_format
[17:54:06] [PASSED] drm_test_framebuffer_init_dev_mismatch
[17:54:06] [PASSED] drm_test_framebuffer_lookup
[17:54:06] [PASSED] drm_test_framebuffer_lookup_inexistent
[17:54:06] [PASSED] drm_test_framebuffer_modifiers_not_supported
[17:54:06] ================= [PASSED] drm_framebuffer =================
[17:54:06] ================ drm_gem_shmem (8 subtests) ================
[17:54:06] [PASSED] drm_gem_shmem_test_obj_create
[17:54:06] [PASSED] drm_gem_shmem_test_obj_create_private
[17:54:06] [PASSED] drm_gem_shmem_test_pin_pages
[17:54:06] [PASSED] drm_gem_shmem_test_vmap
[17:54:06] [PASSED] drm_gem_shmem_test_get_pages_sgt
[17:54:06] [PASSED] drm_gem_shmem_test_get_sg_table
[17:54:06] [PASSED] drm_gem_shmem_test_madvise
[17:54:06] [PASSED] drm_gem_shmem_test_purge
[17:54:06] ================== [PASSED] drm_gem_shmem ==================
[17:54:06] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[17:54:06] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[17:54:06] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[17:54:06] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[17:54:06] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[17:54:06] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[17:54:06] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[17:54:06] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 =======
[17:54:06] [PASSED] Automatic
[17:54:06] [PASSED] Full
[17:54:06] [PASSED] Limited 16:235
[17:54:06] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[17:54:06] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[17:54:06] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[17:54:06] [PASSED] drm_test_check_disable_connector
[17:54:06] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[17:54:06] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[17:54:06] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[17:54:06] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[17:54:06] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[17:54:06] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[17:54:06] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[17:54:06] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[17:54:06] [PASSED] drm_test_check_output_bpc_dvi
[17:54:06] [PASSED] drm_test_check_output_bpc_format_vic_1
[17:54:06] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[17:54:06] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[17:54:06] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[17:54:06] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[17:54:06] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[17:54:06] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[17:54:06] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[17:54:06] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[17:54:06] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[17:54:06] [PASSED] drm_test_check_broadcast_rgb_value
[17:54:06] [PASSED] drm_test_check_bpc_8_value
[17:54:06] [PASSED] drm_test_check_bpc_10_value
[17:54:06] [PASSED] drm_test_check_bpc_12_value
[17:54:06] [PASSED] drm_test_check_format_value
[17:54:06] [PASSED] drm_test_check_tmds_char_value
[17:54:06] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[17:54:06] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[17:54:06] [PASSED] drm_test_check_mode_valid
[17:54:06] [PASSED] drm_test_check_mode_valid_reject
[17:54:06] [PASSED] drm_test_check_mode_valid_reject_rate
[17:54:06] [PASSED] drm_test_check_mode_valid_reject_max_clock
[17:54:06] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[17:54:06] ================= drm_managed (2 subtests) =================
[17:54:06] [PASSED] drm_test_managed_release_action
[17:54:06] [PASSED] drm_test_managed_run_action
[17:54:06] =================== [PASSED] drm_managed ===================
[17:54:06] =================== drm_mm (6 subtests) ====================
[17:54:06] [PASSED] drm_test_mm_init
[17:54:06] [PASSED] drm_test_mm_debug
[17:54:06] [PASSED] drm_test_mm_align32
[17:54:06] [PASSED] drm_test_mm_align64
[17:54:06] [PASSED] drm_test_mm_lowest
[17:54:06] [PASSED] drm_test_mm_highest
[17:54:06] ===================== [PASSED] drm_mm ======================
[17:54:06] ============= drm_modes_analog_tv (5 subtests) =============
[17:54:06] [PASSED] drm_test_modes_analog_tv_mono_576i
[17:54:06] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[17:54:06] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[17:54:06] [PASSED] drm_test_modes_analog_tv_pal_576i
[17:54:06] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[17:54:06] =============== [PASSED] drm_modes_analog_tv ===============
[17:54:06] ============== drm_plane_helper (2 subtests) ===============
[17:54:06] =============== drm_test_check_plane_state ================
[17:54:06] [PASSED] clipping_simple
[17:54:06] [PASSED] clipping_rotate_reflect
[17:54:06] [PASSED] positioning_simple
[17:54:06] [PASSED] upscaling
[17:54:06] [PASSED] downscaling
[17:54:06] [PASSED] rounding1
[17:54:06] [PASSED] rounding2
[17:54:06] [PASSED] rounding3
[17:54:06] [PASSED] rounding4
[17:54:06] =========== [PASSED] drm_test_check_plane_state ============
[17:54:06] =========== drm_test_check_invalid_plane_state ============
[17:54:06] [PASSED] positioning_invalid
[17:54:06] [PASSED] upscaling_invalid
[17:54:06] [PASSED] downscaling_invalid
[17:54:06] ======= [PASSED] drm_test_check_invalid_plane_state ========
[17:54:06] ================ [PASSED] drm_plane_helper =================
[17:54:06] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[17:54:06] ====== drm_test_connector_helper_tv_get_modes_check =======
[17:54:06] [PASSED] None
[17:54:06] [PASSED] PAL
[17:54:06] [PASSED] NTSC
[17:54:06] [PASSED] Both, NTSC Default
[17:54:06] [PASSED] Both, PAL Default
[17:54:06] [PASSED] Both, NTSC Default, with PAL on command-line
[17:54:06] [PASSED] Both, PAL Default, with NTSC on command-line
[17:54:06] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[17:54:06] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[17:54:06] ================== drm_rect (9 subtests) ===================
[17:54:06] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[17:54:06] [PASSED] drm_test_rect_clip_scaled_not_clipped
[17:54:06] [PASSED] drm_test_rect_clip_scaled_clipped
[17:54:06] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[17:54:06] ================= drm_test_rect_intersect =================
[17:54:06] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[17:54:06] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[17:54:06] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[17:54:06] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[17:54:06] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[17:54:06] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[17:54:06] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[17:54:06] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[17:54:06] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[17:54:06] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[17:54:06] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[17:54:06] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[17:54:06] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[17:54:06] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[17:54:06] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[17:54:06] ============= [PASSED] drm_test_rect_intersect =============
[17:54:06] ================ drm_test_rect_calc_hscale ================
[17:54:06] [PASSED] normal use
[17:54:06] [PASSED] out of max range
[17:54:06] [PASSED] out of min range
[17:54:06] [PASSED] zero dst
[17:54:06] [PASSED] negative src
[17:54:06] [PASSED] negative dst
[17:54:06] ============ [PASSED] drm_test_rect_calc_hscale ============
[17:54:06] ================ drm_test_rect_calc_vscale ================
[17:54:06] [PASSED] normal use
[17:54:06] [PASSED] out of max range
[17:54:06] [PASSED] out of min range
[17:54:06] [PASSED] zero dst
[17:54:06] [PASSED] negative src
[17:54:06] [PASSED] negative dst
[17:54:06] ============ [PASSED] drm_test_rect_calc_vscale ============
[17:54:06] ================== drm_test_rect_rotate ===================
[17:54:06] [PASSED] reflect-x
[17:54:06] [PASSED] reflect-y
[17:54:06] [PASSED] rotate-0
[17:54:06] [PASSED] rotate-90
[17:54:06] [PASSED] rotate-180
[17:54:06] [PASSED] rotate-270
stty: 'standard input': Inappropriate ioctl for device
[17:54:06] ============== [PASSED] drm_test_rect_rotate ===============
[17:54:06] ================ drm_test_rect_rotate_inv =================
[17:54:06] [PASSED] reflect-x
[17:54:06] [PASSED] reflect-y
[17:54:06] [PASSED] rotate-0
[17:54:06] [PASSED] rotate-90
[17:54:06] [PASSED] rotate-180
[17:54:06] [PASSED] rotate-270
[17:54:06] ============ [PASSED] drm_test_rect_rotate_inv =============
[17:54:06] ==================== [PASSED] drm_rect =====================
[17:54:06] ============ drm_sysfb_modeset_test (1 subtest) ============
[17:54:06] ============ drm_test_sysfb_build_fourcc_list =============
[17:54:06] [PASSED] no native formats
[17:54:06] [PASSED] XRGB8888 as native format
[17:54:06] [PASSED] remove duplicates
[17:54:06] [PASSED] convert alpha formats
[17:54:06] [PASSED] random formats
[17:54:06] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[17:54:06] ============= [PASSED] drm_sysfb_modeset_test ==============
[17:54:06] ============================================================
[17:54:06] Testing complete. Ran 616 tests: passed: 616
[17:54:06] Elapsed time: 23.633s total, 1.623s configuring, 21.840s building, 0.132s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
[17:54:06] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[17:54:08] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[17:54:16] Starting KUnit Kernel (1/1)...
[17:54:16] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[17:54:16] ================= ttm_device (5 subtests) ==================
[17:54:16] [PASSED] ttm_device_init_basic
[17:54:16] [PASSED] ttm_device_init_multiple
[17:54:16] [PASSED] ttm_device_fini_basic
[17:54:16] [PASSED] ttm_device_init_no_vma_man
[17:54:16] ================== ttm_device_init_pools ==================
[17:54:16] [PASSED] No DMA allocations, no DMA32 required
[17:54:16] [PASSED] DMA allocations, DMA32 required
[17:54:16] [PASSED] No DMA allocations, DMA32 required
[17:54:16] [PASSED] DMA allocations, no DMA32 required
[17:54:16] ============== [PASSED] ttm_device_init_pools ==============
[17:54:16] =================== [PASSED] ttm_device ====================
[17:54:16] ================== ttm_pool (8 subtests) ===================
[17:54:16] ================== ttm_pool_alloc_basic ===================
[17:54:16] [PASSED] One page
[17:54:16] [PASSED] More than one page
[17:54:16] [PASSED] Above the allocation limit
[17:54:16] [PASSED] One page, with coherent DMA mappings enabled
[17:54:16] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[17:54:16] ============== [PASSED] ttm_pool_alloc_basic ===============
[17:54:16] ============== ttm_pool_alloc_basic_dma_addr ==============
[17:54:16] [PASSED] One page
[17:54:16] [PASSED] More than one page
[17:54:16] [PASSED] Above the allocation limit
[17:54:16] [PASSED] One page, with coherent DMA mappings enabled
[17:54:16] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[17:54:16] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[17:54:16] [PASSED] ttm_pool_alloc_order_caching_match
[17:54:16] [PASSED] ttm_pool_alloc_caching_mismatch
[17:54:16] [PASSED] ttm_pool_alloc_order_mismatch
[17:54:16] [PASSED] ttm_pool_free_dma_alloc
[17:54:16] [PASSED] ttm_pool_free_no_dma_alloc
[17:54:16] [PASSED] ttm_pool_fini_basic
[17:54:16] ==================== [PASSED] ttm_pool =====================
[17:54:16] ================ ttm_resource (8 subtests) =================
[17:54:16] ================= ttm_resource_init_basic =================
[17:54:16] [PASSED] Init resource in TTM_PL_SYSTEM
[17:54:16] [PASSED] Init resource in TTM_PL_VRAM
[17:54:16] [PASSED] Init resource in a private placement
[17:54:16] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[17:54:16] ============= [PASSED] ttm_resource_init_basic =============
[17:54:16] [PASSED] ttm_resource_init_pinned
[17:54:16] [PASSED] ttm_resource_fini_basic
[17:54:16] [PASSED] ttm_resource_manager_init_basic
[17:54:16] [PASSED] ttm_resource_manager_usage_basic
[17:54:16] [PASSED] ttm_resource_manager_set_used_basic
[17:54:16] [PASSED] ttm_sys_man_alloc_basic
[17:54:16] [PASSED] ttm_sys_man_free_basic
[17:54:16] ================== [PASSED] ttm_resource ===================
[17:54:16] =================== ttm_tt (15 subtests) ===================
[17:54:16] ==================== ttm_tt_init_basic ====================
[17:54:16] [PASSED] Page-aligned size
[17:54:16] [PASSED] Extra pages requested
[17:54:16] ================ [PASSED] ttm_tt_init_basic ================
[17:54:16] [PASSED] ttm_tt_init_misaligned
[17:54:16] [PASSED] ttm_tt_fini_basic
[17:54:16] [PASSED] ttm_tt_fini_sg
[17:54:16] [PASSED] ttm_tt_fini_shmem
[17:54:16] [PASSED] ttm_tt_create_basic
[17:54:16] [PASSED] ttm_tt_create_invalid_bo_type
[17:54:16] [PASSED] ttm_tt_create_ttm_exists
[17:54:16] [PASSED] ttm_tt_create_failed
[17:54:16] [PASSED] ttm_tt_destroy_basic
[17:54:16] [PASSED] ttm_tt_populate_null_ttm
[17:54:16] [PASSED] ttm_tt_populate_populated_ttm
[17:54:16] [PASSED] ttm_tt_unpopulate_basic
[17:54:16] [PASSED] ttm_tt_unpopulate_empty_ttm
[17:54:16] [PASSED] ttm_tt_swapin_basic
[17:54:16] ===================== [PASSED] ttm_tt ======================
[17:54:16] =================== ttm_bo (14 subtests) ===================
[17:54:16] =========== ttm_bo_reserve_optimistic_no_ticket ===========
[17:54:16] [PASSED] Cannot be interrupted and sleeps
[17:54:16] [PASSED] Cannot be interrupted, locks straight away
[17:54:16] [PASSED] Can be interrupted, sleeps
[17:54:16] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[17:54:16] [PASSED] ttm_bo_reserve_locked_no_sleep
[17:54:16] [PASSED] ttm_bo_reserve_no_wait_ticket
[17:54:16] [PASSED] ttm_bo_reserve_double_resv
[17:54:16] [PASSED] ttm_bo_reserve_interrupted
[17:54:16] [PASSED] ttm_bo_reserve_deadlock
[17:54:16] [PASSED] ttm_bo_unreserve_basic
[17:54:16] [PASSED] ttm_bo_unreserve_pinned
[17:54:16] [PASSED] ttm_bo_unreserve_bulk
[17:54:16] [PASSED] ttm_bo_put_basic
[17:54:16] [PASSED] ttm_bo_put_shared_resv
[17:54:16] [PASSED] ttm_bo_pin_basic
[17:54:16] [PASSED] ttm_bo_pin_unpin_resource
[17:54:16] [PASSED] ttm_bo_multiple_pin_one_unpin
[17:54:16] ===================== [PASSED] ttm_bo ======================
[17:54:16] ============== ttm_bo_validate (21 subtests) ===============
[17:54:16] ============== ttm_bo_init_reserved_sys_man ===============
[17:54:16] [PASSED] Buffer object for userspace
[17:54:16] [PASSED] Kernel buffer object
[17:54:16] [PASSED] Shared buffer object
[17:54:16] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[17:54:16] ============== ttm_bo_init_reserved_mock_man ==============
[17:54:16] [PASSED] Buffer object for userspace
[17:54:16] [PASSED] Kernel buffer object
[17:54:16] [PASSED] Shared buffer object
[17:54:16] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[17:54:16] [PASSED] ttm_bo_init_reserved_resv
[17:54:16] ================== ttm_bo_validate_basic ==================
[17:54:16] [PASSED] Buffer object for userspace
[17:54:16] [PASSED] Kernel buffer object
[17:54:16] [PASSED] Shared buffer object
[17:54:16] ============== [PASSED] ttm_bo_validate_basic ==============
[17:54:16] [PASSED] ttm_bo_validate_invalid_placement
[17:54:16] ============= ttm_bo_validate_same_placement ==============
[17:54:16] [PASSED] System manager
[17:54:16] [PASSED] VRAM manager
[17:54:16] ========= [PASSED] ttm_bo_validate_same_placement ==========
[17:54:16] [PASSED] ttm_bo_validate_failed_alloc
[17:54:16] [PASSED] ttm_bo_validate_pinned
[17:54:16] [PASSED] ttm_bo_validate_busy_placement
[17:54:16] ================ ttm_bo_validate_multihop =================
[17:54:16] [PASSED] Buffer object for userspace
[17:54:16] [PASSED] Kernel buffer object
[17:54:16] [PASSED] Shared buffer object
[17:54:16] ============ [PASSED] ttm_bo_validate_multihop =============
[17:54:16] ========== ttm_bo_validate_no_placement_signaled ==========
[17:54:16] [PASSED] Buffer object in system domain, no page vector
[17:54:16] [PASSED] Buffer object in system domain with an existing page vector
[17:54:16] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[17:54:16] ======== ttm_bo_validate_no_placement_not_signaled ========
[17:54:16] [PASSED] Buffer object for userspace
[17:54:16] [PASSED] Kernel buffer object
[17:54:16] [PASSED] Shared buffer object
[17:54:16] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[17:54:16] [PASSED] ttm_bo_validate_move_fence_signaled
[17:54:16] ========= ttm_bo_validate_move_fence_not_signaled =========
[17:54:16] [PASSED] Waits for GPU
[17:54:16] [PASSED] Tries to lock straight away
[17:54:16] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[17:54:16] [PASSED] ttm_bo_validate_happy_evict
[17:54:16] [PASSED] ttm_bo_validate_all_pinned_evict
[17:54:16] [PASSED] ttm_bo_validate_allowed_only_evict
[17:54:16] [PASSED] ttm_bo_validate_deleted_evict
[17:54:16] [PASSED] ttm_bo_validate_busy_domain_evict
[17:54:16] [PASSED] ttm_bo_validate_evict_gutting
[17:54:16] [PASSED] ttm_bo_validate_recrusive_evict
stty: 'standard input': Inappropriate ioctl for device
[17:54:16] ================= [PASSED] ttm_bo_validate =================
[17:54:16] ============================================================
[17:54:16] Testing complete. Ran 101 tests: passed: 101
[17:54:16] Elapsed time: 9.647s total, 1.650s configuring, 7.781s building, 0.182s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* ✓ Xe.CI.BAT: success for devcoredump: Fix circular locking dependency with devcd->mutex. (rev3)
2025-07-23 14:24 [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex Maarten Lankhorst
2025-07-23 17:53 ` ✗ CI.checkpatch: warning for devcoredump: Fix circular locking dependency with devcd->mutex. (rev3) Patchwork
2025-07-23 17:54 ` ✓ CI.KUnit: success " Patchwork
@ 2025-07-23 19:20 ` Patchwork
2025-07-24 2:54 ` ✗ Xe.CI.Full: failure " Patchwork
` (3 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2025-07-23 19:20 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-xe
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
== Series Details ==
Series: devcoredump: Fix circular locking dependency with devcd->mutex. (rev3)
URL : https://patchwork.freedesktop.org/series/151901/
State : success
== Summary ==
CI Bug Log - changes from xe-3466-22160d1b26a745a0a939dbc792485a2404aea536_BAT -> xe-pw-151901v3_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (9 -> 8)
------------------------------
Missing (1): bat-adlp-vm
Changes
-------
No changes found
Build changes
-------------
* Linux: xe-3466-22160d1b26a745a0a939dbc792485a2404aea536 -> xe-pw-151901v3
IGT_8475: 1ddc997191d8aa008b49b5a4c47cf295c9a3c4f4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-3466-22160d1b26a745a0a939dbc792485a2404aea536: 22160d1b26a745a0a939dbc792485a2404aea536
xe-pw-151901v3: 151901v3
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/index.html
[-- Attachment #2: Type: text/html, Size: 1528 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* ✗ Xe.CI.Full: failure for devcoredump: Fix circular locking dependency with devcd->mutex. (rev3)
2025-07-23 14:24 [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex Maarten Lankhorst
` (2 preceding siblings ...)
2025-07-23 19:20 ` ✓ Xe.CI.BAT: " Patchwork
@ 2025-07-24 2:54 ` Patchwork
2025-10-03 13:29 ` [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex Maarten Lankhorst
` (2 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2025-07-24 2:54 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-xe
[-- Attachment #1: Type: text/plain, Size: 47707 bytes --]
== Series Details ==
Series: devcoredump: Fix circular locking dependency with devcd->mutex. (rev3)
URL : https://patchwork.freedesktop.org/series/151901/
State : failure
== Summary ==
CI Bug Log - changes from xe-3466-22160d1b26a745a0a939dbc792485a2404aea536_FULL -> xe-pw-151901v3_FULL
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with xe-pw-151901v3_FULL absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in xe-pw-151901v3_FULL, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in xe-pw-151901v3_FULL:
### IGT changes ###
#### Possible regressions ####
* igt@xe_exec_system_allocator@threads-many-stride-malloc-bo-unmap:
- shard-bmg: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-8/igt@xe_exec_system_allocator@threads-many-stride-malloc-bo-unmap.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-5/igt@xe_exec_system_allocator@threads-many-stride-malloc-bo-unmap.html
New tests
---------
New tests have been introduced between xe-3466-22160d1b26a745a0a939dbc792485a2404aea536_FULL and xe-pw-151901v3_FULL:
### New IGT tests (29) ###
* igt@kms_flip@absolute-wf_vblank-interruptible@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.64] s
* igt@kms_flip@absolute-wf_vblank@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.65] s
* igt@kms_flip@basic-flip-vs-dpms@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.64] s
* igt@kms_flip@basic-flip-vs-wf_vblank@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.94] s
* igt@kms_flip@basic-plain-flip@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.65] s
* igt@kms_flip@blocking-wf_vblank@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.93] s
* igt@kms_flip@bo-too-big@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.17] s
* igt@kms_flip@busy-flip@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.66] s
* igt@kms_flip@dpms-off-confusion-interruptible@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.61] s
* igt@kms_flip@dpms-off-confusion@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.65] s
* igt@kms_flip@dpms-vs-vblank-race-interruptible@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [2.90] s
* igt@kms_flip@dpms-vs-vblank-race@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [2.98] s
* igt@kms_flip@flip-vs-absolute-wf_vblank@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.94] s
* igt@kms_flip@flip-vs-blocking-wf-vblank@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [8.11] s
* igt@kms_flip@flip-vs-dpms-off-vs-modeset-interruptible@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.64] s
* igt@kms_flip@flip-vs-dpms-off-vs-modeset@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.63] s
* igt@kms_flip@flip-vs-expired-vblank@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.65] s
* igt@kms_flip@flip-vs-panning-vs-hang@d-hdmi-a1:
- Statuses : 1 dmesg-warn(s)
- Exec time: [0.66] s
* igt@kms_flip@flip-vs-panning@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.65] s
* igt@kms_flip@flip-vs-rmfb-interruptible@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.62] s
* igt@kms_flip@flip-vs-rmfb@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.63] s
* igt@kms_flip@flip-vs-wf_vblank-interruptible@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.90] s
* igt@kms_flip@modeset-vs-vblank-race-interruptible@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [2.98] s
* igt@kms_flip@nonexisting-fb-interruptible@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.12] s
* igt@kms_flip@nonexisting-fb@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.13] s
* igt@kms_flip@plain-flip-fb-recreate@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.93] s
* igt@kms_flip@plain-flip-ts-check@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.92] s
* igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.65] s
* igt@kms_flip@wf_vblank-ts-check-interruptible@d-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [7.92] s
Known issues
------------
Here are the changes found in xe-pw-151901v3_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_addfb_basic@addfb25-bad-modifier:
- shard-adlp: [PASS][3] -> [DMESG-WARN][4] ([Intel XE#2953] / [Intel XE#4173]) +7 other tests dmesg-warn
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-adlp-1/igt@kms_addfb_basic@addfb25-bad-modifier.html
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-2/igt@kms_addfb_basic@addfb25-bad-modifier.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-adlp: NOTRUN -> [SKIP][5] ([Intel XE#1124]) +2 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-adlp: [PASS][6] -> [DMESG-FAIL][7] ([Intel XE#4543])
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-adlp-4/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-90:
- shard-adlp: NOTRUN -> [SKIP][8] ([Intel XE#316])
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
* igt@kms_big_fb@yf-tiled-addfb:
- shard-dg2-set2: NOTRUN -> [SKIP][9] ([Intel XE#619])
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-466/igt@kms_big_fb@yf-tiled-addfb.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180:
- shard-bmg: NOTRUN -> [SKIP][10] ([Intel XE#1124]) +2 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-lnl: NOTRUN -> [SKIP][11] ([Intel XE#1124])
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-lnl-2/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-dg2-set2: NOTRUN -> [SKIP][12] ([Intel XE#1124]) +2 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-435/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_bw@connected-linear-tiling-2-displays-1920x1080p:
- shard-bmg: [PASS][13] -> [SKIP][14] ([Intel XE#2314] / [Intel XE#2894])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-8/igt@kms_bw@connected-linear-tiling-2-displays-1920x1080p.html
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-6/igt@kms_bw@connected-linear-tiling-2-displays-1920x1080p.html
* igt@kms_bw@connected-linear-tiling-3-displays-2160x1440p:
- shard-adlp: NOTRUN -> [SKIP][15] ([Intel XE#2191])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_bw@connected-linear-tiling-3-displays-2160x1440p.html
* igt@kms_bw@connected-linear-tiling-3-displays-3840x2160p:
- shard-dg2-set2: NOTRUN -> [SKIP][16] ([Intel XE#2191])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-435/igt@kms_bw@connected-linear-tiling-3-displays-3840x2160p.html
* igt@kms_bw@linear-tiling-1-displays-2560x1440p:
- shard-dg2-set2: NOTRUN -> [SKIP][17] ([Intel XE#367])
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-435/igt@kms_bw@linear-tiling-1-displays-2560x1440p.html
* igt@kms_bw@linear-tiling-2-displays-2160x1440p:
- shard-adlp: NOTRUN -> [SKIP][18] ([Intel XE#367])
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_bw@linear-tiling-2-displays-2160x1440p.html
* igt@kms_ccs@crc-primary-basic-4-tiled-mtl-rc-ccs-cc@pipe-d-dp-2:
- shard-dg2-set2: NOTRUN -> [SKIP][19] ([Intel XE#455] / [Intel XE#787]) +24 other tests skip
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-432/igt@kms_ccs@crc-primary-basic-4-tiled-mtl-rc-ccs-cc@pipe-d-dp-2.html
* igt@kms_ccs@crc-primary-basic-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-6:
- shard-dg2-set2: NOTRUN -> [SKIP][20] ([Intel XE#787]) +160 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-463/igt@kms_ccs@crc-primary-basic-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-6.html
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs@pipe-b-edp-1:
- shard-lnl: NOTRUN -> [SKIP][21] ([Intel XE#2669]) +3 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-lnl-2/igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs@pipe-b-edp-1.html
* igt@kms_ccs@crc-primary-rotation-180-y-tiled-gen12-mc-ccs:
- shard-lnl: NOTRUN -> [SKIP][22] ([Intel XE#2887]) +1 other test skip
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-lnl-2/igt@kms_ccs@crc-primary-rotation-180-y-tiled-gen12-mc-ccs.html
* igt@kms_ccs@crc-primary-suspend-4-tiled-lnl-ccs@pipe-a-dp-2:
- shard-bmg: NOTRUN -> [SKIP][23] ([Intel XE#2652] / [Intel XE#787]) +3 other tests skip
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-1/igt@kms_ccs@crc-primary-suspend-4-tiled-lnl-ccs@pipe-a-dp-2.html
* igt@kms_ccs@crc-sprite-planes-basic-yf-tiled-ccs:
- shard-adlp: NOTRUN -> [SKIP][24] ([Intel XE#455] / [Intel XE#787]) +3 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_ccs@crc-sprite-planes-basic-yf-tiled-ccs.html
* igt@kms_ccs@crc-sprite-planes-basic-yf-tiled-ccs@pipe-a-hdmi-a-1:
- shard-adlp: NOTRUN -> [SKIP][25] ([Intel XE#787]) +5 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_ccs@crc-sprite-planes-basic-yf-tiled-ccs@pipe-a-hdmi-a-1.html
* igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs:
- shard-bmg: NOTRUN -> [SKIP][26] ([Intel XE#2887]) +1 other test skip
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs.html
* igt@kms_cdclk@plane-scaling@pipe-b-dp-2:
- shard-dg2-set2: NOTRUN -> [SKIP][27] ([Intel XE#4416]) +3 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-432/igt@kms_cdclk@plane-scaling@pipe-b-dp-2.html
* igt@kms_chamelium_audio@dp-audio-edid:
- shard-dg2-set2: NOTRUN -> [SKIP][28] ([Intel XE#373])
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-435/igt@kms_chamelium_audio@dp-audio-edid.html
* igt@kms_chamelium_frames@hdmi-cmp-planes-random:
- shard-bmg: NOTRUN -> [SKIP][29] ([Intel XE#2252])
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@kms_chamelium_frames@hdmi-cmp-planes-random.html
* igt@kms_content_protection@atomic-dpms@pipe-a-dp-4:
- shard-dg2-set2: NOTRUN -> [FAIL][30] ([Intel XE#1178]) +1 other test fail
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-463/igt@kms_content_protection@atomic-dpms@pipe-a-dp-4.html
* igt@kms_content_protection@srm@pipe-a-dp-2:
- shard-bmg: NOTRUN -> [FAIL][31] ([Intel XE#1178])
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-8/igt@kms_content_protection@srm@pipe-a-dp-2.html
* igt@kms_cursor_crc@cursor-onscreen-32x10:
- shard-bmg: NOTRUN -> [SKIP][32] ([Intel XE#2320])
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@kms_cursor_crc@cursor-onscreen-32x10.html
* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-adlp: NOTRUN -> [SKIP][33] ([Intel XE#308]) +1 other test skip
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_cursor_crc@cursor-sliding-512x512.html
* igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
- shard-bmg: [PASS][34] -> [SKIP][35] ([Intel XE#2291]) +3 other tests skip
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-2/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-6/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html
* igt@kms_dirtyfb@psr-dirtyfb-ioctl:
- shard-dg2-set2: NOTRUN -> [SKIP][36] ([Intel XE#455]) +1 other test skip
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-466/igt@kms_dirtyfb@psr-dirtyfb-ioctl.html
* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-adlp: NOTRUN -> [SKIP][37] ([Intel XE#310]) +1 other test skip
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_flip@2x-modeset-vs-vblank-race.html
* igt@kms_flip@2x-plain-flip-fb-recreate:
- shard-bmg: [PASS][38] -> [SKIP][39] ([Intel XE#2316]) +4 other tests skip
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-3/igt@kms_flip@2x-plain-flip-fb-recreate.html
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-6/igt@kms_flip@2x-plain-flip-fb-recreate.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-lnl: [PASS][40] -> [FAIL][41] ([Intel XE#301] / [Intel XE#3149])
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-lnl-6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-lnl-3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-lnl: [PASS][42] -> [FAIL][43] ([Intel XE#301]) +1 other test fail
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-lnl-6/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-lnl-3/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-downscaling:
- shard-adlp: NOTRUN -> [SKIP][44] ([Intel XE#455]) +2 other tests skip
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-downscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling:
- shard-bmg: NOTRUN -> [SKIP][45] ([Intel XE#2293] / [Intel XE#2380])
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling.html
- shard-lnl: NOTRUN -> [SKIP][46] ([Intel XE#1401] / [Intel XE#1745])
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-lnl-2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling@pipe-a-default-mode:
- shard-lnl: NOTRUN -> [SKIP][47] ([Intel XE#1401])
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-lnl-2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling@pipe-a-valid-mode:
- shard-bmg: NOTRUN -> [SKIP][48] ([Intel XE#2293])
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@drrs-1p-primscrn-cur-indfb-move:
- shard-adlp: NOTRUN -> [SKIP][49] ([Intel XE#651]) +1 other test skip
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_frontbuffer_tracking@drrs-1p-primscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@drrs-2p-primscrn-indfb-pgflip-blt:
- shard-dg2-set2: NOTRUN -> [SKIP][50] ([Intel XE#651]) +2 other tests skip
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-466/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-indfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-spr-indfb-move:
- shard-adlp: NOTRUN -> [SKIP][51] ([Intel XE#656]) +5 other tests skip
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-spr-indfb-move.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
- shard-bmg: NOTRUN -> [SKIP][52] ([Intel XE#5390]) +3 other tests skip
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff.html
- shard-lnl: NOTRUN -> [SKIP][53] ([Intel XE#656])
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-lnl-2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-bmg: NOTRUN -> [SKIP][54] ([Intel XE#2311]) +1 other test skip
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-pri-shrfb-draw-mmap-wc.html
- shard-lnl: NOTRUN -> [SKIP][55] ([Intel XE#651])
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-lnl-2/igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-bmg: NOTRUN -> [SKIP][56] ([Intel XE#2313]) +2 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-dg2-set2: NOTRUN -> [SKIP][57] ([Intel XE#653]) +7 other tests skip
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-435/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move:
- shard-adlp: NOTRUN -> [SKIP][58] ([Intel XE#653])
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move.html
* igt@kms_hdr@static-toggle:
- shard-bmg: [PASS][59] -> [SKIP][60] ([Intel XE#1503])
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-3/igt@kms_hdr@static-toggle.html
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-6/igt@kms_hdr@static-toggle.html
* igt@kms_plane_cursor@primary@pipe-a-hdmi-a-6-size-256:
- shard-dg2-set2: NOTRUN -> [FAIL][61] ([Intel XE#616]) +2 other tests fail
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-463/igt@kms_plane_cursor@primary@pipe-a-hdmi-a-6-size-256.html
* igt@kms_psr2_sf@fbc-psr2-primary-plane-update-sf-dmg-area:
- shard-dg2-set2: NOTRUN -> [SKIP][62] ([Intel XE#1489]) +3 other tests skip
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-435/igt@kms_psr2_sf@fbc-psr2-primary-plane-update-sf-dmg-area.html
* igt@kms_psr2_sf@pr-overlay-plane-update-continuous-sf:
- shard-adlp: NOTRUN -> [SKIP][63] ([Intel XE#1489])
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_psr2_sf@pr-overlay-plane-update-continuous-sf.html
* igt@kms_psr@fbc-pr-sprite-plane-onoff:
- shard-adlp: NOTRUN -> [SKIP][64] ([Intel XE#2850] / [Intel XE#929]) +1 other test skip
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_psr@fbc-pr-sprite-plane-onoff.html
* igt@kms_psr@fbc-psr-suspend:
- shard-bmg: NOTRUN -> [SKIP][65] ([Intel XE#2234] / [Intel XE#2850]) +1 other test skip
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@kms_psr@fbc-psr-suspend.html
* igt@kms_psr@psr-cursor-plane-move:
- shard-dg2-set2: NOTRUN -> [SKIP][66] ([Intel XE#2850] / [Intel XE#929]) +1 other test skip
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-466/igt@kms_psr@psr-cursor-plane-move.html
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-90:
- shard-dg2-set2: NOTRUN -> [SKIP][67] ([Intel XE#3414])
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-435/igt@kms_rotation_crc@primary-y-tiled-reflect-x-90.html
* igt@kms_setmode@basic-clone-single-crtc:
- shard-bmg: NOTRUN -> [SKIP][68] ([Intel XE#1435])
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@kms_setmode@basic-clone-single-crtc.html
* igt@kms_setmode@clone-exclusive-crtc:
- shard-bmg: [PASS][69] -> [SKIP][70] ([Intel XE#1435])
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-2/igt@kms_setmode@clone-exclusive-crtc.html
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-6/igt@kms_setmode@clone-exclusive-crtc.html
* igt@xe_eudebug@basic-vm-bind:
- shard-dg2-set2: NOTRUN -> [SKIP][71] ([Intel XE#4837]) +1 other test skip
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-435/igt@xe_eudebug@basic-vm-bind.html
* igt@xe_eudebug@basic-vm-bind-discovery:
- shard-adlp: NOTRUN -> [SKIP][72] ([Intel XE#4837] / [Intel XE#5565]) +1 other test skip
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@xe_eudebug@basic-vm-bind-discovery.html
* igt@xe_eudebug_online@pagefault-write:
- shard-bmg: NOTRUN -> [SKIP][73] ([Intel XE#4837])
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@xe_eudebug_online@pagefault-write.html
* igt@xe_exec_basic@multigpu-no-exec-null-defer-mmap:
- shard-dg2-set2: [PASS][74] -> [SKIP][75] ([Intel XE#1392]) +5 other tests skip
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-dg2-434/igt@xe_exec_basic@multigpu-no-exec-null-defer-mmap.html
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-432/igt@xe_exec_basic@multigpu-no-exec-null-defer-mmap.html
* igt@xe_exec_basic@multigpu-once-userptr:
- shard-bmg: NOTRUN -> [SKIP][76] ([Intel XE#2322]) +1 other test skip
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@xe_exec_basic@multigpu-once-userptr.html
* igt@xe_exec_basic@multigpu-once-userptr-rebind:
- shard-adlp: NOTRUN -> [SKIP][77] ([Intel XE#1392] / [Intel XE#5575])
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@xe_exec_basic@multigpu-once-userptr-rebind.html
* igt@xe_exec_fault_mode@many-basic-prefetch:
- shard-dg2-set2: NOTRUN -> [SKIP][78] ([Intel XE#288]) +5 other tests skip
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-435/igt@xe_exec_fault_mode@many-basic-prefetch.html
* igt@xe_exec_fault_mode@many-execqueues-bindexecqueue-userptr-prefetch:
- shard-adlp: NOTRUN -> [SKIP][79] ([Intel XE#288] / [Intel XE#5561]) +3 other tests skip
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@xe_exec_fault_mode@many-execqueues-bindexecqueue-userptr-prefetch.html
* igt@xe_exec_mix_modes@exec-spinner-interrupted-dma-fence:
- shard-dg2-set2: NOTRUN -> [SKIP][80] ([Intel XE#2360])
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-435/igt@xe_exec_mix_modes@exec-spinner-interrupted-dma-fence.html
* igt@xe_exec_system_allocator@many-large-malloc-race:
- shard-adlp: NOTRUN -> [SKIP][81] ([Intel XE#4915] / [Intel XE#5560]) +41 other tests skip
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@xe_exec_system_allocator@many-large-malloc-race.html
* igt@xe_exec_system_allocator@twice-mmap-remap-dontunmap:
- shard-dg2-set2: NOTRUN -> [SKIP][82] ([Intel XE#4915]) +52 other tests skip
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-466/igt@xe_exec_system_allocator@twice-mmap-remap-dontunmap.html
* igt@xe_oa@non-zero-reason:
- shard-dg2-set2: NOTRUN -> [SKIP][83] ([Intel XE#3573])
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-466/igt@xe_oa@non-zero-reason.html
* igt@xe_oa@rc6-disable:
- shard-adlp: NOTRUN -> [SKIP][84] ([Intel XE#3573]) +1 other test skip
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@xe_oa@rc6-disable.html
* igt@xe_peer2peer@read@read-gpua-vram01-gpub-system-p2p:
- shard-dg2-set2: NOTRUN -> [FAIL][85] ([Intel XE#1173])
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-463/igt@xe_peer2peer@read@read-gpua-vram01-gpub-system-p2p.html
* igt@xe_pm_residency@cpg-basic:
- shard-dg2-set2: [PASS][86] -> [INCOMPLETE][87] ([Intel XE#3088])
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-dg2-433/igt@xe_pm_residency@cpg-basic.html
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-466/igt@xe_pm_residency@cpg-basic.html
* igt@xe_query@multigpu-query-invalid-cs-cycles:
- shard-adlp: NOTRUN -> [SKIP][88] ([Intel XE#944])
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@xe_query@multigpu-query-invalid-cs-cycles.html
* igt@xe_query@multigpu-query-topology-l3-bank-mask:
- shard-dg2-set2: NOTRUN -> [SKIP][89] ([Intel XE#944])
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-466/igt@xe_query@multigpu-query-topology-l3-bank-mask.html
* igt@xe_render_copy@render-stress-0-copies:
- shard-adlp: NOTRUN -> [SKIP][90] ([Intel XE#4814] / [Intel XE#5614])
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@xe_render_copy@render-stress-0-copies.html
#### Possible fixes ####
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-adlp: [DMESG-FAIL][91] ([Intel XE#4543]) -> [PASS][92] +2 other tests pass
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-adlp-2/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_bw@connected-linear-tiling-2-displays-3840x2160p:
- shard-bmg: [SKIP][93] ([Intel XE#2314] / [Intel XE#2894]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-6/igt@kms_bw@connected-linear-tiling-2-displays-3840x2160p.html
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-1/igt@kms_bw@connected-linear-tiling-2-displays-3840x2160p.html
* igt@kms_cursor_crc@cursor-random-128x42:
- shard-adlp: [DMESG-WARN][95] ([Intel XE#2953] / [Intel XE#4173]) -> [PASS][96] +5 other tests pass
[95]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-adlp-2/igt@kms_cursor_crc@cursor-random-128x42.html
[96]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-2/igt@kms_cursor_crc@cursor-random-128x42.html
* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- shard-bmg: [DMESG-WARN][97] ([Intel XE#5354]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-4/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
[98]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-3/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-bmg: [SKIP][99] ([Intel XE#2291]) -> [PASS][100] +2 other tests pass
[99]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-6/igt@kms_cursor_legacy@cursora-vs-flipb-varying-size.html
[100]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-1/igt@kms_cursor_legacy@cursora-vs-flipb-varying-size.html
* igt@kms_flip@2x-plain-flip-interruptible:
- shard-bmg: [SKIP][101] ([Intel XE#2316]) -> [PASS][102] +6 other tests pass
[101]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-6/igt@kms_flip@2x-plain-flip-interruptible.html
[102]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-8/igt@kms_flip@2x-plain-flip-interruptible.html
* igt@kms_flip@basic-flip-vs-dpms@c-hdmi-a1:
- shard-adlp: [DMESG-WARN][103] ([Intel XE#4543]) -> [PASS][104] +3 other tests pass
[103]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-adlp-4/igt@kms_flip@basic-flip-vs-dpms@c-hdmi-a1.html
[104]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_flip@basic-flip-vs-dpms@c-hdmi-a1.html
* igt@kms_flip@flip-vs-rmfb:
- shard-adlp: [DMESG-WARN][105] ([Intel XE#4543] / [Intel XE#5208]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-adlp-8/igt@kms_flip@flip-vs-rmfb.html
[106]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-9/igt@kms_flip@flip-vs-rmfb.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-bmg: [INCOMPLETE][107] ([Intel XE#2049] / [Intel XE#2597]) -> [PASS][108] +1 other test pass
[107]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-7/igt@kms_flip@flip-vs-suspend-interruptible.html
[108]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-4/igt@kms_flip@flip-vs-suspend-interruptible.html
- shard-dg2-set2: [INCOMPLETE][109] ([Intel XE#2049] / [Intel XE#2597]) -> [PASS][110] +1 other test pass
[109]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-dg2-435/igt@kms_flip@flip-vs-suspend-interruptible.html
[110]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-434/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_hdr@static-toggle-suspend:
- shard-bmg: [SKIP][111] ([Intel XE#1503]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-6/igt@kms_hdr@static-toggle-suspend.html
[112]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-1/igt@kms_hdr@static-toggle-suspend.html
* igt@kms_joiner@basic-force-big-joiner:
- shard-bmg: [SKIP][113] ([Intel XE#3012]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-6/igt@kms_joiner@basic-force-big-joiner.html
[114]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-1/igt@kms_joiner@basic-force-big-joiner.html
* igt@kms_plane_lowres@tiling-x:
- shard-dg2-set2: [DMESG-WARN][115] -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-dg2-434/igt@kms_plane_lowres@tiling-x.html
[116]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-432/igt@kms_plane_lowres@tiling-x.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats:
- shard-dg2-set2: [INCOMPLETE][117] ([Intel XE#4842]) -> [PASS][118] +1 other test pass
[117]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-dg2-466/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats.html
[118]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-435/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats.html
* igt@kms_pm_rpm@modeset-lpsp:
- shard-adlp: [ABORT][119] ([Intel XE#5545]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-adlp-6/igt@kms_pm_rpm@modeset-lpsp.html
[120]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@kms_pm_rpm@modeset-lpsp.html
* igt@kms_vrr@cmrr@pipe-a-edp-1:
- shard-lnl: [FAIL][121] ([Intel XE#4459]) -> [PASS][122] +1 other test pass
[121]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-lnl-7/igt@kms_vrr@cmrr@pipe-a-edp-1.html
[122]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-lnl-2/igt@kms_vrr@cmrr@pipe-a-edp-1.html
* igt@xe_exec_basic@multigpu-once-bindexecqueue:
- shard-dg2-set2: [SKIP][123] ([Intel XE#1392]) -> [PASS][124] +9 other tests pass
[123]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-dg2-432/igt@xe_exec_basic@multigpu-once-bindexecqueue.html
[124]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-463/igt@xe_exec_basic@multigpu-once-bindexecqueue.html
* igt@xe_exec_reset@parallel-gt-reset:
- shard-adlp: [DMESG-WARN][125] ([Intel XE#3876]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-adlp-6/igt@xe_exec_reset@parallel-gt-reset.html
[126]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-adlp-8/igt@xe_exec_reset@parallel-gt-reset.html
* igt@xe_exec_system_allocator@threads-shared-vm-many-large-new-bo-map-nomemset:
- shard-lnl: [FAIL][127] ([Intel XE#5018]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-lnl-3/igt@xe_exec_system_allocator@threads-shared-vm-many-large-new-bo-map-nomemset.html
[128]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-lnl-7/igt@xe_exec_system_allocator@threads-shared-vm-many-large-new-bo-map-nomemset.html
* igt@xe_exec_threads@threads-hang-rebind-err:
- shard-dg2-set2: [DMESG-WARN][129] ([Intel XE#3876]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-dg2-434/igt@xe_exec_threads@threads-hang-rebind-err.html
[130]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-432/igt@xe_exec_threads@threads-hang-rebind-err.html
#### Warnings ####
* igt@kms_content_protection@lic-type-0:
- shard-bmg: [FAIL][131] ([Intel XE#1178]) -> [SKIP][132] ([Intel XE#2341])
[131]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-8/igt@kms_content_protection@lic-type-0.html
[132]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-6/igt@kms_content_protection@lic-type-0.html
* igt@kms_content_protection@srm:
- shard-bmg: [SKIP][133] ([Intel XE#2341]) -> [FAIL][134] ([Intel XE#1178])
[133]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-6/igt@kms_content_protection@srm.html
[134]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-8/igt@kms_content_protection@srm.html
* igt@kms_frontbuffer_tracking@drrs-2p-primscrn-pri-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][135] ([Intel XE#2311]) -> [SKIP][136] ([Intel XE#2312]) +14 other tests skip
[135]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-7/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-pri-indfb-draw-mmap-wc.html
[136]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-6/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-pri-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][137] ([Intel XE#2312]) -> [SKIP][138] ([Intel XE#2311]) +10 other tests skip
[137]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-6/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-pri-indfb-draw-mmap-wc.html
[138]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-1/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][139] ([Intel XE#2312]) -> [SKIP][140] ([Intel XE#5390]) +6 other tests skip
[139]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc.html
[140]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-render:
- shard-bmg: [SKIP][141] ([Intel XE#5390]) -> [SKIP][142] ([Intel XE#2312]) +10 other tests skip
[141]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-render.html
[142]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt:
- shard-bmg: [SKIP][143] ([Intel XE#2313]) -> [SKIP][144] ([Intel XE#2312]) +15 other tests skip
[143]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt.html
[144]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-plflip-blt:
- shard-bmg: [SKIP][145] ([Intel XE#2312]) -> [SKIP][146] ([Intel XE#2313]) +10 other tests skip
[145]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-plflip-blt.html
[146]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-plflip-blt.html
* igt@kms_plane_multiple@2x-tiling-y:
- shard-bmg: [SKIP][147] ([Intel XE#5021]) -> [SKIP][148] ([Intel XE#4596])
[147]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-3/igt@kms_plane_multiple@2x-tiling-y.html
[148]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-6/igt@kms_plane_multiple@2x-tiling-y.html
* igt@kms_tiled_display@basic-test-pattern:
- shard-bmg: [FAIL][149] ([Intel XE#1729]) -> [SKIP][150] ([Intel XE#2426])
[149]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-bmg-1/igt@kms_tiled_display@basic-test-pattern.html
[150]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-bmg-3/igt@kms_tiled_display@basic-test-pattern.html
* igt@xe_peer2peer@read:
- shard-dg2-set2: [SKIP][151] ([Intel XE#1061]) -> [FAIL][152] ([Intel XE#1173])
[151]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3466-22160d1b26a745a0a939dbc792485a2404aea536/shard-dg2-432/igt@xe_peer2peer@read.html
[152]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/shard-dg2-463/igt@xe_peer2peer@read.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#1061]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1061
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1173
[Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
[Intel XE#1392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1392
[Intel XE#1401]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1401
[Intel XE#1435]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1435
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#1745]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1745
[Intel XE#2049]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2049
[Intel XE#2191]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2191
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2291]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2291
[Intel XE#2293]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2293
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2312
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2314]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2314
[Intel XE#2316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2316
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2341]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2341
[Intel XE#2360]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2360
[Intel XE#2380]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2380
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2597]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2597
[Intel XE#2652]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2652
[Intel XE#2669]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2669
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#2894]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2894
[Intel XE#2953]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2953
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#3012]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3012
[Intel XE#308]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/308
[Intel XE#3088]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3088
[Intel XE#310]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/310
[Intel XE#3149]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3149
[Intel XE#316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/316
[Intel XE#3414]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3414
[Intel XE#3573]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3573
[Intel XE#367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/367
[Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
[Intel XE#3876]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3876
[Intel XE#4173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4173
[Intel XE#4416]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4416
[Intel XE#4459]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4459
[Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
[Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
[Intel XE#4596]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4596
[Intel XE#4814]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4814
[Intel XE#4837]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4837
[Intel XE#4842]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4842
[Intel XE#4915]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4915
[Intel XE#5018]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5018
[Intel XE#5021]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5021
[Intel XE#5208]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5208
[Intel XE#5300]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5300
[Intel XE#5354]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5354
[Intel XE#5390]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5390
[Intel XE#5545]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5545
[Intel XE#5560]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5560
[Intel XE#5561]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5561
[Intel XE#5565]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5565
[Intel XE#5575]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5575
[Intel XE#5614]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5614
[Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
[Intel XE#619]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/619
[Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
[Intel XE#653]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/653
[Intel XE#656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/656
[Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
[Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944
Build changes
-------------
* Linux: xe-3466-22160d1b26a745a0a939dbc792485a2404aea536 -> xe-pw-151901v3
IGT_8475: 1ddc997191d8aa008b49b5a4c47cf295c9a3c4f4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-3466-22160d1b26a745a0a939dbc792485a2404aea536: 22160d1b26a745a0a939dbc792485a2404aea536
xe-pw-151901v3: 151901v3
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151901v3/index.html
[-- Attachment #2: Type: text/html, Size: 55766 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex.
2025-07-23 14:24 [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex Maarten Lankhorst
` (3 preceding siblings ...)
2025-07-24 2:54 ` ✗ Xe.CI.Full: failure " Patchwork
@ 2025-10-03 13:29 ` Maarten Lankhorst
2025-10-03 18:00 ` Mukesh Ojha
2025-10-24 8:12 ` Johannes Berg
6 siblings, 0 replies; 13+ messages in thread
From: Maarten Lankhorst @ 2025-10-03 13:29 UTC (permalink / raw)
To: linux-kernel
Cc: intel-xe, Mukesh Ojha, Greg Kroah-Hartman, Johannes Berg,
Rafael J. Wysocki, Danilo Krummrich, stable, Matthew Brost
Ping?
Den 2025-07-23 kl. 16:24, skrev Maarten Lankhorst:
> The original code causes a circular locking dependency found by lockdep.
>
> ======================================================
> WARNING: possible circular locking dependency detected
> 6.16.0-rc6-lgci-xe-xe-pw-151626v3+ #1 Tainted: G S U
> ------------------------------------------------------
> xe_fault_inject/5091 is trying to acquire lock:
> ffff888156815688 ((work_completion)(&(&devcd->del_wk)->work)){+.+.}-{0:0}, at: __flush_work+0x25d/0x660
>
> but task is already holding lock:
>
> ffff888156815620 (&devcd->mutex){+.+.}-{3:3}, at: dev_coredump_put+0x3f/0xa0
> which lock already depends on the new lock.
> the existing dependency chain (in reverse order) is:
> -> #2 (&devcd->mutex){+.+.}-{3:3}:
> mutex_lock_nested+0x4e/0xc0
> devcd_data_write+0x27/0x90
> sysfs_kf_bin_write+0x80/0xf0
> kernfs_fop_write_iter+0x169/0x220
> vfs_write+0x293/0x560
> ksys_write+0x72/0xf0
> __x64_sys_write+0x19/0x30
> x64_sys_call+0x2bf/0x2660
> do_syscall_64+0x93/0xb60
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
> -> #1 (kn->active#236){++++}-{0:0}:
> kernfs_drain+0x1e2/0x200
> __kernfs_remove+0xae/0x400
> kernfs_remove_by_name_ns+0x5d/0xc0
> remove_files+0x54/0x70
> sysfs_remove_group+0x3d/0xa0
> sysfs_remove_groups+0x2e/0x60
> device_remove_attrs+0xc7/0x100
> device_del+0x15d/0x3b0
> devcd_del+0x19/0x30
> process_one_work+0x22b/0x6f0
> worker_thread+0x1e8/0x3d0
> kthread+0x11c/0x250
> ret_from_fork+0x26c/0x2e0
> ret_from_fork_asm+0x1a/0x30
> -> #0 ((work_completion)(&(&devcd->del_wk)->work)){+.+.}-{0:0}:
> __lock_acquire+0x1661/0x2860
> lock_acquire+0xc4/0x2f0
> __flush_work+0x27a/0x660
> flush_delayed_work+0x5d/0xa0
> dev_coredump_put+0x63/0xa0
> xe_driver_devcoredump_fini+0x12/0x20 [xe]
> devm_action_release+0x12/0x30
> release_nodes+0x3a/0x120
> devres_release_all+0x8a/0xd0
> device_unbind_cleanup+0x12/0x80
> device_release_driver_internal+0x23a/0x280
> device_driver_detach+0x14/0x20
> unbind_store+0xaf/0xc0
> drv_attr_store+0x21/0x50
> sysfs_kf_write+0x4a/0x80
> kernfs_fop_write_iter+0x169/0x220
> vfs_write+0x293/0x560
> ksys_write+0x72/0xf0
> __x64_sys_write+0x19/0x30
> x64_sys_call+0x2bf/0x2660
> do_syscall_64+0x93/0xb60
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
> other info that might help us debug this:
> Chain exists of: (work_completion)(&(&devcd->del_wk)->work) --> kn->active#236 --> &devcd->mutex
> Possible unsafe locking scenario:
> CPU0 CPU1
> ---- ----
> lock(&devcd->mutex);
> lock(kn->active#236);
> lock(&devcd->mutex);
> lock((work_completion)(&(&devcd->del_wk)->work));
> *** DEADLOCK ***
> 5 locks held by xe_fault_inject/5091:
> #0: ffff8881129f9488 (sb_writers#5){.+.+}-{0:0}, at: ksys_write+0x72/0xf0
> #1: ffff88810c755078 (&of->mutex#2){+.+.}-{3:3}, at: kernfs_fop_write_iter+0x123/0x220
> #2: ffff8881054811a0 (&dev->mutex){....}-{3:3}, at: device_release_driver_internal+0x55/0x280
> #3: ffff888156815620 (&devcd->mutex){+.+.}-{3:3}, at: dev_coredump_put+0x3f/0xa0
> #4: ffffffff8359e020 (rcu_read_lock){....}-{1:2}, at: __flush_work+0x72/0x660
> stack backtrace:
> CPU: 14 UID: 0 PID: 5091 Comm: xe_fault_inject Tainted: G S U 6.16.0-rc6-lgci-xe-xe-pw-151626v3+ #1 PREEMPT_{RT,(lazy)}
> Tainted: [S]=CPU_OUT_OF_SPEC, [U]=USER
> Hardware name: Micro-Star International Co., Ltd. MS-7D25/PRO Z690-A DDR4(MS-7D25), BIOS 1.10 12/13/2021
> Call Trace:
> <TASK>
> dump_stack_lvl+0x91/0xf0
> dump_stack+0x10/0x20
> print_circular_bug+0x285/0x360
> check_noncircular+0x135/0x150
> ? register_lock_class+0x48/0x4a0
> __lock_acquire+0x1661/0x2860
> lock_acquire+0xc4/0x2f0
> ? __flush_work+0x25d/0x660
> ? mark_held_locks+0x46/0x90
> ? __flush_work+0x25d/0x660
> __flush_work+0x27a/0x660
> ? __flush_work+0x25d/0x660
> ? trace_hardirqs_on+0x1e/0xd0
> ? __pfx_wq_barrier_func+0x10/0x10
> flush_delayed_work+0x5d/0xa0
> dev_coredump_put+0x63/0xa0
> xe_driver_devcoredump_fini+0x12/0x20 [xe]
> devm_action_release+0x12/0x30
> release_nodes+0x3a/0x120
> devres_release_all+0x8a/0xd0
> device_unbind_cleanup+0x12/0x80
> device_release_driver_internal+0x23a/0x280
> ? bus_find_device+0xa8/0xe0
> device_driver_detach+0x14/0x20
> unbind_store+0xaf/0xc0
> drv_attr_store+0x21/0x50
> sysfs_kf_write+0x4a/0x80
> kernfs_fop_write_iter+0x169/0x220
> vfs_write+0x293/0x560
> ksys_write+0x72/0xf0
> __x64_sys_write+0x19/0x30
> x64_sys_call+0x2bf/0x2660
> do_syscall_64+0x93/0xb60
> ? __f_unlock_pos+0x15/0x20
> ? __x64_sys_getdents64+0x9b/0x130
> ? __pfx_filldir64+0x10/0x10
> ? do_syscall_64+0x1a2/0xb60
> ? clear_bhb_loop+0x30/0x80
> ? clear_bhb_loop+0x30/0x80
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
> RIP: 0033:0x76e292edd574
> Code: c7 00 16 00 00 00 b8 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 80 3d d5 ea 0e 00 00 74 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 55 48 89 e5 48 83 ec 20 48 89
> RSP: 002b:00007fffe247a828 EFLAGS: 00000202 ORIG_RAX: 0000000000000001
> RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 000076e292edd574
> RDX: 000000000000000c RSI: 00006267f6306063 RDI: 000000000000000b
> RBP: 000000000000000c R08: 000076e292fc4b20 R09: 0000000000000000
> R10: 0000000000000000 R11: 0000000000000202 R12: 00006267f6306063
> R13: 000000000000000b R14: 00006267e6859c00 R15: 000076e29322a000
> </TASK>
> xe 0000:03:00.0: [drm] Xe device coredump has been deleted.
>
> Fixes: 01daccf74832 ("devcoredump : Serialize devcd_del work")
> Cc: Mukesh Ojha <quic_mojha@quicinc.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: linux-kernel@vger.kernel.org
> Cc: <stable@vger.kernel.org> # v6.1+
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> Cc: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/base/devcoredump.c | 136 ++++++++++++++++++++++---------------
> 1 file changed, 83 insertions(+), 53 deletions(-)
>
> diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c
> index 03a39c417dc41..ad4bddde12ccb 100644
> --- a/drivers/base/devcoredump.c
> +++ b/drivers/base/devcoredump.c
> @@ -23,50 +23,46 @@ struct devcd_entry {
> void *data;
> size_t datalen;
> /*
> - * Here, mutex is required to serialize the calls to del_wk work between
> - * user/kernel space which happens when devcd is added with device_add()
> - * and that sends uevent to user space. User space reads the uevents,
> - * and calls to devcd_data_write() which try to modify the work which is
> - * not even initialized/queued from devcoredump.
> + * There are 2 races for which mutex is required.
> *
> + * The first race is between device creation and userspace writing to
> + * schedule immediately destruction.
> *
> + * This race is handled by arming the timer before device creation, but
> + * when device creation fails the timer still exists.
> *
> - * cpu0(X) cpu1(Y)
> + * To solve this, hold the mutex during device_add(), and set
> + * init_completed on success before releasing the mutex.
> *
> - * dev_coredump() uevent sent to user space
> - * device_add() ======================> user space process Y reads the
> - * uevents writes to devcd fd
> - * which results into writes to
> + * That way the timer will never fire until device_add() is called,
> + * it will do nothing if init_completed is not set. The timer is also
> + * cancelled in that case.
> *
> - * devcd_data_write()
> - * mod_delayed_work()
> - * try_to_grab_pending()
> - * timer_delete()
> - * debug_assert_init()
> - * INIT_DELAYED_WORK()
> - * schedule_delayed_work()
> - *
> - *
> - * Also, mutex alone would not be enough to avoid scheduling of
> - * del_wk work after it get flush from a call to devcd_free()
> - * mentioned as below.
> - *
> - * disabled_store()
> - * devcd_free()
> - * mutex_lock() devcd_data_write()
> - * flush_delayed_work()
> - * mutex_unlock()
> - * mutex_lock()
> - * mod_delayed_work()
> - * mutex_unlock()
> - * So, delete_work flag is required.
> + * The second race involves multiple parallel invocations of devcd_free(),
> + * add a deleted flag so only 1 can call the destructor.
> */
> struct mutex mutex;
> - bool delete_work;
> + bool init_completed, deleted;
> struct module *owner;
> ssize_t (*read)(char *buffer, loff_t offset, size_t count,
> void *data, size_t datalen);
> void (*free)(void *data);
> + /*
> + * If nothing interferes and device_add() was returns success,
> + * del_wk will destroy the device after the timer fires.
> + *
> + * Multiple userspace processes can interfere in the working of the timer:
> + * - Writing to the coredump will reschedule the timer to run immediately,
> + * if still armed.
> + *
> + * This is handled by using "if (cancel_delayed_work()) {
> + * schedule_delayed_work() }", to prevent re-arming after having
> + * been previously fired.
> + * - Writing to /sys/class/devcoredump/disabled will destroy the
> + * coredump synchronously.
> + * This is handled by using disable_delayed_work_sync(), and then
> + * checking if deleted flag is set with &devcd->mutex held.
> + */
> struct delayed_work del_wk;
> struct device *failing_dev;
> };
> @@ -95,14 +91,27 @@ static void devcd_dev_release(struct device *dev)
> kfree(devcd);
> }
>
> +static void __devcd_del(struct devcd_entry *devcd)
> +{
> + devcd->deleted = true;
> + device_del(&devcd->devcd_dev);
> + put_device(&devcd->devcd_dev);
> +}
> +
> static void devcd_del(struct work_struct *wk)
> {
> struct devcd_entry *devcd;
> + bool init_completed;
>
> devcd = container_of(wk, struct devcd_entry, del_wk.work);
>
> - device_del(&devcd->devcd_dev);
> - put_device(&devcd->devcd_dev);
> + /* devcd->mutex serializes against dev_coredumpm_timeout */
> + mutex_lock(&devcd->mutex);
> + init_completed = devcd->init_completed;
> + mutex_unlock(&devcd->mutex);
> +
> + if (init_completed)
> + __devcd_del(devcd);
> }
>
> static ssize_t devcd_data_read(struct file *filp, struct kobject *kobj,
> @@ -122,12 +131,12 @@ static ssize_t devcd_data_write(struct file *filp, struct kobject *kobj,
> struct device *dev = kobj_to_dev(kobj);
> struct devcd_entry *devcd = dev_to_devcd(dev);
>
> - mutex_lock(&devcd->mutex);
> - if (!devcd->delete_work) {
> - devcd->delete_work = true;
> - mod_delayed_work(system_wq, &devcd->del_wk, 0);
> - }
> - mutex_unlock(&devcd->mutex);
> + /*
> + * Although it's tempting to use mod_delayed work here,
> + * that will cause a reschedule if the timer already fired.
> + */
> + if (cancel_delayed_work(&devcd->del_wk))
> + schedule_delayed_work(&devcd->del_wk, 0);
>
> return count;
> }
> @@ -151,11 +160,21 @@ static int devcd_free(struct device *dev, void *data)
> {
> struct devcd_entry *devcd = dev_to_devcd(dev);
>
> + /*
> + * To prevent a race with devcd_data_write(), disable work and
> + * complete manually instead.
> + *
> + * We cannot rely on the return value of
> + * disable_delayed_work_sync() here, because it might be in the
> + * middle of a cancel_delayed_work + schedule_delayed_work pair.
> + *
> + * devcd->mutex here guards against multiple parallel invocations
> + * of devcd_free().
> + */
> + disable_delayed_work_sync(&devcd->del_wk);
> mutex_lock(&devcd->mutex);
> - if (!devcd->delete_work)
> - devcd->delete_work = true;
> -
> - flush_delayed_work(&devcd->del_wk);
> + if (!devcd->deleted)
> + __devcd_del(devcd);
> mutex_unlock(&devcd->mutex);
> return 0;
> }
> @@ -179,12 +198,10 @@ static ssize_t disabled_show(const struct class *class, const struct class_attri
> * put_device() <- last reference
> * error = fn(dev, data) devcd_dev_release()
> * devcd_free(dev, data) kfree(devcd)
> - * mutex_lock(&devcd->mutex);
> *
> *
> * In the above diagram, it looks like disabled_store() would be racing with parallelly
> - * running devcd_del() and result in memory abort while acquiring devcd->mutex which
> - * is called after kfree of devcd memory after dropping its last reference with
> + * running devcd_del() and result in memory abort after dropping its last reference with
> * put_device(). However, this will not happens as fn(dev, data) runs
> * with its own reference to device via klist_node so it is not its last reference.
> * so, above situation would not occur.
> @@ -374,7 +391,7 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
> devcd->read = read;
> devcd->free = free;
> devcd->failing_dev = get_device(dev);
> - devcd->delete_work = false;
> + devcd->deleted = false;
>
> mutex_init(&devcd->mutex);
> device_initialize(&devcd->devcd_dev);
> @@ -383,8 +400,14 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
> atomic_inc_return(&devcd_count));
> devcd->devcd_dev.class = &devcd_class;
>
> - mutex_lock(&devcd->mutex);
> dev_set_uevent_suppress(&devcd->devcd_dev, true);
> +
> + /* devcd->mutex prevents devcd_del() completing until init finishes */
> + mutex_lock(&devcd->mutex);
> + devcd->init_completed = false;
> + INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
> + schedule_delayed_work(&devcd->del_wk, timeout);
> +
> if (device_add(&devcd->devcd_dev))
> goto put_device;
>
> @@ -401,13 +424,20 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
>
> dev_set_uevent_suppress(&devcd->devcd_dev, false);
> kobject_uevent(&devcd->devcd_dev.kobj, KOBJ_ADD);
> - INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
> - schedule_delayed_work(&devcd->del_wk, timeout);
> +
> + /*
> + * Safe to run devcd_del() now that we are done with devcd_dev.
> + * Alternatively we could have taken a ref on devcd_dev before
> + * dropping the lock.
> + */
> + devcd->init_completed = true;
> mutex_unlock(&devcd->mutex);
> return;
> put_device:
> - put_device(&devcd->devcd_dev);
> mutex_unlock(&devcd->mutex);
> + cancel_delayed_work_sync(&devcd->del_wk);
> + put_device(&devcd->devcd_dev);
> +
> put_module:
> module_put(owner);
> free:
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex.
2025-07-23 14:24 [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex Maarten Lankhorst
` (4 preceding siblings ...)
2025-10-03 13:29 ` [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex Maarten Lankhorst
@ 2025-10-03 18:00 ` Mukesh Ojha
2025-10-06 9:11 ` Maarten Lankhorst
2025-10-24 8:12 ` Johannes Berg
6 siblings, 1 reply; 13+ messages in thread
From: Mukesh Ojha @ 2025-10-03 18:00 UTC (permalink / raw)
To: Maarten Lankhorst
Cc: linux-kernel, intel-xe, Mukesh Ojha, Greg Kroah-Hartman,
Johannes Berg, Rafael J. Wysocki, Danilo Krummrich, stable,
Matthew Brost
On Wed, Jul 23, 2025 at 04:24:16PM +0200, Maarten Lankhorst wrote:
> The original code causes a circular locking dependency found by lockdep.
>
> ======================================================
> WARNING: possible circular locking dependency detected
> 6.16.0-rc6-lgci-xe-xe-pw-151626v3+ #1 Tainted: G S U
> ------------------------------------------------------
> xe_fault_inject/5091 is trying to acquire lock:
> ffff888156815688 ((work_completion)(&(&devcd->del_wk)->work)){+.+.}-{0:0}, at: __flush_work+0x25d/0x660
>
> but task is already holding lock:
>
> ffff888156815620 (&devcd->mutex){+.+.}-{3:3}, at: dev_coredump_put+0x3f/0xa0
> which lock already depends on the new lock.
> the existing dependency chain (in reverse order) is:
> -> #2 (&devcd->mutex){+.+.}-{3:3}:
> mutex_lock_nested+0x4e/0xc0
> devcd_data_write+0x27/0x90
> sysfs_kf_bin_write+0x80/0xf0
> kernfs_fop_write_iter+0x169/0x220
> vfs_write+0x293/0x560
> ksys_write+0x72/0xf0
> __x64_sys_write+0x19/0x30
> x64_sys_call+0x2bf/0x2660
> do_syscall_64+0x93/0xb60
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
> -> #1 (kn->active#236){++++}-{0:0}:
> kernfs_drain+0x1e2/0x200
> __kernfs_remove+0xae/0x400
> kernfs_remove_by_name_ns+0x5d/0xc0
> remove_files+0x54/0x70
> sysfs_remove_group+0x3d/0xa0
> sysfs_remove_groups+0x2e/0x60
> device_remove_attrs+0xc7/0x100
> device_del+0x15d/0x3b0
> devcd_del+0x19/0x30
> process_one_work+0x22b/0x6f0
> worker_thread+0x1e8/0x3d0
> kthread+0x11c/0x250
> ret_from_fork+0x26c/0x2e0
> ret_from_fork_asm+0x1a/0x30
> -> #0 ((work_completion)(&(&devcd->del_wk)->work)){+.+.}-{0:0}:
> __lock_acquire+0x1661/0x2860
> lock_acquire+0xc4/0x2f0
> __flush_work+0x27a/0x660
> flush_delayed_work+0x5d/0xa0
> dev_coredump_put+0x63/0xa0
> xe_driver_devcoredump_fini+0x12/0x20 [xe]
> devm_action_release+0x12/0x30
> release_nodes+0x3a/0x120
> devres_release_all+0x8a/0xd0
> device_unbind_cleanup+0x12/0x80
> device_release_driver_internal+0x23a/0x280
> device_driver_detach+0x14/0x20
> unbind_store+0xaf/0xc0
> drv_attr_store+0x21/0x50
> sysfs_kf_write+0x4a/0x80
> kernfs_fop_write_iter+0x169/0x220
> vfs_write+0x293/0x560
> ksys_write+0x72/0xf0
> __x64_sys_write+0x19/0x30
> x64_sys_call+0x2bf/0x2660
> do_syscall_64+0x93/0xb60
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
> other info that might help us debug this:
> Chain exists of: (work_completion)(&(&devcd->del_wk)->work) --> kn->active#236 --> &devcd->mutex
> Possible unsafe locking scenario:
> CPU0 CPU1
> ---- ----
> lock(&devcd->mutex);
> lock(kn->active#236);
> lock(&devcd->mutex);
> lock((work_completion)(&(&devcd->del_wk)->work));
> *** DEADLOCK ***
> 5 locks held by xe_fault_inject/5091:
> #0: ffff8881129f9488 (sb_writers#5){.+.+}-{0:0}, at: ksys_write+0x72/0xf0
> #1: ffff88810c755078 (&of->mutex#2){+.+.}-{3:3}, at: kernfs_fop_write_iter+0x123/0x220
> #2: ffff8881054811a0 (&dev->mutex){....}-{3:3}, at: device_release_driver_internal+0x55/0x280
> #3: ffff888156815620 (&devcd->mutex){+.+.}-{3:3}, at: dev_coredump_put+0x3f/0xa0
> #4: ffffffff8359e020 (rcu_read_lock){....}-{1:2}, at: __flush_work+0x72/0x660
> stack backtrace:
> CPU: 14 UID: 0 PID: 5091 Comm: xe_fault_inject Tainted: G S U 6.16.0-rc6-lgci-xe-xe-pw-151626v3+ #1 PREEMPT_{RT,(lazy)}
> Tainted: [S]=CPU_OUT_OF_SPEC, [U]=USER
> Hardware name: Micro-Star International Co., Ltd. MS-7D25/PRO Z690-A DDR4(MS-7D25), BIOS 1.10 12/13/2021
> Call Trace:
> <TASK>
> dump_stack_lvl+0x91/0xf0
> dump_stack+0x10/0x20
> print_circular_bug+0x285/0x360
> check_noncircular+0x135/0x150
> ? register_lock_class+0x48/0x4a0
> __lock_acquire+0x1661/0x2860
> lock_acquire+0xc4/0x2f0
> ? __flush_work+0x25d/0x660
> ? mark_held_locks+0x46/0x90
> ? __flush_work+0x25d/0x660
> __flush_work+0x27a/0x660
> ? __flush_work+0x25d/0x660
> ? trace_hardirqs_on+0x1e/0xd0
> ? __pfx_wq_barrier_func+0x10/0x10
> flush_delayed_work+0x5d/0xa0
> dev_coredump_put+0x63/0xa0
> xe_driver_devcoredump_fini+0x12/0x20 [xe]
> devm_action_release+0x12/0x30
> release_nodes+0x3a/0x120
> devres_release_all+0x8a/0xd0
> device_unbind_cleanup+0x12/0x80
> device_release_driver_internal+0x23a/0x280
> ? bus_find_device+0xa8/0xe0
> device_driver_detach+0x14/0x20
> unbind_store+0xaf/0xc0
> drv_attr_store+0x21/0x50
> sysfs_kf_write+0x4a/0x80
> kernfs_fop_write_iter+0x169/0x220
> vfs_write+0x293/0x560
> ksys_write+0x72/0xf0
> __x64_sys_write+0x19/0x30
> x64_sys_call+0x2bf/0x2660
> do_syscall_64+0x93/0xb60
> ? __f_unlock_pos+0x15/0x20
> ? __x64_sys_getdents64+0x9b/0x130
> ? __pfx_filldir64+0x10/0x10
> ? do_syscall_64+0x1a2/0xb60
> ? clear_bhb_loop+0x30/0x80
> ? clear_bhb_loop+0x30/0x80
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
> RIP: 0033:0x76e292edd574
> Code: c7 00 16 00 00 00 b8 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 80 3d d5 ea 0e 00 00 74 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 55 48 89 e5 48 83 ec 20 48 89
> RSP: 002b:00007fffe247a828 EFLAGS: 00000202 ORIG_RAX: 0000000000000001
> RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 000076e292edd574
> RDX: 000000000000000c RSI: 00006267f6306063 RDI: 000000000000000b
> RBP: 000000000000000c R08: 000076e292fc4b20 R09: 0000000000000000
> R10: 0000000000000000 R11: 0000000000000202 R12: 00006267f6306063
> R13: 000000000000000b R14: 00006267e6859c00 R15: 000076e29322a000
> </TASK>
> xe 0000:03:00.0: [drm] Xe device coredump has been deleted.
>
> Fixes: 01daccf74832 ("devcoredump : Serialize devcd_del work")
> Cc: Mukesh Ojha <quic_mojha@quicinc.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: linux-kernel@vger.kernel.org
> Cc: <stable@vger.kernel.org> # v6.1+
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> Cc: Matthew Brost <matthew.brost@intel.com>
Looks to be genuine issue.,
> ---
> drivers/base/devcoredump.c | 136 ++++++++++++++++++++++---------------
> 1 file changed, 83 insertions(+), 53 deletions(-)
>
> diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c
> index 03a39c417dc41..ad4bddde12ccb 100644
> --- a/drivers/base/devcoredump.c
> +++ b/drivers/base/devcoredump.c
> @@ -23,50 +23,46 @@ struct devcd_entry {
> void *data;
> size_t datalen;
> /*
> - * Here, mutex is required to serialize the calls to del_wk work between
> - * user/kernel space which happens when devcd is added with device_add()
> - * and that sends uevent to user space. User space reads the uevents,
> - * and calls to devcd_data_write() which try to modify the work which is
> - * not even initialized/queued from devcoredump.
> + * There are 2 races for which mutex is required.
> *
> + * The first race is between device creation and userspace writing to
> + * schedule immediately destruction.
> *
> + * This race is handled by arming the timer before device creation, but
> + * when device creation fails the timer still exists.
> *
> - * cpu0(X) cpu1(Y)
> + * To solve this, hold the mutex during device_add(), and set
> + * init_completed on success before releasing the mutex.
> *
> - * dev_coredump() uevent sent to user space
> - * device_add() ======================> user space process Y reads the
> - * uevents writes to devcd fd
> - * which results into writes to
> + * That way the timer will never fire until device_add() is called,
> + * it will do nothing if init_completed is not set. The timer is also
> + * cancelled in that case.
> *
> - * devcd_data_write()
> - * mod_delayed_work()
> - * try_to_grab_pending()
> - * timer_delete()
> - * debug_assert_init()
> - * INIT_DELAYED_WORK()
> - * schedule_delayed_work()
> - *
> - *
> - * Also, mutex alone would not be enough to avoid scheduling of
> - * del_wk work after it get flush from a call to devcd_free()
> - * mentioned as below.
> - *
> - * disabled_store()
> - * devcd_free()
> - * mutex_lock() devcd_data_write()
> - * flush_delayed_work()
> - * mutex_unlock()
> - * mutex_lock()
> - * mod_delayed_work()
> - * mutex_unlock()
> - * So, delete_work flag is required.
> + * The second race involves multiple parallel invocations of devcd_free(),
> + * add a deleted flag so only 1 can call the destructor.
> */
> struct mutex mutex;
> - bool delete_work;
> + bool init_completed, deleted;
> struct module *owner;
> ssize_t (*read)(char *buffer, loff_t offset, size_t count,
> void *data, size_t datalen);
> void (*free)(void *data);
> + /*
> + * If nothing interferes and device_add() was returns success,
> + * del_wk will destroy the device after the timer fires.
> + *
> + * Multiple userspace processes can interfere in the working of the timer:
> + * - Writing to the coredump will reschedule the timer to run immediately,
> + * if still armed.
> + *
> + * This is handled by using "if (cancel_delayed_work()) {
> + * schedule_delayed_work() }", to prevent re-arming after having
> + * been previously fired.
> + * - Writing to /sys/class/devcoredump/disabled will destroy the
> + * coredump synchronously.
> + * This is handled by using disable_delayed_work_sync(), and then
> + * checking if deleted flag is set with &devcd->mutex held.
> + */
> struct delayed_work del_wk;
> struct device *failing_dev;
> };
> @@ -95,14 +91,27 @@ static void devcd_dev_release(struct device *dev)
> kfree(devcd);
> }
>
> +static void __devcd_del(struct devcd_entry *devcd)
> +{
> + devcd->deleted = true;
> + device_del(&devcd->devcd_dev);
> + put_device(&devcd->devcd_dev);
> +}
> +
> static void devcd_del(struct work_struct *wk)
> {
> struct devcd_entry *devcd;
> + bool init_completed;
>
> devcd = container_of(wk, struct devcd_entry, del_wk.work);
>
> - device_del(&devcd->devcd_dev);
> - put_device(&devcd->devcd_dev);
> + /* devcd->mutex serializes against dev_coredumpm_timeout */
> + mutex_lock(&devcd->mutex);
> + init_completed = devcd->init_completed;
> + mutex_unlock(&devcd->mutex);
> +
> + if (init_completed)
> + __devcd_del(devcd);
> }
>
> static ssize_t devcd_data_read(struct file *filp, struct kobject *kobj,
> @@ -122,12 +131,12 @@ static ssize_t devcd_data_write(struct file *filp, struct kobject *kobj,
> struct device *dev = kobj_to_dev(kobj);
> struct devcd_entry *devcd = dev_to_devcd(dev);
>
> - mutex_lock(&devcd->mutex);
> - if (!devcd->delete_work) {
> - devcd->delete_work = true;
> - mod_delayed_work(system_wq, &devcd->del_wk, 0);
> - }
> - mutex_unlock(&devcd->mutex);
> + /*
> + * Although it's tempting to use mod_delayed work here,
> + * that will cause a reschedule if the timer already fired.
> + */
> + if (cancel_delayed_work(&devcd->del_wk))
> + schedule_delayed_work(&devcd->del_wk, 0);
>
> return count;
> }
> @@ -151,11 +160,21 @@ static int devcd_free(struct device *dev, void *data)
> {
> struct devcd_entry *devcd = dev_to_devcd(dev);
>
> + /*
> + * To prevent a race with devcd_data_write(), disable work and
> + * complete manually instead.
> + *
> + * We cannot rely on the return value of
> + * disable_delayed_work_sync() here, because it might be in the
> + * middle of a cancel_delayed_work + schedule_delayed_work pair.
> + *
> + * devcd->mutex here guards against multiple parallel invocations
> + * of devcd_free().
> + */
> + disable_delayed_work_sync(&devcd->del_wk);
> mutex_lock(&devcd->mutex);
> - if (!devcd->delete_work)
> - devcd->delete_work = true;
> -
> - flush_delayed_work(&devcd->del_wk);
> + if (!devcd->deleted)
> + __devcd_del(devcd);
> mutex_unlock(&devcd->mutex);
> return 0;
> }
> @@ -179,12 +198,10 @@ static ssize_t disabled_show(const struct class *class, const struct class_attri
> * put_device() <- last reference
> * error = fn(dev, data) devcd_dev_release()
> * devcd_free(dev, data) kfree(devcd)
> - * mutex_lock(&devcd->mutex);
> *
> *
> * In the above diagram, it looks like disabled_store() would be racing with parallelly
> - * running devcd_del() and result in memory abort while acquiring devcd->mutex which
> - * is called after kfree of devcd memory after dropping its last reference with
> + * running devcd_del() and result in memory abort after dropping its last reference with
> * put_device(). However, this will not happens as fn(dev, data) runs
> * with its own reference to device via klist_node so it is not its last reference.
> * so, above situation would not occur.
> @@ -374,7 +391,7 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
> devcd->read = read;
> devcd->free = free;
> devcd->failing_dev = get_device(dev);
> - devcd->delete_work = false;
> + devcd->deleted = false;
>
> mutex_init(&devcd->mutex);
> device_initialize(&devcd->devcd_dev);
> @@ -383,8 +400,14 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
> atomic_inc_return(&devcd_count));
> devcd->devcd_dev.class = &devcd_class;
>
> - mutex_lock(&devcd->mutex);
> dev_set_uevent_suppress(&devcd->devcd_dev, true);
> +
> + /* devcd->mutex prevents devcd_del() completing until init finishes */
> + mutex_lock(&devcd->mutex);
> + devcd->init_completed = false;
> + INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
> + schedule_delayed_work(&devcd->del_wk, timeout);
> +
> if (device_add(&devcd->devcd_dev))
> goto put_device;
>
> @@ -401,13 +424,20 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
>
> dev_set_uevent_suppress(&devcd->devcd_dev, false);
> kobject_uevent(&devcd->devcd_dev.kobj, KOBJ_ADD);
> - INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
> - schedule_delayed_work(&devcd->del_wk, timeout);
> +
> + /*
> + * Safe to run devcd_del() now that we are done with devcd_dev.
> + * Alternatively we could have taken a ref on devcd_dev before
> + * dropping the lock.
> + */
> + devcd->init_completed = true;
> mutex_unlock(&devcd->mutex);
> return;
> put_device:
> - put_device(&devcd->devcd_dev);
> mutex_unlock(&devcd->mutex);
> + cancel_delayed_work_sync(&devcd->del_wk);
> + put_device(&devcd->devcd_dev);
> +
Acked-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
> put_module:
> module_put(owner);
> free:
> --
> 2.45.2
>
--
-Mukesh Ojha
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex.
2025-10-03 18:00 ` Mukesh Ojha
@ 2025-10-06 9:11 ` Maarten Lankhorst
2025-10-06 9:24 ` Greg Kroah-Hartman
0 siblings, 1 reply; 13+ messages in thread
From: Maarten Lankhorst @ 2025-10-06 9:11 UTC (permalink / raw)
To: Mukesh Ojha
Cc: linux-kernel, intel-xe, Mukesh Ojha, Greg Kroah-Hartman,
Johannes Berg, Rafael J. Wysocki, Danilo Krummrich, stable,
Matthew Brost
Hey,
Den 2025-10-03 kl. 20:00, skrev Mukesh Ojha:
> On Wed, Jul 23, 2025 at 04:24:16PM +0200, Maarten Lankhorst wrote:
>> The original code causes a circular locking dependency found by lockdep.
>>
>> ======================================================
>> WARNING: possible circular locking dependency detected
>> 6.16.0-rc6-lgci-xe-xe-pw-151626v3+ #1 Tainted: G S U
>> ------------------------------------------------------
>> xe_fault_inject/5091 is trying to acquire lock:
>> ffff888156815688 ((work_completion)(&(&devcd->del_wk)->work)){+.+.}-{0:0}, at: __flush_work+0x25d/0x660
>>
>> but task is already holding lock:
>>
>> ffff888156815620 (&devcd->mutex){+.+.}-{3:3}, at: dev_coredump_put+0x3f/0xa0
>> which lock already depends on the new lock.
>> the existing dependency chain (in reverse order) is:
>> -> #2 (&devcd->mutex){+.+.}-{3:3}:
>> mutex_lock_nested+0x4e/0xc0
>> devcd_data_write+0x27/0x90
>> sysfs_kf_bin_write+0x80/0xf0
>> kernfs_fop_write_iter+0x169/0x220
>> vfs_write+0x293/0x560
>> ksys_write+0x72/0xf0
>> __x64_sys_write+0x19/0x30
>> x64_sys_call+0x2bf/0x2660
>> do_syscall_64+0x93/0xb60
>> entry_SYSCALL_64_after_hwframe+0x76/0x7e
>> -> #1 (kn->active#236){++++}-{0:0}:
>> kernfs_drain+0x1e2/0x200
>> __kernfs_remove+0xae/0x400
>> kernfs_remove_by_name_ns+0x5d/0xc0
>> remove_files+0x54/0x70
>> sysfs_remove_group+0x3d/0xa0
>> sysfs_remove_groups+0x2e/0x60
>> device_remove_attrs+0xc7/0x100
>> device_del+0x15d/0x3b0
>> devcd_del+0x19/0x30
>> process_one_work+0x22b/0x6f0
>> worker_thread+0x1e8/0x3d0
>> kthread+0x11c/0x250
>> ret_from_fork+0x26c/0x2e0
>> ret_from_fork_asm+0x1a/0x30
>> -> #0 ((work_completion)(&(&devcd->del_wk)->work)){+.+.}-{0:0}:
>> __lock_acquire+0x1661/0x2860
>> lock_acquire+0xc4/0x2f0
>> __flush_work+0x27a/0x660
>> flush_delayed_work+0x5d/0xa0
>> dev_coredump_put+0x63/0xa0
>> xe_driver_devcoredump_fini+0x12/0x20 [xe]
>> devm_action_release+0x12/0x30
>> release_nodes+0x3a/0x120
>> devres_release_all+0x8a/0xd0
>> device_unbind_cleanup+0x12/0x80
>> device_release_driver_internal+0x23a/0x280
>> device_driver_detach+0x14/0x20
>> unbind_store+0xaf/0xc0
>> drv_attr_store+0x21/0x50
>> sysfs_kf_write+0x4a/0x80
>> kernfs_fop_write_iter+0x169/0x220
>> vfs_write+0x293/0x560
>> ksys_write+0x72/0xf0
>> __x64_sys_write+0x19/0x30
>> x64_sys_call+0x2bf/0x2660
>> do_syscall_64+0x93/0xb60
>> entry_SYSCALL_64_after_hwframe+0x76/0x7e
>> other info that might help us debug this:
>> Chain exists of: (work_completion)(&(&devcd->del_wk)->work) --> kn->active#236 --> &devcd->mutex
>> Possible unsafe locking scenario:
>> CPU0 CPU1
>> ---- ----
>> lock(&devcd->mutex);
>> lock(kn->active#236);
>> lock(&devcd->mutex);
>> lock((work_completion)(&(&devcd->del_wk)->work));
>> *** DEADLOCK ***
>> 5 locks held by xe_fault_inject/5091:
>> #0: ffff8881129f9488 (sb_writers#5){.+.+}-{0:0}, at: ksys_write+0x72/0xf0
>> #1: ffff88810c755078 (&of->mutex#2){+.+.}-{3:3}, at: kernfs_fop_write_iter+0x123/0x220
>> #2: ffff8881054811a0 (&dev->mutex){....}-{3:3}, at: device_release_driver_internal+0x55/0x280
>> #3: ffff888156815620 (&devcd->mutex){+.+.}-{3:3}, at: dev_coredump_put+0x3f/0xa0
>> #4: ffffffff8359e020 (rcu_read_lock){....}-{1:2}, at: __flush_work+0x72/0x660
>> stack backtrace:
>> CPU: 14 UID: 0 PID: 5091 Comm: xe_fault_inject Tainted: G S U 6.16.0-rc6-lgci-xe-xe-pw-151626v3+ #1 PREEMPT_{RT,(lazy)}
>> Tainted: [S]=CPU_OUT_OF_SPEC, [U]=USER
>> Hardware name: Micro-Star International Co., Ltd. MS-7D25/PRO Z690-A DDR4(MS-7D25), BIOS 1.10 12/13/2021
>> Call Trace:
>> <TASK>
>> dump_stack_lvl+0x91/0xf0
>> dump_stack+0x10/0x20
>> print_circular_bug+0x285/0x360
>> check_noncircular+0x135/0x150
>> ? register_lock_class+0x48/0x4a0
>> __lock_acquire+0x1661/0x2860
>> lock_acquire+0xc4/0x2f0
>> ? __flush_work+0x25d/0x660
>> ? mark_held_locks+0x46/0x90
>> ? __flush_work+0x25d/0x660
>> __flush_work+0x27a/0x660
>> ? __flush_work+0x25d/0x660
>> ? trace_hardirqs_on+0x1e/0xd0
>> ? __pfx_wq_barrier_func+0x10/0x10
>> flush_delayed_work+0x5d/0xa0
>> dev_coredump_put+0x63/0xa0
>> xe_driver_devcoredump_fini+0x12/0x20 [xe]
>> devm_action_release+0x12/0x30
>> release_nodes+0x3a/0x120
>> devres_release_all+0x8a/0xd0
>> device_unbind_cleanup+0x12/0x80
>> device_release_driver_internal+0x23a/0x280
>> ? bus_find_device+0xa8/0xe0
>> device_driver_detach+0x14/0x20
>> unbind_store+0xaf/0xc0
>> drv_attr_store+0x21/0x50
>> sysfs_kf_write+0x4a/0x80
>> kernfs_fop_write_iter+0x169/0x220
>> vfs_write+0x293/0x560
>> ksys_write+0x72/0xf0
>> __x64_sys_write+0x19/0x30
>> x64_sys_call+0x2bf/0x2660
>> do_syscall_64+0x93/0xb60
>> ? __f_unlock_pos+0x15/0x20
>> ? __x64_sys_getdents64+0x9b/0x130
>> ? __pfx_filldir64+0x10/0x10
>> ? do_syscall_64+0x1a2/0xb60
>> ? clear_bhb_loop+0x30/0x80
>> ? clear_bhb_loop+0x30/0x80
>> entry_SYSCALL_64_after_hwframe+0x76/0x7e
>> RIP: 0033:0x76e292edd574
>> Code: c7 00 16 00 00 00 b8 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 80 3d d5 ea 0e 00 00 74 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 55 48 89 e5 48 83 ec 20 48 89
>> RSP: 002b:00007fffe247a828 EFLAGS: 00000202 ORIG_RAX: 0000000000000001
>> RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 000076e292edd574
>> RDX: 000000000000000c RSI: 00006267f6306063 RDI: 000000000000000b
>> RBP: 000000000000000c R08: 000076e292fc4b20 R09: 0000000000000000
>> R10: 0000000000000000 R11: 0000000000000202 R12: 00006267f6306063
>> R13: 000000000000000b R14: 00006267e6859c00 R15: 000076e29322a000
>> </TASK>
>> xe 0000:03:00.0: [drm] Xe device coredump has been deleted.
>>
>> Fixes: 01daccf74832 ("devcoredump : Serialize devcd_del work")
>> Cc: Mukesh Ojha <quic_mojha@quicinc.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Johannes Berg <johannes@sipsolutions.net>
>> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
>> Cc: Danilo Krummrich <dakr@kernel.org>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: <stable@vger.kernel.org> # v6.1+
>> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
>> Cc: Matthew Brost <matthew.brost@intel.com>
>
> Looks to be genuine issue.,
>
>> ---
>> drivers/base/devcoredump.c | 136 ++++++++++++++++++++++---------------
>> 1 file changed, 83 insertions(+), 53 deletions(-)
>>
>> diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c
>> index 03a39c417dc41..ad4bddde12ccb 100644
>> --- a/drivers/base/devcoredump.c
>> +++ b/drivers/base/devcoredump.c
>> @@ -23,50 +23,46 @@ struct devcd_entry {
>> void *data;
>> size_t datalen;
>> /*
>> - * Here, mutex is required to serialize the calls to del_wk work between
>> - * user/kernel space which happens when devcd is added with device_add()
>> - * and that sends uevent to user space. User space reads the uevents,
>> - * and calls to devcd_data_write() which try to modify the work which is
>> - * not even initialized/queued from devcoredump.
>> + * There are 2 races for which mutex is required.
>> *
>> + * The first race is between device creation and userspace writing to
>> + * schedule immediately destruction.
>> *
>> + * This race is handled by arming the timer before device creation, but
>> + * when device creation fails the timer still exists.
>> *
>> - * cpu0(X) cpu1(Y)
>> + * To solve this, hold the mutex during device_add(), and set
>> + * init_completed on success before releasing the mutex.
>> *
>> - * dev_coredump() uevent sent to user space
>> - * device_add() ======================> user space process Y reads the
>> - * uevents writes to devcd fd
>> - * which results into writes to
>> + * That way the timer will never fire until device_add() is called,
>> + * it will do nothing if init_completed is not set. The timer is also
>> + * cancelled in that case.
>> *
>> - * devcd_data_write()
>> - * mod_delayed_work()
>> - * try_to_grab_pending()
>> - * timer_delete()
>> - * debug_assert_init()
>> - * INIT_DELAYED_WORK()
>> - * schedule_delayed_work()
>> - *
>> - *
>> - * Also, mutex alone would not be enough to avoid scheduling of
>> - * del_wk work after it get flush from a call to devcd_free()
>> - * mentioned as below.
>> - *
>> - * disabled_store()
>> - * devcd_free()
>> - * mutex_lock() devcd_data_write()
>> - * flush_delayed_work()
>> - * mutex_unlock()
>> - * mutex_lock()
>> - * mod_delayed_work()
>> - * mutex_unlock()
>> - * So, delete_work flag is required.
>> + * The second race involves multiple parallel invocations of devcd_free(),
>> + * add a deleted flag so only 1 can call the destructor.
>> */
>> struct mutex mutex;
>> - bool delete_work;
>> + bool init_completed, deleted;
>> struct module *owner;
>> ssize_t (*read)(char *buffer, loff_t offset, size_t count,
>> void *data, size_t datalen);
>> void (*free)(void *data);
>> + /*
>> + * If nothing interferes and device_add() was returns success,
>> + * del_wk will destroy the device after the timer fires.
>> + *
>> + * Multiple userspace processes can interfere in the working of the timer:
>> + * - Writing to the coredump will reschedule the timer to run immediately,
>> + * if still armed.
>> + *
>> + * This is handled by using "if (cancel_delayed_work()) {
>> + * schedule_delayed_work() }", to prevent re-arming after having
>> + * been previously fired.
>> + * - Writing to /sys/class/devcoredump/disabled will destroy the
>> + * coredump synchronously.
>> + * This is handled by using disable_delayed_work_sync(), and then
>> + * checking if deleted flag is set with &devcd->mutex held.
>> + */
>> struct delayed_work del_wk;
>> struct device *failing_dev;
>> };
>> @@ -95,14 +91,27 @@ static void devcd_dev_release(struct device *dev)
>> kfree(devcd);
>> }
>>
>> +static void __devcd_del(struct devcd_entry *devcd)
>> +{
>> + devcd->deleted = true;
>> + device_del(&devcd->devcd_dev);
>> + put_device(&devcd->devcd_dev);
>> +}
>> +
>> static void devcd_del(struct work_struct *wk)
>> {
>> struct devcd_entry *devcd;
>> + bool init_completed;
>>
>> devcd = container_of(wk, struct devcd_entry, del_wk.work);
>>
>> - device_del(&devcd->devcd_dev);
>> - put_device(&devcd->devcd_dev);
>> + /* devcd->mutex serializes against dev_coredumpm_timeout */
>> + mutex_lock(&devcd->mutex);
>> + init_completed = devcd->init_completed;
>> + mutex_unlock(&devcd->mutex);
>> +
>> + if (init_completed)
>> + __devcd_del(devcd);
>> }
>>
>> static ssize_t devcd_data_read(struct file *filp, struct kobject *kobj,
>> @@ -122,12 +131,12 @@ static ssize_t devcd_data_write(struct file *filp, struct kobject *kobj,
>> struct device *dev = kobj_to_dev(kobj);
>> struct devcd_entry *devcd = dev_to_devcd(dev);
>>
>> - mutex_lock(&devcd->mutex);
>> - if (!devcd->delete_work) {
>> - devcd->delete_work = true;
>> - mod_delayed_work(system_wq, &devcd->del_wk, 0);
>> - }
>> - mutex_unlock(&devcd->mutex);
>> + /*
>> + * Although it's tempting to use mod_delayed work here,
>> + * that will cause a reschedule if the timer already fired.
>> + */
>> + if (cancel_delayed_work(&devcd->del_wk))
>> + schedule_delayed_work(&devcd->del_wk, 0);
>>
>> return count;
>> }
>> @@ -151,11 +160,21 @@ static int devcd_free(struct device *dev, void *data)
>> {
>> struct devcd_entry *devcd = dev_to_devcd(dev);
>>
>> + /*
>> + * To prevent a race with devcd_data_write(), disable work and
>> + * complete manually instead.
>> + *
>> + * We cannot rely on the return value of
>> + * disable_delayed_work_sync() here, because it might be in the
>> + * middle of a cancel_delayed_work + schedule_delayed_work pair.
>> + *
>> + * devcd->mutex here guards against multiple parallel invocations
>> + * of devcd_free().
>> + */
>> + disable_delayed_work_sync(&devcd->del_wk);
>> mutex_lock(&devcd->mutex);
>> - if (!devcd->delete_work)
>> - devcd->delete_work = true;
>> -
>> - flush_delayed_work(&devcd->del_wk);
>> + if (!devcd->deleted)
>> + __devcd_del(devcd);
>> mutex_unlock(&devcd->mutex);
>> return 0;
>> }
>> @@ -179,12 +198,10 @@ static ssize_t disabled_show(const struct class *class, const struct class_attri
>> * put_device() <- last reference
>> * error = fn(dev, data) devcd_dev_release()
>> * devcd_free(dev, data) kfree(devcd)
>> - * mutex_lock(&devcd->mutex);
>> *
>> *
>> * In the above diagram, it looks like disabled_store() would be racing with parallelly
>> - * running devcd_del() and result in memory abort while acquiring devcd->mutex which
>> - * is called after kfree of devcd memory after dropping its last reference with
>> + * running devcd_del() and result in memory abort after dropping its last reference with
>> * put_device(). However, this will not happens as fn(dev, data) runs
>> * with its own reference to device via klist_node so it is not its last reference.
>> * so, above situation would not occur.
>> @@ -374,7 +391,7 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
>> devcd->read = read;
>> devcd->free = free;
>> devcd->failing_dev = get_device(dev);
>> - devcd->delete_work = false;
>> + devcd->deleted = false;
>>
>> mutex_init(&devcd->mutex);
>> device_initialize(&devcd->devcd_dev);
>> @@ -383,8 +400,14 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
>> atomic_inc_return(&devcd_count));
>> devcd->devcd_dev.class = &devcd_class;
>>
>> - mutex_lock(&devcd->mutex);
>> dev_set_uevent_suppress(&devcd->devcd_dev, true);
>> +
>> + /* devcd->mutex prevents devcd_del() completing until init finishes */
>> + mutex_lock(&devcd->mutex);
>> + devcd->init_completed = false;
>> + INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
>> + schedule_delayed_work(&devcd->del_wk, timeout);
>> +
>> if (device_add(&devcd->devcd_dev))
>> goto put_device;
>>
>> @@ -401,13 +424,20 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
>>
>> dev_set_uevent_suppress(&devcd->devcd_dev, false);
>> kobject_uevent(&devcd->devcd_dev.kobj, KOBJ_ADD);
>> - INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
>> - schedule_delayed_work(&devcd->del_wk, timeout);
>> +
>> + /*
>> + * Safe to run devcd_del() now that we are done with devcd_dev.
>> + * Alternatively we could have taken a ref on devcd_dev before
>> + * dropping the lock.
>> + */
>> + devcd->init_completed = true;
>> mutex_unlock(&devcd->mutex);
>> return;
>> put_device:
>> - put_device(&devcd->devcd_dev);
>> mutex_unlock(&devcd->mutex);
>> + cancel_delayed_work_sync(&devcd->del_wk);
>> + put_device(&devcd->devcd_dev);
>> +
>
> Acked-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Thanks, through what tree can this be merged?
Kind regards,
~Maarten Lankhorst
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex.
2025-10-06 9:11 ` Maarten Lankhorst
@ 2025-10-06 9:24 ` Greg Kroah-Hartman
0 siblings, 0 replies; 13+ messages in thread
From: Greg Kroah-Hartman @ 2025-10-06 9:24 UTC (permalink / raw)
To: Maarten Lankhorst
Cc: Mukesh Ojha, linux-kernel, intel-xe, Mukesh Ojha, Johannes Berg,
Rafael J. Wysocki, Danilo Krummrich, stable, Matthew Brost
On Mon, Oct 06, 2025 at 11:11:01AM +0200, Maarten Lankhorst wrote:
> >> @@ -401,13 +424,20 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
> >>
> >> dev_set_uevent_suppress(&devcd->devcd_dev, false);
> >> kobject_uevent(&devcd->devcd_dev.kobj, KOBJ_ADD);
> >> - INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
> >> - schedule_delayed_work(&devcd->del_wk, timeout);
> >> +
> >> + /*
> >> + * Safe to run devcd_del() now that we are done with devcd_dev.
> >> + * Alternatively we could have taken a ref on devcd_dev before
> >> + * dropping the lock.
> >> + */
> >> + devcd->init_completed = true;
> >> mutex_unlock(&devcd->mutex);
> >> return;
> >> put_device:
> >> - put_device(&devcd->devcd_dev);
> >> mutex_unlock(&devcd->mutex);
> >> + cancel_delayed_work_sync(&devcd->del_wk);
> >> + put_device(&devcd->devcd_dev);
> >> +
> >
> > Acked-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
>
> Thanks, through what tree can this be merged?
I can look into doing that after -rc1 is out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex.
2025-07-23 14:24 [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex Maarten Lankhorst
` (5 preceding siblings ...)
2025-10-03 18:00 ` Mukesh Ojha
@ 2025-10-24 8:12 ` Johannes Berg
2025-10-24 8:37 ` Maarten Lankhorst
6 siblings, 1 reply; 13+ messages in thread
From: Johannes Berg @ 2025-10-24 8:12 UTC (permalink / raw)
To: Maarten Lankhorst, linux-kernel
Cc: intel-xe, Mukesh Ojha, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, stable, Matthew Brost
On Wed, 2025-07-23 at 16:24 +0200, Maarten Lankhorst wrote:
>
> +static void __devcd_del(struct devcd_entry *devcd)
> +{
> + devcd->deleted = true;
> + device_del(&devcd->devcd_dev);
> + put_device(&devcd->devcd_dev);
> +}
> +
> static void devcd_del(struct work_struct *wk)
> {
> struct devcd_entry *devcd;
> + bool init_completed;
>
> devcd = container_of(wk, struct devcd_entry, del_wk.work);
>
> - device_del(&devcd->devcd_dev);
> - put_device(&devcd->devcd_dev);
> + /* devcd->mutex serializes against dev_coredumpm_timeout */
> + mutex_lock(&devcd->mutex);
> + init_completed = devcd->init_completed;
> + mutex_unlock(&devcd->mutex);
> +
> + if (init_completed)
> + __devcd_del(devcd);
I'm not sure I understand this completely right now. I think you pull
this out of the mutex because otherwise the unlock could/would be UAF,
right?
But also we have this:
> @@ -151,11 +160,21 @@ static int devcd_free(struct device *dev, void *data)
> {
> struct devcd_entry *devcd = dev_to_devcd(dev);
>
> + /*
> + * To prevent a race with devcd_data_write(), disable work and
> + * complete manually instead.
> + *
> + * We cannot rely on the return value of
> + * disable_delayed_work_sync() here, because it might be in the
> + * middle of a cancel_delayed_work + schedule_delayed_work pair.
> + *
> + * devcd->mutex here guards against multiple parallel invocations
> + * of devcd_free().
> + */
> + disable_delayed_work_sync(&devcd->del_wk);
> mutex_lock(&devcd->mutex);
> - if (!devcd->delete_work)
> - devcd->delete_work = true;
> -
> - flush_delayed_work(&devcd->del_wk);
> + if (!devcd->deleted)
> + __devcd_del(devcd);
> mutex_unlock(&devcd->mutex);
^^^^
Which I _think_ is probably OK because devcd_free is only called with an
extra reference held (for each/find device.)
But ... doesn't that then still have unbalanced calls to __devcd_del()
and thus device_del()/put_device()?
CPU 0 CPU 1
dev_coredump_put() devcd_del()
-> devcd_free()
-> locked
-> !deleted
-> __devcd_del()
-> __devcd_del()
no?
johannes
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex.
2025-10-24 8:12 ` Johannes Berg
@ 2025-10-24 8:37 ` Maarten Lankhorst
2025-10-24 8:39 ` Johannes Berg
0 siblings, 1 reply; 13+ messages in thread
From: Maarten Lankhorst @ 2025-10-24 8:37 UTC (permalink / raw)
To: Johannes Berg, linux-kernel
Cc: intel-xe, Mukesh Ojha, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, stable, Matthew Brost
Hey,
Den 2025-10-24 kl. 10:12, skrev Johannes Berg:
> On Wed, 2025-07-23 at 16:24 +0200, Maarten Lankhorst wrote:
>>
>> +static void __devcd_del(struct devcd_entry *devcd)
>> +{
>> + devcd->deleted = true;
>> + device_del(&devcd->devcd_dev);
>> + put_device(&devcd->devcd_dev);
>> +}
>> +
>> static void devcd_del(struct work_struct *wk)
>> {
>> struct devcd_entry *devcd;
>> + bool init_completed;
>>
>> devcd = container_of(wk, struct devcd_entry, del_wk.work);
>>
>> - device_del(&devcd->devcd_dev);
>> - put_device(&devcd->devcd_dev);
>> + /* devcd->mutex serializes against dev_coredumpm_timeout */
>> + mutex_lock(&devcd->mutex);
>> + init_completed = devcd->init_completed;
>> + mutex_unlock(&devcd->mutex);
>> +
>> + if (init_completed)
>> + __devcd_del(devcd);
>
> I'm not sure I understand this completely right now. I think you pull
> this out of the mutex because otherwise the unlock could/would be UAF,
> right?
>
> But also we have this:
>
>> @@ -151,11 +160,21 @@ static int devcd_free(struct device *dev, void *data)
>> {
>> struct devcd_entry *devcd = dev_to_devcd(dev);
>>
>> + /*
>> + * To prevent a race with devcd_data_write(), disable work and
>> + * complete manually instead.
>> + *
>> + * We cannot rely on the return value of
>> + * disable_delayed_work_sync() here, because it might be in the
>> + * middle of a cancel_delayed_work + schedule_delayed_work pair.
>> + *
>> + * devcd->mutex here guards against multiple parallel invocations
>> + * of devcd_free().
>> + */
>> + disable_delayed_work_sync(&devcd->del_wk);
>> mutex_lock(&devcd->mutex);
>> - if (!devcd->delete_work)
>> - devcd->delete_work = true;
>> -
>> - flush_delayed_work(&devcd->del_wk);
>> + if (!devcd->deleted)
>> + __devcd_del(devcd);
>> mutex_unlock(&devcd->mutex);
>
> ^^^^
>
> Which I _think_ is probably OK because devcd_free is only called with an
> extra reference held (for each/find device.)
>
> But ... doesn't that then still have unbalanced calls to __devcd_del()
> and thus device_del()/put_device()?
>
> CPU 0 CPU 1
>
> dev_coredump_put() devcd_del()
> -> devcd_free()
> -> locked
> -> !deleted
> -> __devcd_del()
> -> __devcd_del()
>
> no?
>
> johannes
Yeah don't you love the races in the design? All intricate and subtle.
In this case it's handled by disable_delayed_work_sync(),
which waits for devcd_del() to be completed. devcd_del is called from the workqueue,
and the first step devcd_free does is calling disable_delayed_work_sync, which means
devcd_del() either fully completed or was not run at all.
Best regards,
~Maarten
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex.
2025-10-24 8:37 ` Maarten Lankhorst
@ 2025-10-24 8:39 ` Johannes Berg
2025-10-24 10:27 ` Maarten Lankhorst
0 siblings, 1 reply; 13+ messages in thread
From: Johannes Berg @ 2025-10-24 8:39 UTC (permalink / raw)
To: Maarten Lankhorst, linux-kernel
Cc: intel-xe, Mukesh Ojha, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, stable, Matthew Brost
On Fri, 2025-10-24 at 10:37 +0200, Maarten Lankhorst wrote:
> >
> > CPU 0 CPU 1
> >
> > dev_coredump_put() devcd_del()
> > -> devcd_free()
> > -> locked
> > -> !deleted
> > -> __devcd_del()
> > -> __devcd_del()
> >
> > no?
> >
> > johannes
>
>
> Yeah don't you love the races in the design? All intricate and subtle.
:)
> In this case it's handled by disable_delayed_work_sync(),
> which waits for devcd_del() to be completed. devcd_del is called from the workqueue,
> and the first step devcd_free does is calling disable_delayed_work_sync, which means
> devcd_del() either fully completed or was not run at all.
Oh... right, I totally missed the _sync. My bad, sorry.
I guess I really should say
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
since I finally _did_ review it carefully. Sorry it took forever.
johannes
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex.
2025-10-24 8:39 ` Johannes Berg
@ 2025-10-24 10:27 ` Maarten Lankhorst
0 siblings, 0 replies; 13+ messages in thread
From: Maarten Lankhorst @ 2025-10-24 10:27 UTC (permalink / raw)
To: Johannes Berg, linux-kernel
Cc: intel-xe, Mukesh Ojha, Greg Kroah-Hartman, Rafael J. Wysocki,
Danilo Krummrich, stable, Matthew Brost
Hey,
Den 2025-10-24 kl. 10:39, skrev Johannes Berg:
> On Fri, 2025-10-24 at 10:37 +0200, Maarten Lankhorst wrote:
>>>
>>> CPU 0 CPU 1
>>>
>>> dev_coredump_put() devcd_del()
>>> -> devcd_free()
>>> -> locked
>>> -> !deleted
>>> -> __devcd_del()
>>> -> __devcd_del()
>>>
>>> no?
>>>
>>> johannes
>>
>>
>> Yeah don't you love the races in the design? All intricate and subtle.
>
> :)
>
>> In this case it's handled by disable_delayed_work_sync(),
>> which waits for devcd_del() to be completed. devcd_del is called from the workqueue,
>> and the first step devcd_free does is calling disable_delayed_work_sync, which means
>> devcd_del() either fully completed or was not run at all.
>
> Oh... right, I totally missed the _sync. My bad, sorry.
>
> I guess I really should say
>
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
>
> since I finally _did_ review it carefully. Sorry it took forever.
>
> johannes
No worries. It's an extremely tricky and prone to races part of code especially with the various ways a coredump can be destroyed.
I almost replied with another potential bug, calling read() after calling write(), but that's worked around by the reference
kept on the devcd device.
Kind regards,
~Maarten Lankhorst
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2025-10-24 10:27 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-23 14:24 [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex Maarten Lankhorst
2025-07-23 17:53 ` ✗ CI.checkpatch: warning for devcoredump: Fix circular locking dependency with devcd->mutex. (rev3) Patchwork
2025-07-23 17:54 ` ✓ CI.KUnit: success " Patchwork
2025-07-23 19:20 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-24 2:54 ` ✗ Xe.CI.Full: failure " Patchwork
2025-10-03 13:29 ` [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex Maarten Lankhorst
2025-10-03 18:00 ` Mukesh Ojha
2025-10-06 9:11 ` Maarten Lankhorst
2025-10-06 9:24 ` Greg Kroah-Hartman
2025-10-24 8:12 ` Johannes Berg
2025-10-24 8:37 ` Maarten Lankhorst
2025-10-24 8:39 ` Johannes Berg
2025-10-24 10:27 ` Maarten Lankhorst
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox