From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 6/8] drm/i915: Remove pointless crtc hw.enable check
Date: Fri, 10 Oct 2025 00:13:10 +0300 [thread overview]
Message-ID: <20251009211313.30234-7-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20251009211313.30234-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We don't need to check for crtc hw.enable because that would also
imply that the plane is disabled and we would have bailed out already
earlier.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 8ead07b4b7a7..64b30fad75ee 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -1755,8 +1755,7 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
}
/* Y-tiling is not supported in IF-ID Interlace mode */
- if (crtc_state->hw.enable &&
- crtc_state->hw.adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE &&
+ if (crtc_state->hw.adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE &&
fb->modifier != DRM_FORMAT_MOD_LINEAR &&
fb->modifier != I915_FORMAT_MOD_X_TILED) {
drm_dbg_kms(display->drm,
--
2.49.1
next prev parent reply other threads:[~2025-10-09 21:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 21:13 [PATCH 0/8] drm/i915: Some universal plane fixes and cleanups Ville Syrjala
2025-10-09 21:13 ` [PATCH 1/8] drm/i915: Rewrite icl_min_plane_width() Ville Syrjala
2025-10-09 21:13 ` [PATCH 2/8] drm/i915: Drop the min plane width w/a adl+ Ville Syrjala
2025-10-09 22:38 ` Matt Roper
2025-10-10 23:33 ` Ville Syrjälä
2025-10-09 21:13 ` [PATCH 3/8] drm/i915: Implement .min_plane_width() for PTL+ Ville Syrjala
2025-10-09 21:13 ` [PATCH 4/8] drm/i915: Start checking plane min size for the chroma plane Ville Syrjala
2025-10-09 21:13 ` [PATCH 5/8] drm/i915: Introduce intel_plane_min_height() Ville Syrjala
2025-10-09 21:13 ` Ville Syrjala [this message]
2025-10-09 21:13 ` [PATCH 7/8] drm/i915: Extract glk_plane_has_planar() Ville Syrjala
2025-10-09 21:13 ` [PATCH 8/8] drm/i915: Unify the logic in {skl,glk}_plane_has_*() Ville Syrjala
2025-10-09 21:37 ` ✓ CI.KUnit: success for drm/i915: Some universal plane fixes and cleanups Patchwork
2025-10-09 22:23 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-10 6:33 ` ✗ Xe.CI.Full: failure " Patchwork
2025-10-28 9:36 ` [PATCH 0/8] " Juha-Pekka Heikkilä
2025-10-28 20:58 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251009211313.30234-7-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox