From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 20/22] drm/i915/vrr: Nuke intel_vrr_vmin_flipline()
Date: Mon, 20 Oct 2025 21:50:36 +0300 [thread overview]
Message-ID: <20251020185038.4272-21-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20251020185038.4272-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Now that intel_vrr_flipline_offset() is completely hidden from the
higher level VRR code, intel_vrr_vmin_flipline() has become rather
pointless. Remove it.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_vrr.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index ba92e0a76855..8875e5fe86aa 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -108,11 +108,6 @@ static int intel_vrr_vmin_flipline_offset(struct intel_display *display)
return DISPLAY_VER(display) < 13 ? 1 : 0;
}
-static int intel_vrr_vmin_flipline(const struct intel_crtc_state *crtc_state)
-{
- return crtc_state->vrr.vmin;
-}
-
static int intel_vrr_guardband_to_pipeline_full(const struct intel_crtc_state *crtc_state,
int guardband)
{
@@ -147,7 +142,7 @@ static int intel_vrr_pipeline_full_to_guardband(const struct intel_crtc_state *c
int intel_vrr_vmin_vtotal(const struct intel_crtc_state *crtc_state)
{
/* Min vblank actually determined by flipline */
- return intel_vrr_vmin_flipline(crtc_state);
+ return crtc_state->vrr.vmin;
}
int intel_vrr_vmax_vtotal(const struct intel_crtc_state *crtc_state)
@@ -781,7 +776,7 @@ bool intel_vrr_is_fixed_rr(const struct intel_crtc_state *crtc_state)
{
return crtc_state->vrr.flipline &&
crtc_state->vrr.flipline == crtc_state->vrr.vmax &&
- crtc_state->vrr.flipline == intel_vrr_vmin_flipline(crtc_state);
+ crtc_state->vrr.flipline == crtc_state->vrr.vmin;
}
void intel_vrr_get_config(struct intel_crtc_state *crtc_state)
--
2.49.1
next prev parent reply other threads:[~2025-10-20 18:52 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 18:50 [PATCH 00/22] drm/i915/vrr: A few fixes and a bunch of cleanup Ville Syrjala
2025-10-20 18:50 ` [PATCH 01/22] drm/i915/vrr: Fix intel_vrr_always_use_vrr_tg()==true on TGL Ville Syrjala
2025-10-24 13:24 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 02/22] drm/i915/lrr: Include SCL in lrr_params_changed() Ville Syrjala
2025-10-24 13:25 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 03/22] drm/i915: Remove the "vblank delay" state dump Ville Syrjala
2025-10-24 13:26 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 04/22] drm/i915/vrr: Compute fixed refresh rate timings the sam way as CMRR timings Ville Syrjala
2025-10-24 13:27 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 05/22] drm/i915/vrr: Reorganize intel_vrr_compute_cmrr_timings() a bit Ville Syrjala
2025-10-24 13:28 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 06/22] drm/i195/vrr: Move crtc_state->vrr.{vmin, vmax} update into intel_vrr_compute_vrr_timings() Ville Syrjala
2025-10-24 13:28 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 07/22] drm/i915/vrr: Move compute_fixed_rr_timings() Ville Syrjala
2025-10-24 13:29 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 08/22] drm/i915/vrr: Extract intel_vrr_set_vrr_timings() Ville Syrjala
2025-10-24 13:30 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 09/22] drm/i915/vrr: Avoid redundant TRANS_PUSH write in intel_vrr_enable() Ville Syrjala
2025-10-24 13:30 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 10/22] drm/i915/vrr: Move EMP_AS_SDP_TL write into intel_vrr_set_transcoder_timings() Ville Syrjala
2025-10-24 13:39 ` Nautiyal, Ankit K
2025-10-24 13:51 ` Ville Syrjälä
2025-10-20 18:50 ` [PATCH 11/22] drm/i915/vrr: Use trans_vrr_ctl() in intel_vrr_transcoder_disable() Ville Syrjala
2025-10-24 13:45 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 12/22] drm/i915/vrr: Extract intel_vrr_tg_disable() Ville Syrjala
2025-10-24 13:45 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 13/22] drm/i915/vrr: Extract intel_vrr_tg_enable() Ville Syrjala
2025-10-24 14:10 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 14/22] drm/i915/vrr: Disable VRR TG in intel_vrr_transcoder_disable() only on always use_vrr_tg() platforms Ville Syrjala
2025-10-24 14:10 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 15/22] drm/i915/vrr: Always write TRANS_VRR_CTL in intel_vrr_set_transcoder_timings() on !always_use_vrr_tg() Ville Syrjala
2025-10-24 14:11 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 16/22] drm/i915/vrr: Remove redundant HAS_VRR() checks Ville Syrjala
2025-10-24 14:12 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 17/22] drm/i915/vrr: Move HAS_VRR() check into intel_vrr_set_transcoder_timings() Ville Syrjala
2025-10-24 14:14 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 18/22] drm/i915/vrr: s/crtc_state/old_crtc_state/ in intel_vrr_transcoder_disable() Ville Syrjala
2025-10-24 14:17 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 19/22] drm/i915/vrr: Nuke intel_vrr_vblank_exit_length() Ville Syrjala
2025-10-24 14:18 ` Nautiyal, Ankit K
2025-10-20 18:50 ` Ville Syrjala [this message]
2025-10-24 14:20 ` [PATCH 20/22] drm/i915/vrr: Nuke intel_vrr_vmin_flipline() Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 21/22] drm/i915/vrr: Update the intel_vrr_extra_vblank_delay() comment Ville Syrjala
2025-10-24 14:21 ` Nautiyal, Ankit K
2025-10-20 18:50 ` [PATCH 22/22] drm/i915/vrr: Check HAS_VRR() first in intel_vrr_is_capable() Ville Syrjala
2025-10-24 14:23 ` Nautiyal, Ankit K
2025-10-21 7:48 ` ✓ CI.KUnit: success for drm/i915/vrr: A few fixes and a bunch of cleanup Patchwork
2025-10-21 8:21 ` [PATCH 00/22] " Jani Nikula
2025-10-21 10:44 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-10-21 11:40 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020185038.4272-21-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox