Re: [PATCH 11/22] drm/i915/vrr: Use trans_vrr_ctl() in intel_vrr_transcoder_disable()

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 10/21/2025 12:20 AM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Currently intel_vrr_disable() writes TRANS_VRR_CTL() with
> trans_vrr_ctl(), whereas intel_vrr_transcoder_disable() always
> writes just a plain 0. Write trans_vrr_ctl() in both places to
> unify the code, allowing for more shared code in the future.
>
> Since the VRR timing generator will be disabled by the
> TRANS_VRR_CTL write it doesn't really matter what we write to
> the register (other than VRR_CTL_VRR_ENABLE that is).
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


> ---
>   drivers/gpu/drm/i915/display/intel_vrr.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
> index 562a5feadaab..19b38ad77189 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -779,7 +779,8 @@ void intel_vrr_transcoder_disable(const struct intel_crtc_state *crtc_state)
>   	if (!intel_vrr_possible(crtc_state))
>   		return;
>   
> -	intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder), 0);
> +	intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder),
> +		       trans_vrr_ctl(crtc_state));
>   
>   	intel_vrr_wait_for_live_status_clear(display, cpu_transcoder);
>