Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH 1/3] drm/xe: Check return value of GGTT workqueue allocation
Date: Tue, 21 Oct 2025 17:55:36 -0700	[thread overview]
Message-ID: <20251022005538.828980-2-matthew.brost@intel.com> (raw)
In-Reply-To: <20251022005538.828980-1-matthew.brost@intel.com>

Workqueue allocation can fail, so check the return value of the GGTT
workqueue allocation and fail driver initialization if the allocation
fails.

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: stable@vger.kernel.org
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_ggtt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
index 40680f0c49a1..20d226d90c50 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.c
+++ b/drivers/gpu/drm/xe/xe_ggtt.c
@@ -312,6 +312,9 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
 		ggtt->pt_ops = &xelp_pt_ops;
 
 	ggtt->wq = alloc_workqueue("xe-ggtt-wq", 0, WQ_MEM_RECLAIM);
+	if (!ggtt->wq)
+		return -ENOMEM;
+
 	__xe_ggtt_init_early(ggtt, xe_wopcm_size(xe));
 
 	err = drmm_add_action_or_reset(&xe->drm, ggtt_fini_early, ggtt);
-- 
2.34.1


  reply	other threads:[~2025-10-22  0:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22  0:55 [PATCH 0/3] Fix low hanging workqueue / reclaim issues Matthew Brost
2025-10-22  0:55 ` Matthew Brost [this message]
2025-10-22  9:54   ` [PATCH 1/3] drm/xe: Check return value of GGTT workqueue allocation Matthew Auld
2025-10-22  0:55 ` [PATCH 2/3] drm/xe: Do not wake device during a GT reset Matthew Brost
2025-10-22 10:03   ` Matthew Auld
2025-10-22  0:55 ` [PATCH 3/3] drm/xe: Avoid PM wake reference during VF migration Matthew Brost
2025-10-22 10:08   ` Matthew Auld
2025-10-22  2:32 ` ✓ CI.KUnit: success for Fix low hanging workqueue / reclaim issues Patchwork
2025-10-22  4:20 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-22  6:24 ` ✓ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251022005538.828980-2-matthew.brost@intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox