Re: [PATCH 1/3] drm/xe: Check return value of GGTT workqueue allocation

[Matthew Auld <matthew.auld@intel.com>]

On 22/10/2025 01:55, Matthew Brost wrote:
> Workqueue allocation can fail, so check the return value of the GGTT
> workqueue allocation and fail driver initialization if the allocation
> fails.
> 
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> Cc: stable@vger.kernel.org
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Auld <matthew.auld@intel.com>


> ---
>   drivers/gpu/drm/xe/xe_ggtt.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
> index 40680f0c49a1..20d226d90c50 100644
> --- a/drivers/gpu/drm/xe/xe_ggtt.c
> +++ b/drivers/gpu/drm/xe/xe_ggtt.c
> @@ -312,6 +312,9 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
>   		ggtt->pt_ops = &xelp_pt_ops;
>   
>   	ggtt->wq = alloc_workqueue("xe-ggtt-wq", 0, WQ_MEM_RECLAIM);
> +	if (!ggtt->wq)
> +		return -ENOMEM;
> +
>   	__xe_ggtt_init_early(ggtt, xe_wopcm_size(xe));
>   
>   	err = drmm_add_action_or_reset(&xe->drm, ggtt_fini_early, ggtt);