From: Zhanjun Dong <zhanjun.dong@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: daniele.ceraolospurio@intel.com, ashutosh.dixit@intel.com,
Zhanjun Dong <zhanjun.dong@intel.com>
Subject: [PATCH v2] drm/xe/uc: Change assertion to error on huc authentication failure
Date: Fri, 24 Oct 2025 15:19:59 -0400 [thread overview]
Message-ID: <20251024191959.2555145-1-zhanjun.dong@intel.com> (raw)
The fault injection test can cause the xe_huc_auth function to fail.
This is an intentional failure, so in this scenario we don't want to
throw an assert and taint the kernel, because that will impact CI
execution.
Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
History:
v2: Update commit comments (Daniele Ceraolo Spurio)
Remove warning comment (Dixit, Ashutosh)
---
drivers/gpu/drm/xe/xe_uc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
index 465bda355443..c94b828cc24f 100644
--- a/drivers/gpu/drm/xe/xe_uc.c
+++ b/drivers/gpu/drm/xe/xe_uc.c
@@ -218,9 +218,9 @@ int xe_uc_load_hw(struct xe_uc *uc)
xe_guc_engine_activity_enable_stats(&uc->guc);
- /* We don't fail the driver load if HuC fails to auth, but let's warn */
+ /* We don't fail the driver load if HuC fails to auth */
ret = xe_huc_auth(&uc->huc, XE_HUC_AUTH_VIA_GUC);
- xe_gt_assert(uc_to_gt(uc), !ret);
+ xe_gt_err(uc_to_gt(uc), "Huc authentication failed:%d\n", ret);
/* GSC load is async */
xe_gsc_load_start(&uc->gsc);
--
2.34.1
next reply other threads:[~2025-10-24 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 19:19 Zhanjun Dong [this message]
2025-10-24 19:27 ` ✓ CI.KUnit: success for drm/xe/uc: Change assertion to error on huc authentication failure (rev2) Patchwork
2025-10-24 20:05 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-10-24 21:49 ` [PATCH v2] drm/xe/uc: Change assertion to error on huc authentication failure Michal Wajdeczko
2025-10-24 22:09 ` Dong, Zhanjun
2025-10-25 7:24 ` ✗ Xe.CI.Full: failure for drm/xe/uc: Change assertion to error on huc authentication failure (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024191959.2555145-1-zhanjun.dong@intel.com \
--to=zhanjun.dong@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox