Re: [PATCH v2] drm/xe/uc: Change assertion to error on huc authentication failure

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 10/24/2025 9:19 PM, Zhanjun Dong wrote:
> The fault injection test can cause the xe_huc_auth function to fail.
> This is an intentional failure, so in this scenario we don't want to
> throw an assert and taint the kernel, because that will impact CI
> execution.
> 
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> ---
> History:
> v2: Update commit comments (Daniele Ceraolo Spurio)
>     Remove warning comment (Dixit, Ashutosh)
> ---
>  drivers/gpu/drm/xe/xe_uc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
> index 465bda355443..c94b828cc24f 100644
> --- a/drivers/gpu/drm/xe/xe_uc.c
> +++ b/drivers/gpu/drm/xe/xe_uc.c
> @@ -218,9 +218,9 @@ int xe_uc_load_hw(struct xe_uc *uc)
>  
>  	xe_guc_engine_activity_enable_stats(&uc->guc);
>  
> -	/* We don't fail the driver load if HuC fails to auth, but let's warn */
> +	/* We don't fail the driver load if HuC fails to auth */
>  	ret = xe_huc_auth(&uc->huc, XE_HUC_AUTH_VIA_GUC);
> -	xe_gt_assert(uc_to_gt(uc), !ret);
> +	xe_gt_err(uc_to_gt(uc), "Huc authentication failed:%d\n", ret);

s/Huc/HuC

this will always print an error message, also for success:

	*ERROR* HuC authentication failed:0

and in case of real error it will be redundant since in xe_huc.c we already print similar messages

maybe just say that we acknowledge that HuC error (printed in a friendly way)
and that we decided to move on:

	if (ret)
		xe_gt_notice(gt, "Continuing with no HuC (%pe)\n", ERR_PTR(ret)


>  
>  	/* GSC load is async */
>  	xe_gsc_load_start(&uc->gsc);