Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/xe/uc: Change assertion to error on huc authentication failure
@ 2025-10-24 19:19 Zhanjun Dong
  2025-10-24 19:27 ` ✓ CI.KUnit: success for drm/xe/uc: Change assertion to error on huc authentication failure (rev2) Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Zhanjun Dong @ 2025-10-24 19:19 UTC (permalink / raw)
  To: intel-xe; +Cc: daniele.ceraolospurio, ashutosh.dixit, Zhanjun Dong

The fault injection test can cause the xe_huc_auth function to fail.
This is an intentional failure, so in this scenario we don't want to
throw an assert and taint the kernel, because that will impact CI
execution.

Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
History:
v2: Update commit comments (Daniele Ceraolo Spurio)
    Remove warning comment (Dixit, Ashutosh)
---
 drivers/gpu/drm/xe/xe_uc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
index 465bda355443..c94b828cc24f 100644
--- a/drivers/gpu/drm/xe/xe_uc.c
+++ b/drivers/gpu/drm/xe/xe_uc.c
@@ -218,9 +218,9 @@ int xe_uc_load_hw(struct xe_uc *uc)
 
 	xe_guc_engine_activity_enable_stats(&uc->guc);
 
-	/* We don't fail the driver load if HuC fails to auth, but let's warn */
+	/* We don't fail the driver load if HuC fails to auth */
 	ret = xe_huc_auth(&uc->huc, XE_HUC_AUTH_VIA_GUC);
-	xe_gt_assert(uc_to_gt(uc), !ret);
+	xe_gt_err(uc_to_gt(uc), "Huc authentication failed:%d\n", ret);
 
 	/* GSC load is async */
 	xe_gsc_load_start(&uc->gsc);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-10-25  7:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-24 19:19 [PATCH v2] drm/xe/uc: Change assertion to error on huc authentication failure Zhanjun Dong
2025-10-24 19:27 ` ✓ CI.KUnit: success for drm/xe/uc: Change assertion to error on huc authentication failure (rev2) Patchwork
2025-10-24 20:05 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-10-24 21:49 ` [PATCH v2] drm/xe/uc: Change assertion to error on huc authentication failure Michal Wajdeczko
2025-10-24 22:09   ` Dong, Zhanjun
2025-10-25  7:24 ` ✗ Xe.CI.Full: failure for drm/xe/uc: Change assertion to error on huc authentication failure (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox