From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jouni.hogander@intel.com, ville.syrjala@linux.intel.com,
Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 2/3] drm/i915/dp: Allow AS_SDP only if panel replay + auxless alpm is supported
Date: Tue, 28 Oct 2025 10:05:01 +0530 [thread overview]
Message-ID: <20251028043502.2977803-3-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20251028043502.2977803-1-ankit.k.nautiyal@intel.com>
Adaptive Sync SDP is required when Panel replay is active and for
supporting VRR on PCON.
Since VRR on PCON still needs some effort, enable adaptive sync SDP only
when Panel replay with ALPM-Auxless is supported.
Set the AS_SDP mode for Fixed Vtotal mode for fixed refresh rate case.
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index ee113e118fed..8583cab37123 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2934,7 +2934,15 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
const struct drm_display_mode *adjusted_mode =
&crtc_state->hw.adjusted_mode;
- if (!crtc_state->vrr.enable || !intel_dp->as_sdp_supported)
+ if (!intel_dp->as_sdp_supported)
+ return;
+
+ /*
+ * Support Adaptive-Sync SDP only for PR+AUX-less ALPM for now.
+ * It can be enabled for PCON + VRR, but that is currently not supported.
+ */
+ if (!CAN_PANEL_REPLAY(intel_dp) ||
+ !intel_alpm_aux_less_wake_supported(intel_dp))
return;
crtc_state->infoframes.enable |= intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC);
@@ -2948,9 +2956,12 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
as_sdp->mode = DP_AS_SDP_FAVT_TRR_REACHED;
as_sdp->target_rr = drm_mode_vrefresh(adjusted_mode);
as_sdp->target_rr_divider = true;
- } else {
+ } else if (crtc_state->vrr.enable) {
as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL;
as_sdp->target_rr = 0;
+ } else {
+ as_sdp->mode = DP_AS_SDP_AVT_FIXED_VTOTAL;
+ as_sdp->target_rr = 0;
}
}
--
2.45.2
next prev parent reply other threads:[~2025-10-28 4:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 4:34 [PATCH 0/3] Fix Adaptive Sync SDP for Panel Replay Ankit Nautiyal
2025-10-28 4:35 ` [PATCH 1/3] drm/i915/dp: Move computation of as_sdp_after psr and lobf Ankit Nautiyal
2025-10-28 15:23 ` Ville Syrjälä
2025-10-28 4:35 ` Ankit Nautiyal [this message]
2025-10-28 15:42 ` [PATCH 2/3] drm/i915/dp: Allow AS_SDP only if panel replay + auxless alpm is supported Ville Syrjälä
2025-10-28 4:35 ` [PATCH 3/3] drm/i915/display: Take into account AS SDP in intel_dp_sdp_min_guardband Ankit Nautiyal
2025-10-28 4:55 ` ✓ CI.KUnit: success for Fix Adaptive Sync SDP for Panel Replay Patchwork
2025-10-28 5:33 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-28 10:25 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028043502.2977803-3-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox