Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	jouni.hogander@intel.com
Subject: Re: [PATCH 1/3] drm/i915/dp: Move computation of as_sdp_after psr and lobf
Date: Tue, 28 Oct 2025 17:23:51 +0200	[thread overview]
Message-ID: <aQDgB9k8YlGTTyKQ@intel.com> (raw)
In-Reply-To: <20251028043502.2977803-2-ankit.k.nautiyal@intel.com>

On Tue, Oct 28, 2025 at 10:05:00AM +0530, Ankit Nautiyal wrote:
> To configure adaptive-sync SDP for Panel replay and LOBF features, move
> the intel_dp_compute_as_sdp() after configuration for PSR/PR and LOBF.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 475518b4048b..ee113e118fed 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3413,9 +3413,9 @@ intel_dp_compute_config(struct intel_encoder *encoder,
>  		pipe_config->dp_m_n.data_m *= pipe_config->splitter.link_count;
>  
>  	intel_vrr_compute_config(pipe_config, conn_state);
> -	intel_dp_compute_as_sdp(intel_dp, pipe_config);
>  	intel_psr_compute_config(intel_dp, pipe_config, conn_state);
>  	intel_alpm_lobf_compute_config(intel_dp, pipe_config, conn_state);

Looks like intel_alpm_lobf_compute_config() still has some nonsense
SCL/guardband stuff in it. Someone needs to take a good look at it
and figure out how to fix it.

> +	intel_dp_compute_as_sdp(intel_dp, pipe_config);
>  	intel_dp_drrs_compute_config(connector, pipe_config, link_bpp_x16);
>  	intel_dp_compute_vsc_sdp(intel_dp, pipe_config, conn_state);
>  	intel_dp_compute_hdr_metadata_infoframe_sdp(intel_dp, pipe_config, conn_state);
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2025-10-28 15:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28  4:34 [PATCH 0/3] Fix Adaptive Sync SDP for Panel Replay Ankit Nautiyal
2025-10-28  4:35 ` [PATCH 1/3] drm/i915/dp: Move computation of as_sdp_after psr and lobf Ankit Nautiyal
2025-10-28 15:23   ` Ville Syrjälä [this message]
2025-10-28  4:35 ` [PATCH 2/3] drm/i915/dp: Allow AS_SDP only if panel replay + auxless alpm is supported Ankit Nautiyal
2025-10-28 15:42   ` Ville Syrjälä
2025-10-28  4:35 ` [PATCH 3/3] drm/i915/display: Take into account AS SDP in intel_dp_sdp_min_guardband Ankit Nautiyal
2025-10-28  4:55 ` ✓ CI.KUnit: success for Fix Adaptive Sync SDP for Panel Replay Patchwork
2025-10-28  5:33 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-28 10:25 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQDgB9k8YlGTTyKQ@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox