Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Dump PAT entries with reserved mark
@ 2025-10-22 21:55 Xin Wang
  2025-10-22 22:09 ` Wang, X
                   ` (12 more replies)
  0 siblings, 13 replies; 23+ messages in thread
From: Xin Wang @ 2025-10-22 21:55 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.d.roper, shuicheng.lin, Xin Wang

Add a marker * in the PAT dump output to indicate reserved entries
more clearly. This improves debugging and makes register inspection
easier to understand.

Signed-off-by: Xin Wang <x.wang@intel.com>
---
 drivers/gpu/drm/xe/xe_pat.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_pat.c b/drivers/gpu/drm/xe/xe_pat.c
index 7649b554942a..82c221aacebf 100644
--- a/drivers/gpu/drm/xe/xe_pat.c
+++ b/drivers/gpu/drm/xe/xe_pat.c
@@ -376,14 +376,14 @@ static int xe2_dump(struct xe_gt *gt, struct drm_printer *p)
 		else
 			pat = xe_gt_mcr_unicast_read_any(gt, XE_REG_MCR(_PAT_INDEX(i)));
 
-		drm_printf(p, "PAT[%2d] = [ %u, %u, %u, %u, %u, %u ]  (%#8x)\n", i,
+		drm_printf(p, "PAT[%2d] = [ %u, %u, %u, %u, %u, %u ]  (%#8x)%s\n", i,
 			   !!(pat & XE2_NO_PROMOTE),
 			   !!(pat & XE2_COMP_EN),
 			   REG_FIELD_GET(XE2_L3_CLOS, pat),
 			   REG_FIELD_GET(XE2_L3_POLICY, pat),
 			   REG_FIELD_GET(XE2_L4_POLICY, pat),
 			   REG_FIELD_GET(XE2_COH_MODE, pat),
-			   pat);
+			   pat, xe->pat.table[i].coh_mode ? "" : " *");
 	}
 
 	/*
@@ -431,13 +431,13 @@ static int xe3p_xpc_dump(struct xe_gt *gt, struct drm_printer *p)
 	for (i = 0; i < xe->pat.n_entries; i++) {
 		pat = xe_gt_mcr_unicast_read_any(gt, XE_REG_MCR(_PAT_INDEX(i)));
 
-		drm_printf(p, "PAT[%2d] = [ %u, %u, %u, %u, %u ]  (%#8x)\n", i,
+		drm_printf(p, "PAT[%2d] = [ %u, %u, %u, %u, %u ]  (%#8x)%s\n", i,
 			   !!(pat & XE2_NO_PROMOTE),
 			   REG_FIELD_GET(XE2_L3_CLOS, pat),
 			   REG_FIELD_GET(XE2_L3_POLICY, pat),
 			   REG_FIELD_GET(XE2_L4_POLICY, pat),
 			   REG_FIELD_GET(XE2_COH_MODE, pat),
-			   pat);
+			   pat, xe->pat.table[i].coh_mode ? "" : " *");
 	}
 
 	/*
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2025-10-31 15:49 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-22 21:55 [PATCH] drm/xe: Dump PAT entries with reserved mark Xin Wang
2025-10-22 22:09 ` Wang, X
2025-10-29 19:48   ` Matt Roper
2025-10-29 21:28     ` Wang, X
2025-10-29 21:39       ` Matt Roper
2025-10-23  1:50 ` ✓ CI.KUnit: success for " Patchwork
2025-10-23  2:28 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-23  9:07 ` ✗ Xe.CI.Full: failure " Patchwork
2025-10-29 23:39 ` [PATCH v2] drm/xe: highlight reserved PAT entries in dump output Xin Wang
2025-10-30 16:35   ` Matt Roper
2025-10-30 19:55     ` Wang, X
2025-10-30 20:13       ` Matt Roper
2025-10-30 20:38         ` Wang, X
2025-10-30 16:15 ` Xin Wang
2025-10-30 18:31 ` ✓ CI.KUnit: success for drm/xe: Dump PAT entries with reserved mark (rev2) Patchwork
2025-10-30 19:09 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-30 22:17 ` [PATCH v3] drm/xe: highlight reserved PAT entries in dump output Xin Wang
2025-10-30 22:30   ` Matt Roper
2025-10-31  0:40 ` ✗ Xe.CI.Full: failure for drm/xe: Dump PAT entries with reserved mark (rev2) Patchwork
2025-10-31  1:14 ` ✓ CI.KUnit: success for drm/xe: Dump PAT entries with reserved mark (rev3) Patchwork
2025-10-31  2:04 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-31 11:04 ` ✓ Xe.CI.Full: " Patchwork
2025-10-31 15:49   ` Matt Roper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox