From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Cc: jani.nikula@intel.com, "Animesh Manna" <animesh.manna@intel.com>,
"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v2 06/10] drm/i915/alpm: Half LFPS cycle calculation
Date: Tue, 4 Nov 2025 03:39:53 +0530 [thread overview]
Message-ID: <20251103220957.1229608-7-animesh.manna@intel.com> (raw)
In-Reply-To: <20251103220957.1229608-1-animesh.manna@intel.com>
Add support for half LFPS cycle calculation for DP2.1 ALPM as dependent
parameters got changed.
v1: Initial version.
v2: Avoid returning early. [Jani]
Cc: Jouni Högander <jouni.hogander@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
drivers/gpu/drm/i915/display/intel_alpm.c | 38 +++++++++++++++--------
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index 5686064def8d..97813ce2d4d0 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -57,31 +57,43 @@ static int get_silence_period_symbols(const struct intel_crtc_state *crtc_state)
1000 / 1000;
}
-static void get_lfps_cycle_min_max_time(const struct intel_crtc_state *crtc_state,
+static void get_lfps_cycle_min_max_time(struct intel_dp *intel_dp,
+ const struct intel_crtc_state *crtc_state,
int *min, int *max)
{
- if (crtc_state->port_clock < 540000) {
- *min = 65 * LFPS_CYCLE_COUNT;
- *max = 75 * LFPS_CYCLE_COUNT;
+ struct intel_display *display = to_intel_display(intel_dp);
+
+ if (intel_dp_is_edp(intel_dp)) {
+ if (crtc_state->port_clock < 540000) {
+ *min = DISPLAY_VER(display) < 35 ? 65 * LFPS_CYCLE_COUNT : 140;
+ *max = DISPLAY_VER(display) < 35 ? 75 * LFPS_CYCLE_COUNT : 800;
+ } else {
+ *min = 140;
+ *max = 800;
+ }
} else {
- *min = 140;
- *max = 800;
+ *min = 320;
+ *max = 1600;
+ return;
}
}
-static int get_lfps_cycle_time(const struct intel_crtc_state *crtc_state)
+static int get_lfps_cycle_time(struct intel_dp *intel_dp,
+ const struct intel_crtc_state *crtc_state)
{
int tlfps_cycle_min, tlfps_cycle_max;
- get_lfps_cycle_min_max_time(crtc_state, &tlfps_cycle_min,
+ get_lfps_cycle_min_max_time(intel_dp, crtc_state, &tlfps_cycle_min,
&tlfps_cycle_max);
return tlfps_cycle_min + (tlfps_cycle_max - tlfps_cycle_min) / 2;
}
-static int get_lfps_half_cycle_clocks(const struct intel_crtc_state *crtc_state)
+static int get_lfps_half_cycle_clocks(struct intel_dp *intel_dp,
+ const struct intel_crtc_state *crtc_state)
{
- return get_lfps_cycle_time(crtc_state) * crtc_state->port_clock / 1000 /
+ return get_lfps_cycle_time(intel_dp, crtc_state) *
+ crtc_state->port_clock / 1000 /
1000 / (2 * LFPS_CYCLE_COUNT);
}
@@ -112,7 +124,7 @@ static int get_establishment_period(struct intel_dp *intel_dp,
if (lttpr_count) {
int tlw = 13000;
int tcs = 10000;
- int tlfps_period = get_lfps_cycle_time(crtc_state);
+ int tlfps_period = get_lfps_cycle_time(intel_dp, crtc_state);
int tdcs = (SILENCE_PERIOD_TIME + t1 + tcs +
(lttpr_count - 1) * (tlw + tlfps_period));
int tacds = 70000;
@@ -171,7 +183,7 @@ static int _lnl_compute_aux_less_wake_time(struct intel_dp *intel_dp,
int establishment_period = get_establishment_period(intel_dp, crtc_state);
int switch_to_active = get_switch_to_active(crtc_state);
- return DIV_ROUND_UP(tphy2_p2_to_p0 + get_lfps_cycle_time(crtc_state) +
+ return DIV_ROUND_UP(tphy2_p2_to_p0 + get_lfps_cycle_time(intel_dp, crtc_state) +
establishment_period + switch_to_active, 1000);
}
@@ -189,7 +201,7 @@ _lnl_compute_aux_less_alpm_params(struct intel_dp *intel_dp,
aux_less_wake_time);
silence_period = get_silence_period_symbols(crtc_state);
- lfps_half_cycle = get_lfps_half_cycle_clocks(crtc_state);
+ lfps_half_cycle = get_lfps_half_cycle_clocks(intel_dp, crtc_state);
if (aux_less_wake_lines > ALPM_CTL_AUX_LESS_WAKE_TIME_MASK ||
silence_period > PORT_ALPM_CTL_SILENCE_PERIOD_MASK ||
--
2.29.0
next prev parent reply other threads:[~2025-11-03 22:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 22:09 [PATCH v2 00/10] Enable DP2.1 alpm Animesh Manna
2025-11-03 22:09 ` [PATCH v2 01/10] drm/i915/alpm: Add dpcd definition for DP2.1 alpm capability Animesh Manna
2025-11-04 4:01 ` Kandpal, Suraj
2025-11-03 22:09 ` [PATCH v2 02/10] drm/i915/alpm: alpm_init() for DP2.1 Animesh Manna
2025-11-10 9:01 ` Jani Nikula
2025-11-03 22:09 ` [PATCH v2 03/10] drm/i915/alpm: Enable debugfs " Animesh Manna
2025-11-04 4:08 ` Kandpal, Suraj
2025-11-10 9:03 ` Jani Nikula
2025-11-03 22:09 ` [PATCH v2 04/10] drm/i915/alpm: Refactor Auxless wake time calculation Animesh Manna
2025-11-07 4:00 ` Kandpal, Suraj
2025-11-07 9:32 ` Manna, Animesh
2025-11-10 9:06 ` Jani Nikula
2025-11-03 22:09 ` [PATCH v2 05/10] drm/i915/alpm: Auxless wake time calculation for Xe3p Animesh Manna
2025-11-03 22:09 ` Animesh Manna [this message]
2025-11-03 22:09 ` [PATCH v2 07/10] drm/i915/alpm: Program lttpr count for DP 2.1 alpm Animesh Manna
2025-11-03 22:09 ` [PATCH v2 08/10] drm/i915/alpm: Enable MAC Transmitting LFPS for LT phy Animesh Manna
2025-11-04 5:02 ` Kandpal, Suraj
2025-11-03 22:09 ` [PATCH v2 09/10] drm/i915/alpm: Replace is_edp() with alpm_is_possible() Animesh Manna
2025-11-03 22:09 ` [PATCH v2 10/10] drm/i915/alpm: Introduce has_alpm to decouple from pr/psr2/lobf Animesh Manna
2025-11-07 3:49 ` Kandpal, Suraj
2025-11-10 7:50 ` Manna, Animesh
2025-11-03 23:48 ` ✓ CI.KUnit: success for Enable DP2.1 alpm (rev2) Patchwork
2025-11-04 13:55 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103220957.1229608-7-animesh.manna@intel.com \
--to=animesh.manna@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox