Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org,
	mitulkumar.ajitkumar.golani@intel.com,
	ankit.k.nautiyal@intel.com, ville.syrjala@linux.intel.com
Subject: [PATCH v8 09/18] drm/i915/display: Add DC Balance flip count operations
Date: Mon, 17 Nov 2025 11:14:33 +0530	[thread overview]
Message-ID: <20251117054442.4047665-10-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20251117054442.4047665-1-mitulkumar.ajitkumar.golani@intel.com>

Track dc balance flip count with params per crtc. Increment
DC Balance Flip count before every send push to indicate DMC
firmware about new flip occurrence. This is tracked separately
from legacy FLIP_COUNT register also Reset DC balance flip
count value while disabling VRR adaptive mode, this is to
start with fresh counts when VRR adaptive refresh mode is
triggered again.

Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
 drivers/gpu/drm/i915/display/intel_color.c    |  2 ++
 drivers/gpu/drm/i915/display/intel_display.c  |  3 ++-
 .../drm/i915/display/intel_display_types.h    |  4 ++++
 drivers/gpu/drm/i915/display/intel_vrr.c      | 23 +++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_vrr.h      |  3 +++
 5 files changed, 34 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
index a217a67ceb43..115f6d7eb874 100644
--- a/drivers/gpu/drm/i915/display/intel_color.c
+++ b/drivers/gpu/drm/i915/display/intel_color.c
@@ -2013,6 +2013,8 @@ void intel_color_prepare_commit(struct intel_atomic_state *state,
 	display->funcs.color->load_luts(crtc_state);
 
 	if (crtc_state->use_dsb && intel_color_uses_chained_dsb(crtc_state)) {
+		intel_vrr_dcb_increment_flip_count(crtc_state->dsb_color,
+						   crtc_state, crtc);
 		intel_vrr_send_push(crtc_state->dsb_color, crtc_state);
 		intel_dsb_wait_for_delayed_vblank(state, crtc_state->dsb_color);
 		intel_vrr_check_push_sent(crtc_state->dsb_color, crtc_state);
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index df5d1554538d..e7fda3b2944c 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7378,7 +7378,8 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,
 
 	if (new_crtc_state->use_dsb && !intel_color_uses_chained_dsb(new_crtc_state)) {
 		intel_dsb_wait_vblanks(new_crtc_state->dsb_commit, 1);
-
+		intel_vrr_dcb_increment_flip_count(new_crtc_state->dsb_commit,
+						   new_crtc_state, crtc);
 		intel_vrr_send_push(new_crtc_state->dsb_commit, new_crtc_state);
 		intel_dsb_wait_for_delayed_vblank(state, new_crtc_state->dsb_commit);
 		intel_vrr_check_push_sent(new_crtc_state->dsb_commit,
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 8eb0ace7d918..740c5fc9fe1e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1501,6 +1501,10 @@ struct intel_crtc {
 		struct intel_link_m_n m_n, m2_n2;
 	} drrs;
 
+	struct {
+		u64 flip_count;
+	} dc_balance;
+
 	int scanline_offset;
 
 	struct {
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index 5e24ac3e6c75..788e93cea29d 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -624,6 +624,28 @@ void intel_vrr_set_transcoder_timings(const struct intel_crtc_state *crtc_state)
 			       EMP_AS_SDP_DB_TL(crtc_state->vrr.vsync_start));
 }
 
+void
+intel_vrr_dcb_increment_flip_count(struct intel_dsb *dsb,
+				   struct intel_crtc_state *crtc_state,
+				   struct intel_crtc *crtc)
+{
+	struct intel_display *display = to_intel_display(crtc_state);
+	enum pipe pipe = crtc->pipe;
+
+	if (!crtc_state->vrr.dc_balance.enable)
+		return;
+
+	if (dsb)
+		intel_dsb_nonpost_start(dsb);
+
+	intel_de_write_dsb(display, dsb,
+			   PIPEDMC_DCB_FLIP_COUNT(pipe),
+			   ++crtc->dc_balance.flip_count);
+
+	if (dsb)
+		intel_dsb_nonpost_end(dsb);
+}
+
 void
 intel_vrr_dcb_reset(const struct intel_crtc_state *crtc_state,
 		    struct intel_crtc *crtc)
@@ -634,6 +656,7 @@ intel_vrr_dcb_reset(const struct intel_crtc_state *crtc_state,
 	if (!crtc_state->vrr.dc_balance.enable)
 		return;
 
+	intel_de_write(display, PIPEDMC_DCB_FLIP_COUNT(pipe), 0);
 	intel_de_write(display, PIPEDMC_DCB_BALANCE_RESET(pipe), 0);
 }
 
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.h b/drivers/gpu/drm/i915/display/intel_vrr.h
index 1a11d288dfb4..7aa1f31ee287 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.h
+++ b/drivers/gpu/drm/i915/display/intel_vrr.h
@@ -29,6 +29,9 @@ void intel_vrr_send_push(struct intel_dsb *dsb,
 			 const struct intel_crtc_state *crtc_state);
 void intel_vrr_check_push_sent(struct intel_dsb *dsb,
 			       const struct intel_crtc_state *crtc_state);
+void intel_vrr_dcb_increment_flip_count(struct intel_dsb *dsb,
+					struct intel_crtc_state *crtc_state,
+					struct intel_crtc *crtc);
 bool intel_vrr_is_push_sent(const struct intel_crtc_state *crtc_state);
 void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state);
 void intel_vrr_get_config(struct intel_crtc_state *crtc_state);
-- 
2.48.1


  parent reply	other threads:[~2025-11-17  5:44 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  5:44 [PATCH v8 00/18] Enable/Disable DC balance along with VRR DSB Mitul Golani
2025-11-17  5:44 ` [PATCH v8 01/18] drm/i915/display: Add source param for dc balance Mitul Golani
2025-11-26  3:16   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 02/18] drm/i915/dmc: Add pipe dmc registers and bits for DC Balance Mitul Golani
2025-11-26  3:17   ` Nautiyal, Ankit K
2025-11-26  3:18   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 03/18] drm/i915/vrr: Add VRR DC balance registers Mitul Golani
2025-11-26  3:19   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 04/18] drm/i915/vrr: Add functions to read out vmin/vmax stuff Mitul Golani
2025-11-17  5:44 ` [PATCH v8 05/18] drm/i915/vrr: Add DC Balance params to crtc_state Mitul Golani
2025-11-17  5:44 ` [PATCH v8 06/18] drm/i915/vrr: Add state dump for DC Balance params Mitul Golani
2025-11-26  3:21   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 07/18] drm/i915/vrr: Add compute config " Mitul Golani
2025-11-26  4:09   ` Nautiyal, Ankit K
2025-11-26  7:30     ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 08/18] drm/i915/vrr: Add function to reset DC balance accumulated params Mitul Golani
2025-11-26  4:12   ` Nautiyal, Ankit K
2025-11-17  5:44 ` Mitul Golani [this message]
2025-11-26  4:14   ` [PATCH v8 09/18] drm/i915/display: Add DC Balance flip count operations Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 10/18] drm/i915/vrr: Write DC balance params to hw registers Mitul Golani
2025-11-26  4:25   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 11/18] drm/i915/vblank: Extract vrr_vblank_start() Mitul Golani
2025-11-17  5:44 ` [PATCH v8 12/18] drm/i915/vrr: Implement vblank evasion with DC balancing Mitul Golani
2025-11-17  5:44 ` [PATCH v8 13/18] drm/i915/display: Wait for VRR PUSH status update Mitul Golani
2025-11-26  4:29   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 14/18] drm/i915/dsb: Add pipedmc dc balance enable/disable Mitul Golani
2025-11-17  5:44 ` [PATCH v8 15/18] drm/i915/vrr: Pause DC Balancing for DSB commits Mitul Golani
2025-11-17  5:44 ` [PATCH v8 16/18] drm/i915/display: Add function to configure event for dc balance Mitul Golani
2025-11-26  4:32   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 17/18] drm/i915/vrr: Enable DC Balance Mitul Golani
2025-11-26  4:36   ` Nautiyal, Ankit K
2025-11-26  4:45   ` Nautiyal, Ankit K
2025-11-17  5:44 ` [PATCH v8 18/18] drm/i915/vrr: Add function to check if DC Balance Possible Mitul Golani
2025-11-26  4:37   ` Nautiyal, Ankit K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251117054442.4047665-10-mitulkumar.ajitkumar.golani@intel.com \
    --to=mitulkumar.ajitkumar.golani@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox