Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nemesa Garg <nemesa.garg@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Nemesa Garg <nemesa.garg@intel.com>
Subject: [PATCH v2] drm/i915/crtc: Expose sharpness only if num_scalers is >= 2
Date: Wed, 26 Nov 2025 14:11:52 +0530	[thread overview]
Message-ID: <20251126084152.3905905-1-nemesa.garg@intel.com> (raw)
In-Reply-To: <20251124084629.3322714-1-nemesa.garg@intel.com>

CASF requires the second scaler for sharpness.
Do not expose the SHARPNESS_STRENGTH property if
the CRTC has fewer than two scalers.

v2: Modify header and commit message. [Ankit]

Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
---
 drivers/gpu/drm/i915/display/intel_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
index 153ff4b4b52c..19743ae09f78 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc.c
@@ -395,7 +395,7 @@ int intel_crtc_init(struct intel_display *display, enum pipe pipe)
 
 	drm_WARN_ON(display->drm, drm_crtc_index(&crtc->base) != crtc->pipe);
 
-	if (HAS_CASF(display))
+	if (HAS_CASF(display) && crtc->num_scalers >= 2)
 		drm_crtc_create_sharpness_strength_property(&crtc->base);
 
 	return 0;
-- 
2.25.1


  parent reply	other threads:[~2025-11-26  8:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24  8:46 [PATCH] drm/i915/display: Check number of scalers for casf Nemesa Garg
2025-11-24 11:09 ` Nautiyal, Ankit K
2025-11-24 21:07   ` Ville Syrjälä
2025-11-25  3:31     ` Nautiyal, Ankit K
2025-11-25  2:14 ` ✓ CI.KUnit: success for " Patchwork
2025-11-25  3:23 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-25  5:18 ` ✗ Xe.CI.Full: failure " Patchwork
2025-11-26  8:41 ` Nemesa Garg [this message]
2025-11-28  6:13   ` [PATCH v2] drm/i915/crtc: Expose sharpness only if num_scalers is >= 2 Nautiyal, Ankit K
2025-11-26  8:52 ` ✓ CI.KUnit: success for drm/i915/display: Check number of scalers for casf (rev2) Patchwork
2025-11-26  9:55 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-26 10:48 ` ✗ Xe.CI.Full: failure " Patchwork
2025-11-28  8:25   ` Garg, Nemesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251126084152.3905905-1-nemesa.garg@intel.com \
    --to=nemesa.garg@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox