From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Nemesa Garg <nemesa.garg@intel.com>,
<intel-gfx@lists.freedesktop.org>,
<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/i915/crtc: Expose sharpness only if num_scalers is >= 2
Date: Fri, 28 Nov 2025 11:43:54 +0530 [thread overview]
Message-ID: <53405ff4-21f3-42f7-a2b1-5270639654b6@intel.com> (raw)
In-Reply-To: <20251126084152.3905905-1-nemesa.garg@intel.com>
On 11/26/2025 2:11 PM, Nemesa Garg wrote:
> CASF requires the second scaler for sharpness.
> Do not expose the SHARPNESS_STRENGTH property if
> the CRTC has fewer than two scalers.
>
> v2: Modify header and commit message. [Ankit]
>
> Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
> index 153ff4b4b52c..19743ae09f78 100644
> --- a/drivers/gpu/drm/i915/display/intel_crtc.c
> +++ b/drivers/gpu/drm/i915/display/intel_crtc.c
> @@ -395,7 +395,7 @@ int intel_crtc_init(struct intel_display *display, enum pipe pipe)
>
> drm_WARN_ON(display->drm, drm_crtc_index(&crtc->base) != crtc->pipe);
>
> - if (HAS_CASF(display))
> + if (HAS_CASF(display) && crtc->num_scalers >= 2)
> drm_crtc_create_sharpness_strength_property(&crtc->base);
>
> return 0;
next prev parent reply other threads:[~2025-11-28 6:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 8:46 [PATCH] drm/i915/display: Check number of scalers for casf Nemesa Garg
2025-11-24 11:09 ` Nautiyal, Ankit K
2025-11-24 21:07 ` Ville Syrjälä
2025-11-25 3:31 ` Nautiyal, Ankit K
2025-11-25 2:14 ` ✓ CI.KUnit: success for " Patchwork
2025-11-25 3:23 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-25 5:18 ` ✗ Xe.CI.Full: failure " Patchwork
2025-11-26 8:41 ` [PATCH v2] drm/i915/crtc: Expose sharpness only if num_scalers is >= 2 Nemesa Garg
2025-11-28 6:13 ` Nautiyal, Ankit K [this message]
2025-11-26 8:52 ` ✓ CI.KUnit: success for drm/i915/display: Check number of scalers for casf (rev2) Patchwork
2025-11-26 9:55 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-26 10:48 ` ✗ Xe.CI.Full: failure " Patchwork
2025-11-28 8:25 ` Garg, Nemesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53405ff4-21f3-42f7-a2b1-5270639654b6@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=nemesa.garg@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox