Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v4 1/3] drm/i915/psr: Set plane id bit in crtc_state->async_flip_planes for PSR
Date: Thu,  4 Dec 2025 09:07:16 +0200	[thread overview]
Message-ID: <20251204070718.1090778-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20251204070718.1090778-1-jouni.hogander@intel.com>

Currently plane id bit is set in crtc_state->async_flip_planes only when
async flip toggle workaround is needed. We want to utilize
crtc_state->async_flip_planes further in Selective Fetch calculation.

v2:
  - rework if-else if to if-if
  - added comment updated

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_plane.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_plane.c b/drivers/gpu/drm/i915/display/intel_plane.c
index 7b7619d59251..ccc8d6af5d72 100644
--- a/drivers/gpu/drm/i915/display/intel_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_plane.c
@@ -600,11 +600,10 @@ static int intel_plane_atomic_calc_changes(const struct intel_crtc_state *old_cr
 	    ilk_must_disable_cxsr(new_crtc_state, old_plane_state, new_plane_state))
 		new_crtc_state->disable_cxsr = true;
 
-	if (intel_plane_do_async_flip(plane, old_crtc_state, new_crtc_state)) {
+	if (intel_plane_do_async_flip(plane, old_crtc_state, new_crtc_state))
 		new_crtc_state->do_async_flip = true;
-		new_crtc_state->async_flip_planes |= BIT(plane->id);
-	} else if (plane->need_async_flip_toggle_wa &&
-		   new_crtc_state->uapi.async_flip) {
+
+	if (new_crtc_state->uapi.async_flip) {
 		/*
 		 * On platforms with double buffered async flip bit we
 		 * set the bit already one frame early during the sync
@@ -612,6 +611,9 @@ static int intel_plane_atomic_calc_changes(const struct intel_crtc_state *old_cr
 		 * hardware will therefore be ready to perform a real
 		 * async flip during the next commit, without having
 		 * to wait yet another frame for the bit to latch.
+		 *
+		 * async_flip_planes bitmask is also used by selective
+		 * fetch calculation to choose full frame update.
 		 */
 		new_crtc_state->async_flip_planes |= BIT(plane->id);
 	}
-- 
2.43.0


  reply	other threads:[~2025-12-04  7:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04  7:07 [PATCH v4 0/3] Selective Fetch and async flip Jouni Högander
2025-12-04  7:07 ` Jouni Högander [this message]
2025-12-04  7:07 ` [PATCH v4 2/3] drm/i915/psr: Perform full frame update on " Jouni Högander
2025-12-04  7:07 ` [PATCH v4 3/3] drm/i915/psr: Allow async flip when Selective Fetch enabled Jouni Högander
2025-12-04  7:58 ` ✓ CI.KUnit: success for Selective Fetch and async flip (rev4) Patchwork
2025-12-04  8:13 ` ✗ CI.checksparse: warning " Patchwork
2025-12-04  9:00 ` ✓ Xe.CI.BAT: success " Patchwork
2025-12-04 10:32 ` ✓ Xe.CI.Full: " Patchwork
2025-12-09 18:26 ` [PATCH v4 0/3] Selective Fetch and async flip Ville Syrjälä
2025-12-10  6:23   ` Hogander, Jouni
2025-12-10  6:31     ` Hogander, Jouni
2025-12-10  6:46       ` Ville Syrjälä
2025-12-10  6:42     ` Ville Syrjälä
2025-12-10  6:57       ` Hogander, Jouni
2025-12-10  7:06         ` Ville Syrjälä
2025-12-16 10:22       ` Hogander, Jouni
2025-12-10 13:41   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251204070718.1090778-2-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox