Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v4 3/3] drm/i915/psr: Allow async flip when Selective Fetch enabled
Date: Thu,  4 Dec 2025 09:07:18 +0200	[thread overview]
Message-ID: <20251204070718.1090778-4-jouni.hogander@intel.com> (raw)
In-Reply-To: <20251204070718.1090778-1-jouni.hogander@intel.com>

Now as Selective Fetch is performing full frame update on async flip and
vblank evasion is done as needed we can allow async flip even when
Selective Fetch is enabled.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index de8ae14e06cd..43bf0600913b 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -6026,14 +6026,6 @@ static int intel_async_flip_check_uapi(struct intel_atomic_state *state,
 		return -EINVAL;
 	}
 
-	/* FIXME: selective fetch should be disabled for async flips */
-	if (new_crtc_state->enable_psr2_sel_fetch) {
-		drm_dbg_kms(display->drm,
-			    "[CRTC:%d:%s] async flip disallowed with PSR2 selective fetch\n",
-			    crtc->base.base.id, crtc->base.name);
-		return -EINVAL;
-	}
-
 	for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state,
 					     new_plane_state, i) {
 		if (plane->pipe != crtc->pipe)
-- 
2.43.0


  parent reply	other threads:[~2025-12-04  7:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04  7:07 [PATCH v4 0/3] Selective Fetch and async flip Jouni Högander
2025-12-04  7:07 ` [PATCH v4 1/3] drm/i915/psr: Set plane id bit in crtc_state->async_flip_planes for PSR Jouni Högander
2025-12-04  7:07 ` [PATCH v4 2/3] drm/i915/psr: Perform full frame update on async flip Jouni Högander
2025-12-04  7:07 ` Jouni Högander [this message]
2025-12-04  7:58 ` ✓ CI.KUnit: success for Selective Fetch and async flip (rev4) Patchwork
2025-12-04  8:13 ` ✗ CI.checksparse: warning " Patchwork
2025-12-04  9:00 ` ✓ Xe.CI.BAT: success " Patchwork
2025-12-04 10:32 ` ✓ Xe.CI.Full: " Patchwork
2025-12-09 18:26 ` [PATCH v4 0/3] Selective Fetch and async flip Ville Syrjälä
2025-12-10  6:23   ` Hogander, Jouni
2025-12-10  6:31     ` Hogander, Jouni
2025-12-10  6:46       ` Ville Syrjälä
2025-12-10  6:42     ` Ville Syrjälä
2025-12-10  6:57       ` Hogander, Jouni
2025-12-10  7:06         ` Ville Syrjälä
2025-12-16 10:22       ` Hogander, Jouni
2025-12-10 13:41   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251204070718.1090778-4-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox