From: Raag Jadav <raag.jadav@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: rodrigo.vivi@intel.com, heikki.krogerus@linux.intel.com,
andi.shyti@linux.intel.com, riana.tauro@intel.com,
Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v1] drm/xe/i2c: Force polling mode in survivability
Date: Thu, 11 Dec 2025 23:53:53 +0530 [thread overview]
Message-ID: <20251211182353.1149481-1-raag.jadav@intel.com> (raw)
SGUnit interrupts are not initialized in survivability. Force I2C
controller to polling mode while in survivability.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/gpu/drm/xe/xe_i2c.c | 8 +++++---
drivers/gpu/drm/xe/xe_survivability_mode.c | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c
index 8eccbae05705..6f14ba1e5217 100644
--- a/drivers/gpu/drm/xe/xe_i2c.c
+++ b/drivers/gpu/drm/xe/xe_i2c.c
@@ -213,11 +213,13 @@ static const struct irq_domain_ops xe_i2c_irq_ops = {
.map = xe_i2c_irq_map,
};
-static int xe_i2c_create_irq(struct xe_i2c *i2c)
+static int xe_i2c_create_irq(struct xe_device *xe)
{
+ struct xe_survivability *survivability = &xe->survivability;
+ struct xe_i2c *i2c = xe->i2c;
struct irq_domain *domain;
- if (!(i2c->ep.capabilities & XE_I2C_EP_CAP_IRQ))
+ if (survivability->mode || !(i2c->ep.capabilities & XE_I2C_EP_CAP_IRQ))
return 0;
domain = irq_domain_create_linear(dev_fwnode(i2c->drm_dev), 1, &xe_i2c_irq_ops, NULL);
@@ -351,7 +353,7 @@ int xe_i2c_probe(struct xe_device *xe)
if (ret)
return ret;
- ret = xe_i2c_create_irq(i2c);
+ ret = xe_i2c_create_irq(xe);
if (ret)
goto err_unregister_notifier;
diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
index 7520d7b7f9b8..a34a638bfb76 100644
--- a/drivers/gpu/drm/xe/xe_survivability_mode.c
+++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
@@ -324,7 +324,7 @@ static int enable_boot_survivability_mode(struct pci_dev *pdev)
if (ret)
return ret;
- /* Make sure xe_heci_gsc_init() knows about survivability mode */
+ /* Make sure xe_heci_gsc_init() and xe_i2c_probe() are aware of survivability */
survivability->mode = true;
xe_heci_gsc_init(xe);
--
2.43.0
next reply other threads:[~2025-12-11 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 18:23 Raag Jadav [this message]
2025-12-11 20:11 ` ✓ CI.KUnit: success for drm/xe/i2c: Force polling mode in survivability Patchwork
2025-12-11 21:23 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-12 12:11 ` ✗ Xe.CI.Full: failure " Patchwork
2026-01-01 7:41 ` Raag Jadav
2025-12-16 12:08 ` [PATCH v1] " Heikki Krogerus
2025-12-24 8:46 ` Raag Jadav
2026-01-02 7:08 ` Riana Tauro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251211182353.1149481-1-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox