Re: [PATCH v1] drm/xe/i2c: Force polling mode in survivability

[Raag Jadav <raag.jadav@intel.com>]

On Tue, Dec 16, 2025 at 02:08:42PM +0200, Heikki Krogerus wrote:
> Thu, Dec 11, 2025 at 11:53:53PM +0530, Raag Jadav kirjoitti:
> > SGUnit interrupts are not initialized in survivability. Force I2C
> > controller to polling mode while in survivability.
> > 
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> 
> Like Mika said, polling should always work. This should be fine
> 
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

Thanks Heikki.

Anything else I can do here?

Raag

> > ---
> >  drivers/gpu/drm/xe/xe_i2c.c                | 8 +++++---
> >  drivers/gpu/drm/xe/xe_survivability_mode.c | 2 +-
> >  2 files changed, 6 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c
> > index 8eccbae05705..6f14ba1e5217 100644
> > --- a/drivers/gpu/drm/xe/xe_i2c.c
> > +++ b/drivers/gpu/drm/xe/xe_i2c.c
> > @@ -213,11 +213,13 @@ static const struct irq_domain_ops xe_i2c_irq_ops = {
> >  	.map = xe_i2c_irq_map,
> >  };
> >  
> > -static int xe_i2c_create_irq(struct xe_i2c *i2c)
> > +static int xe_i2c_create_irq(struct xe_device *xe)
> >  {
> > +	struct xe_survivability *survivability = &xe->survivability;
> > +	struct xe_i2c *i2c = xe->i2c;
> >  	struct irq_domain *domain;
> >  
> > -	if (!(i2c->ep.capabilities & XE_I2C_EP_CAP_IRQ))
> > +	if (survivability->mode || !(i2c->ep.capabilities & XE_I2C_EP_CAP_IRQ))
> >  		return 0;
> >  
> >  	domain = irq_domain_create_linear(dev_fwnode(i2c->drm_dev), 1, &xe_i2c_irq_ops, NULL);
> > @@ -351,7 +353,7 @@ int xe_i2c_probe(struct xe_device *xe)
> >  	if (ret)
> >  		return ret;
> >  
> > -	ret = xe_i2c_create_irq(i2c);
> > +	ret = xe_i2c_create_irq(xe);
> >  	if (ret)
> >  		goto err_unregister_notifier;
> >  
> > diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
> > index 7520d7b7f9b8..a34a638bfb76 100644
> > --- a/drivers/gpu/drm/xe/xe_survivability_mode.c
> > +++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
> > @@ -324,7 +324,7 @@ static int enable_boot_survivability_mode(struct pci_dev *pdev)
> >  	if (ret)
> >  		return ret;
> >  
> > -	/* Make sure xe_heci_gsc_init() knows about survivability mode */
> > +	/* Make sure xe_heci_gsc_init() and xe_i2c_probe() are aware of survivability */
> >  	survivability->mode = true;
> >  
> >  	xe_heci_gsc_init(xe);
> > -- 
> > 2.43.0
> 
> -- 
> heikki