From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
Harish Chegondi <harish.chegondi@intel.com>,
peter.senna@intel.com
Subject: [PATCH 2/3] drm/xe/oa: Disallow 0 OA property values
Date: Thu, 11 Dec 2025 22:18:49 -0800 [thread overview]
Message-ID: <20251212061850.1565459-3-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20251212061850.1565459-1-ashutosh.dixit@intel.com>
An OA property value of 0 is invalid and will cause a NPD.
Reported-by: Peter Senna Tschudin <peter.senna@linux.intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/6452
Fixes: cc4e6994d5a2 ("drm/xe/oa: Move functions up so they can be reused for config ioctl")
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
drivers/gpu/drm/xe/xe_oa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
index 46a79b60585b8..bba7bfbdd78b7 100644
--- a/drivers/gpu/drm/xe/xe_oa.c
+++ b/drivers/gpu/drm/xe/xe_oa.c
@@ -1343,7 +1343,7 @@ static int xe_oa_user_ext_set_property(struct xe_oa *oa, enum xe_oa_user_extn_fr
ARRAY_SIZE(xe_oa_set_property_funcs_config));
if (XE_IOCTL_DBG(oa->xe, ext.property >= ARRAY_SIZE(xe_oa_set_property_funcs_open)) ||
- XE_IOCTL_DBG(oa->xe, ext.pad))
+ XE_IOCTL_DBG(oa->xe, !ext.property) || XE_IOCTL_DBG(oa->xe, ext.pad))
return -EINVAL;
idx = array_index_nospec(ext.property, ARRAY_SIZE(xe_oa_set_property_funcs_open));
--
2.48.1
next prev parent reply other threads:[~2025-12-12 6:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 6:18 [PATCH 0/3] OA/EUSTALL: Syzkaller NPD bug fixes Ashutosh Dixit
2025-12-12 6:18 ` [PATCH 1/3] drm/xe/oa: Move default oa unit assignment earlier during stream open Ashutosh Dixit
2025-12-12 6:18 ` Ashutosh Dixit [this message]
2025-12-12 6:18 ` [PATCH 3/3] drm/xe/eustall: Disallow 0 EU stall property values Ashutosh Dixit
2025-12-16 1:18 ` Harish Chegondi
2025-12-16 1:25 ` Dixit, Ashutosh
2025-12-12 6:28 ` ✓ CI.KUnit: success for OA/EUSTALL: Syzkaller NPD bug fixes Patchwork
2025-12-12 7:54 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-12 19:10 ` ✓ Xe.CI.Full: " Patchwork
2025-12-16 18:09 ` [PATCH 0/3] " Harish Chegondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251212061850.1565459-3-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=harish.chegondi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=peter.senna@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox