Re: [PATCH 3/3] drm/xe/eustall: Disallow 0 EU stall property values

[Harish Chegondi <harish.chegondi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

Hi Ashutosh,

On 12/11/25 22:18, Ashutosh Dixit wrote:
> An EU stall property value of 0 is invalid and will cause a NPD.
>
> Reported-by: Peter Senna Tschudin<peter.senna@linux.intel.com>
> Closes:https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/6453

Is this the correct URL? I am unable to access this issue.

Thanks

Harish.

> Fixes: 1537ec85ebd7 ("drm/xe/uapi: Introduce API for EU stall sampling")
> Signed-off-by: Ashutosh Dixit<ashutosh.dixit@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_eu_stall.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_eu_stall.c b/drivers/gpu/drm/xe/xe_eu_stall.c
> index 97dfb7945b7ac..a5c36a317a707 100644
> --- a/drivers/gpu/drm/xe/xe_eu_stall.c
> +++ b/drivers/gpu/drm/xe/xe_eu_stall.c
> @@ -315,7 +315,7 @@ static int xe_eu_stall_user_ext_set_property(struct xe_device *xe, u64 extension
>   		return -EFAULT;
>   
>   	if (XE_IOCTL_DBG(xe, ext.property >= ARRAY_SIZE(xe_set_eu_stall_property_funcs)) ||
> -	    XE_IOCTL_DBG(xe, ext.pad))
> +	    XE_IOCTL_DBG(xe, !ext.property) || XE_IOCTL_DBG(xe, ext.pad))
>   		return -EINVAL;
>   
>   	idx = array_index_nospec(ext.property, ARRAY_SIZE(xe_set_eu_stall_property_funcs));

[-- Attachment #2: Type: text/html, Size: 2043 bytes --]