From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, imre.deak@intel.com,
mika.kahola@intel.com, Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH] drm/i915/cx0: Use the consolidated HDMI tables
Date: Tue, 16 Dec 2025 13:57:32 +0530 [thread overview]
Message-ID: <20251216082732.1384018-1-suraj.kandpal@intel.com> (raw)
Use the consolidated HDMI tables before we try to compute them via
algorithm. The reason is that these are the ideal values and even
though the values calculated via the HDMI algorithm are correct but
not always ideal.
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
index f6d69627154e..d0f764189567 100644
--- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
@@ -2671,15 +2671,18 @@ static int intel_c20pll_calc_state(const struct intel_crtc_state *crtc_state,
hw_state->cx0pll.use_c10 = false;
hw_state->cx0pll.lane_count = crtc_state->lane_count;
- /* try computed C20 HDMI tables before using consolidated tables */
- if (!is_dp)
- /* TODO: Update SSC state for HDMI as well */
- err = intel_c20_compute_hdmi_tmds_pll(crtc_state, &hw_state->cx0pll.c20);
-
+ /*
+ * Try the ideal C20 HDMI tables before trying to compute them since the values
+ * calculated even though would be correct but not ideal
+ */
if (err)
err = intel_c20pll_calc_state_from_table(crtc_state, encoder,
&hw_state->cx0pll);
+ if (!is_dp && err)
+ err = intel_c20_compute_hdmi_tmds_pll(crtc_state, &hw_state->cx0pll.c20);
+ /* TODO: Update SSC state for HDMI as well */
+
if (err)
return err;
--
2.34.1
next reply other threads:[~2025-12-16 8:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 8:27 Suraj Kandpal [this message]
2025-12-16 10:04 ` ✓ CI.KUnit: success for drm/i915/cx0: Use the consolidated HDMI tables Patchwork
2025-12-16 11:34 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-17 1:54 ` ✓ Xe.CI.Full: " Patchwork
2025-12-18 14:32 ` [PATCH] " Nautiyal, Ankit K
2025-12-19 3:48 ` [PATCH v2] " Suraj Kandpal
2025-12-22 14:47 ` Jani Nikula
2025-12-19 4:03 ` ✓ CI.KUnit: success for drm/i915/cx0: Use the consolidated HDMI tables (rev2) Patchwork
2025-12-19 4:37 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-20 8:06 ` ✗ Xe.CI.Full: failure " Patchwork
2025-12-23 6:34 ` [PATCH v3] drm/i915/cx0: Use the consolidated HDMI tables Suraj Kandpal
2025-12-23 7:29 ` ✓ CI.KUnit: success for drm/i915/cx0: Use the consolidated HDMI tables (rev3) Patchwork
2025-12-23 8:14 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-23 17:36 ` ✓ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251216082732.1384018-1-suraj.kandpal@intel.com \
--to=suraj.kandpal@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox