Re: [PATCH v2] drm/i915/cx0: Use the consolidated HDMI tables

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 19 Dec 2025, Suraj Kandpal <suraj.kandpal@intel.com> wrote:
> Use the consolidated HDMI tables before we try to compute them via
> algorithm. The reason is that these are the ideal values and even
> though the values calculated via the HDMI algorithm are correct but
> not always ideal. This is done for C20 and already exists for C10.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> v1 -> v2: 
> - Update commit message (Ankit)
> - Change TODO comment line (Ankit)
>
>  drivers/gpu/drm/i915/display/intel_cx0_phy.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> index f6d69627154e..f956a117f1f6 100644
> --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> @@ -2671,15 +2671,18 @@ static int intel_c20pll_calc_state(const struct intel_crtc_state *crtc_state,
>  	hw_state->cx0pll.use_c10 = false;
>  	hw_state->cx0pll.lane_count = crtc_state->lane_count;
>  
> -	/* try computed C20 HDMI tables before using consolidated tables */
> -	if (!is_dp)
> -		/* TODO: Update SSC state for HDMI as well */
> -		err = intel_c20_compute_hdmi_tmds_pll(crtc_state, &hw_state->cx0pll.c20);
> -
> +	/*
> +	 * Try the ideal C20 HDMI tables before trying to compute them since the values
> +	 * calculated even though would be correct but not ideal
> +	 */

Parse error. Please do something about the grammar.

BR,
Jani.

>  	if (err)
>  		err = intel_c20pll_calc_state_from_table(crtc_state, encoder,
>  							 &hw_state->cx0pll);
>  
> +	/* TODO: Update SSC state for HDMI as well */
> +	if (!is_dp && err)
> +		err = intel_c20_compute_hdmi_tmds_pll(crtc_state, &hw_state->cx0pll.c20);
> +
>  	if (err)
>  		return err;

-- 
Jani Nikula, Intel