From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: daniele.ceraolospurio@intel.com, carlos.santa@intel.com
Subject: [PATCH v2 17/22] drm/xe: Add hw fence deadline trace points
Date: Sun, 4 Jan 2026 20:02:32 -0800 [thread overview]
Message-ID: <20260105040237.1307873-18-matthew.brost@intel.com> (raw)
In-Reply-To: <20260105040237.1307873-1-matthew.brost@intel.com>
Add hw fence deadline trace points to help debug and profile the
deadline implementation.
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_deadline_mgr.c | 14 ++++++++++++--
drivers/gpu/drm/xe/xe_trace.h | 22 ++++++++++++++++++++--
2 files changed, 32 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_deadline_mgr.c b/drivers/gpu/drm/xe/xe_deadline_mgr.c
index f3c920017e40..e2ee23f6e787 100644
--- a/drivers/gpu/drm/xe/xe_deadline_mgr.c
+++ b/drivers/gpu/drm/xe/xe_deadline_mgr.c
@@ -10,6 +10,7 @@
#include "xe_exec_queue.h"
#include "xe_gt.h"
#include "xe_hw_fence.h"
+#include "xe_trace.h"
#ifdef CONFIG_DRM_XE_DEADLINE_WINDOW_US
#define XE_DEADLINE_WINDOW_US CONFIG_DRM_XE_DEADLINE_WINDOW_US
@@ -345,6 +346,8 @@ void xe_deadline_mgr_add_deadline(struct xe_deadline_mgr *mgr,
__xe_deadline_mgr_remove_deadline(mgr, hw_fence);
__xe_deadline_mgr_add_deadline(mgr, hw_fence, deadline);
__xe_deadline_mgr_update_deadline(mgr);
+
+ trace_xe_hw_fence_add_deadline(hw_fence);
}
/**
@@ -359,15 +362,22 @@ void xe_deadline_mgr_add_deadline(struct xe_deadline_mgr *mgr,
void xe_deadline_mgr_remove_deadline(struct xe_deadline_mgr *mgr,
struct dma_fence *fence)
{
+ struct xe_hw_fence *hw_fence;
+
if (mgr->state == XE_DEADLINE_MGR_STATE_UNSUPPORTED)
return;
guard(spinlock_irqsave)(&mgr->lock);
+ hw_fence = to_xe_hw_fence(fence);
+
xe_assert(gt_to_xe(mgr->q->gt), !dma_fence_is_container(fence));
xe_assert(gt_to_xe(mgr->q->gt), dma_fence_is_signaled(fence));
xe_assert(gt_to_xe(mgr->q->gt),
- to_xe_hw_fence(fence)->deadline.time != XE_DEADLINE_DONE);
+ hw_fence->deadline.time != XE_DEADLINE_DONE);
+
+ if (hw_fence->deadline.time != XE_DEADLINE_NONE)
+ trace_xe_hw_fence_remove_deadline(hw_fence);
- __xe_deadline_mgr_remove_deadline(mgr, to_xe_hw_fence(fence));
+ __xe_deadline_mgr_remove_deadline(mgr, hw_fence);
}
diff --git a/drivers/gpu/drm/xe/xe_trace.h b/drivers/gpu/drm/xe/xe_trace.h
index 14592403d2c0..5c84b8503de3 100644
--- a/drivers/gpu/drm/xe/xe_trace.h
+++ b/drivers/gpu/drm/xe/xe_trace.h
@@ -369,6 +369,8 @@ DECLARE_EVENT_CLASS(xe_hw_fence,
__field(u64, ctx)
__field(u32, seqno)
__field(struct xe_hw_fence *, fence)
+ __field(s64, delta_ns)
+ __field(bool, missed)
),
TP_fast_assign(
@@ -376,10 +378,16 @@ DECLARE_EVENT_CLASS(xe_hw_fence,
__entry->ctx = fence->dma.context;
__entry->seqno = fence->dma.seqno;
__entry->fence = fence;
+ __entry->delta_ns =
+ ktime_to_ns(ktime_sub(fence->deadline.time, ktime_get()));
+ __entry->missed = (__entry->delta_ns < 0 &&
+ fence->deadline.time != XE_DEADLINE_NONE);
),
- TP_printk("dev=%s, ctx=0x%016llx, fence=%p, seqno=%u",
- __get_str(dev), __entry->ctx, __entry->fence, __entry->seqno)
+ TP_printk("dev=%s, ctx=0x%llx, fence=%p, seqno=%u, missed=%d, delta_ns=0x%llx",
+ __get_str(dev), __entry->ctx, __entry->fence,
+ __entry->seqno, __entry->missed ? 1 : 0,
+ (u64)__entry->delta_ns)
);
DEFINE_EVENT(xe_hw_fence, xe_hw_fence_create,
@@ -397,6 +405,16 @@ DEFINE_EVENT(xe_hw_fence, xe_hw_fence_try_signal,
TP_ARGS(fence)
);
+DEFINE_EVENT(xe_hw_fence, xe_hw_fence_add_deadline,
+ TP_PROTO(struct xe_hw_fence *fence),
+ TP_ARGS(fence)
+);
+
+DEFINE_EVENT(xe_hw_fence, xe_hw_fence_remove_deadline,
+ TP_PROTO(struct xe_hw_fence *fence),
+ TP_ARGS(fence)
+);
+
TRACE_EVENT(xe_reg_rw,
TP_PROTO(struct xe_mmio *mmio, bool write, u32 reg, u64 val, int len),
--
2.34.1
next prev parent reply other threads:[~2026-01-05 4:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 4:02 [PATCH v2 00/22] Fence deadlines in Xe Matthew Brost
2026-01-05 4:02 ` [PATCH v2 01/22] drm/xe: Add dedicated message lock Matthew Brost
2026-01-05 4:02 ` [PATCH v2 02/22] drm/xe: Add EXEC_QUEUE_FLAG_CAP_SYS_NICE Matthew Brost
2026-02-05 16:00 ` Rodrigo Vivi
2026-01-05 4:02 ` [PATCH v2 03/22] drm/xe: Store exec queue in hardware fence Matthew Brost
2026-02-05 16:02 ` Rodrigo Vivi
2026-01-05 4:02 ` [PATCH v2 04/22] drm/xe: Add deadline exec queue vfuncs Matthew Brost
2026-02-05 16:03 ` Rodrigo Vivi
2026-01-05 4:02 ` [PATCH v2 05/22] drm/xe: Export to_xe_hw_fence Matthew Brost
2026-01-05 4:02 ` [PATCH v2 06/22] drm/xe: Export xe_hw_fence_signaled Matthew Brost
2026-01-05 4:02 ` [PATCH v2 07/22] drm/xe: Implement deadline manager Matthew Brost
2026-01-05 4:02 ` [PATCH v2 08/22] drm/xe: Initialize deadline manager on exec queues Matthew Brost
2026-01-05 4:02 ` [PATCH v2 09/22] drm/xe: Stub out execlists deadline vfuncs as NOPs Matthew Brost
2026-01-05 4:02 ` [PATCH v2 10/22] drm/xe: Make scheduler message lock IRQ-safe Matthew Brost
2026-01-05 4:02 ` [PATCH v2 11/22] drm/xe: Support unstable opcodes for static scheduler messages Matthew Brost
2026-01-05 4:02 ` [PATCH v2 12/22] drm/xe: Implement GuC submission backend ops for deadlines Matthew Brost
2026-01-10 10:48 ` kernel test robot
2026-01-05 4:02 ` [PATCH v2 13/22] drm/xe: Enable deadlines on hardware fences Matthew Brost
2026-01-05 4:02 ` [PATCH v2 14/22] drm/xe: Fix Kconfig.profile newlines Matthew Brost
2026-02-05 16:06 ` Rodrigo Vivi
2026-01-05 4:02 ` [PATCH v2 15/22] drm/xe: Add deadline Kconfig options Matthew Brost
2026-01-05 4:02 ` [PATCH v2 16/22] drm/xe: Add exec queue deadline trace points Matthew Brost
2026-01-05 4:02 ` Matthew Brost [this message]
2026-01-05 4:02 ` [PATCH v2 18/22] drm/xe: Add timestamp_ms to LRC snapshot Matthew Brost
2026-01-05 4:02 ` [PATCH v2 19/22] drm/xe: Enforce GuC static message defines Matthew Brost
2026-01-05 4:02 ` [PATCH v2 20/22] drm/xe: Document the deadline manager Matthew Brost
2026-01-05 4:02 ` [PATCH v2 21/22] drm/atomic: Export fence deadline helper for atomic commits Matthew Brost
2026-01-05 4:02 ` [PATCH v2 22/22] drm/i915/display: Use atomic helper to set plane fence deadlines Matthew Brost
2026-01-05 4:09 ` ✗ CI.checkpatch: warning for Fence deadlines in Xe (rev2) Patchwork
2026-01-05 4:10 ` ✓ CI.KUnit: success " Patchwork
2026-01-05 4:26 ` ✗ CI.checksparse: warning " Patchwork
2026-01-05 5:07 ` ✓ Xe.CI.BAT: success " Patchwork
2026-01-05 6:51 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105040237.1307873-18-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=carlos.santa@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox