Re: [PATCH v2 12/22] drm/xe: Implement GuC submission backend ops for deadlines

[kernel test robot <lkp@intel.com>]

Hi Matthew,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20251219]
[cannot apply to drm-xe/drm-xe-next drm-misc/drm-misc-next drm-i915/for-linux-next drm-i915/for-linux-next-fixes v6.19-rc4 v6.19-rc3 v6.19-rc2 linus/master v6.19-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Matthew-Brost/drm-xe-Add-dedicated-message-lock/20260105-160721
base:   next-20251219
patch link:    https://lore.kernel.org/r/20260105040237.1307873-13-matthew.brost%40intel.com
patch subject: [PATCH v2 12/22] drm/xe: Implement GuC submission backend ops for deadlines
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20260110/202601101818.dyOCWJK0-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260110/202601101818.dyOCWJK0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601101818.dyOCWJK0-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/xe/xe_guc_submit.c:2477:2: warning: variable 'opcode' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
    2477 |         default:
         |         ^~~~~~~
   drivers/gpu/drm/xe/xe_guc_submit.c:2482:43: note: uninitialized use occurs here
    2482 |                 if (!guc_exec_queue_try_add_msg(q, msg, opcode)) {
         |                                                         ^~~~~~
   drivers/gpu/drm/xe/xe_guc_submit.c:2462:21: note: initialize the variable 'opcode' to silence this warning
    2462 |         unsigned int opcode;
         |                            ^
         |                             = 0
   1 warning generated.


vim +/opcode +2477 drivers/gpu/drm/xe/xe_guc_submit.c

  2454	
  2455	static void guc_exec_queue_set_deadline_state(struct xe_exec_queue *q,
  2456						      enum xe_deadline_mgr_state state)
  2457	{
  2458		struct xe_gpu_scheduler *sched = &q->guc->sched;
  2459		struct xe_sched_msg *msg = q->guc->static_msgs +
  2460			STATIC_MSG_SET_DEADLINE_STATE;
  2461		struct xe_guc *guc = exec_queue_to_guc(q);
  2462		unsigned int opcode;
  2463	
  2464		xe_gt_assert(guc_to_gt(guc), state !=
  2465			     XE_DEADLINE_MGR_STATE_UNSUPPORTED);
  2466	
  2467		switch (state) {
  2468		case XE_DEADLINE_MGR_STATE_NO_BOOST:
  2469			opcode = EXIT_DEADLINE;
  2470			break;
  2471		case XE_DEADLINE_MGR_STATE_FREQ_BOOST:
  2472			opcode = ENTER_DEADLINE_FREQ;
  2473			break;
  2474		case XE_DEADLINE_MGR_STATE_PRIO_BOOST:
  2475			opcode = ENTER_DEADLINE_PRIO;
  2476			break;
> 2477		default:
  2478			drm_warn(&guc_to_xe(guc)->drm, "NOT POSSIBLE");
  2479		}
  2480	
  2481		xe_sched_msg_scoped_guard(sched) {
  2482			if (!guc_exec_queue_try_add_msg(q, msg, opcode)) {
  2483				bool added;
  2484	
  2485				/*
  2486				 * A deadline state change has yet to be processed,
  2487				 * removed it.
  2488				 */
  2489				list_del_init(&msg->link);
  2490	
  2491				added = guc_exec_queue_try_add_msg(q, msg, opcode);
  2492				xe_gt_assert(guc_to_gt(guc), added);
  2493			}
  2494		}
  2495	}
  2496	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki