From: Zhanjun Dong <zhanjun.dong@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Zhanjun Dong <zhanjun.dong@intel.com>
Subject: [PATCH v3 6/6] drm/xe/guc: Fix page fault by moving guc_submit_fini to devm
Date: Tue, 20 Jan 2026 15:16:21 -0500 [thread overview]
Message-ID: <20260120201621.2442803-7-zhanjun.dong@intel.com> (raw)
In-Reply-To: <20260120201621.2442803-1-zhanjun.dong@intel.com>
guc_submit_fini requires access to device memory. Using a device-managed
action guarantees the correct ordering of cleanup relative to memory
unmapping.
Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
drivers/gpu/drm/xe/xe_guc_submit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index c848615d6057..f29ed62d2b12 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -241,7 +241,7 @@ static bool exec_queue_killed_or_banned_or_wedged(struct xe_exec_queue *q)
static int __xe_guc_submit_reset_prepare(struct xe_guc *guc);
-static void guc_submit_fini(struct drm_device *drm, void *arg)
+static void guc_submit_fini(void *arg)
{
struct xe_guc *guc = arg;
struct xe_device *xe = guc_to_xe(guc);
@@ -334,7 +334,7 @@ int xe_guc_submit_init(struct xe_guc *guc, unsigned int num_ids)
guc->submission_state.initialized = true;
- return drmm_add_action_or_reset(&xe->drm, guc_submit_fini, guc);
+ return devm_add_action_or_reset(xe->drm.dev, guc_submit_fini, guc);
}
/*
--
2.34.1
next prev parent reply other threads:[~2026-01-20 20:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 20:16 [PATCH v3 0/6] Attempt to fixup reset, wedge, unload corner cases Zhanjun Dong
2026-01-20 20:16 ` [PATCH v3 1/6] drm/xe: Always kill exec queues in xe_guc_submit_pause_abort Zhanjun Dong
2026-01-20 20:16 ` [PATCH v3 2/6] drm/xe: Forcefully tear down exec queues in GuC submit fini Zhanjun Dong
2026-01-20 20:16 ` [PATCH v3 3/6] drm/xe: Trigger queue cleanup if not in wedged mode 2 Zhanjun Dong
2026-01-20 20:16 ` [PATCH v3 4/6] drm/xe/guc: Ensure CT state transitions via STOP before DISABLED Zhanjun Dong
2026-01-20 20:54 ` Matthew Brost
2026-01-20 22:56 ` Dong, Zhanjun
2026-01-20 20:16 ` [PATCH v3 5/6] drm/xe/uc: Drop xe_guc_sanitize in favor of managed cleanup Zhanjun Dong
2026-01-20 20:40 ` Matthew Brost
2026-01-20 20:16 ` Zhanjun Dong [this message]
2026-01-20 20:37 ` [PATCH v3 6/6] drm/xe/guc: Fix page fault by moving guc_submit_fini to devm Matthew Brost
2026-01-20 22:56 ` Dong, Zhanjun
2026-01-20 20:23 ` ✓ CI.KUnit: success for Attempt to fixup reset, wedge, unload corner cases Patchwork
2026-01-20 20:35 ` [PATCH v3 0/6] " Matthew Brost
2026-01-20 21:50 ` Dong, Zhanjun
2026-01-20 20:56 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-01-21 3:20 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120201621.2442803-7-zhanjun.dong@intel.com \
--to=zhanjun.dong@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox