public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Zhanjun Dong <zhanjun.dong@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v3 4/6] drm/xe/guc: Ensure CT state transitions via STOP before DISABLED
Date: Tue, 20 Jan 2026 12:54:28 -0800	[thread overview]
Message-ID: <aW/rhHiZc8Ty+L6d@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20260120201621.2442803-5-zhanjun.dong@intel.com>

On Tue, Jan 20, 2026 at 03:16:19PM -0500, Zhanjun Dong wrote:
> The GuC CT state transition requires moving to the STOP state before
> entering the DISABLED state. Updated the state machine logic to enforce
> this sequence.
>

s/Updated the state machine logic to enforce this sequence./Update the
driver teardown sequence to make the proper state machine transitions./

> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>

With an adjusted commit message:

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

This is also probably a fixes patch too.

Matt

> ---
>  drivers/gpu/drm/xe/xe_guc_ct.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
> index dfbf76037b04..6a658f085e0f 100644
> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
> @@ -345,6 +345,7 @@ static void guc_action_disable_ct(void *arg)
>  {
>  	struct xe_guc_ct *ct = arg;
>  
> +	xe_guc_ct_stop(ct);
>  	guc_ct_change_state(ct, XE_GUC_CT_STATE_DISABLED);
>  }
>  
> -- 
> 2.34.1
> 

  reply	other threads:[~2026-01-20 20:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20 20:16 [PATCH v3 0/6] Attempt to fixup reset, wedge, unload corner cases Zhanjun Dong
2026-01-20 20:16 ` [PATCH v3 1/6] drm/xe: Always kill exec queues in xe_guc_submit_pause_abort Zhanjun Dong
2026-01-20 20:16 ` [PATCH v3 2/6] drm/xe: Forcefully tear down exec queues in GuC submit fini Zhanjun Dong
2026-01-20 20:16 ` [PATCH v3 3/6] drm/xe: Trigger queue cleanup if not in wedged mode 2 Zhanjun Dong
2026-01-20 20:16 ` [PATCH v3 4/6] drm/xe/guc: Ensure CT state transitions via STOP before DISABLED Zhanjun Dong
2026-01-20 20:54   ` Matthew Brost [this message]
2026-01-20 22:56     ` Dong, Zhanjun
2026-01-20 20:16 ` [PATCH v3 5/6] drm/xe/uc: Drop xe_guc_sanitize in favor of managed cleanup Zhanjun Dong
2026-01-20 20:40   ` Matthew Brost
2026-01-20 20:16 ` [PATCH v3 6/6] drm/xe/guc: Fix page fault by moving guc_submit_fini to devm Zhanjun Dong
2026-01-20 20:37   ` Matthew Brost
2026-01-20 22:56     ` Dong, Zhanjun
2026-01-20 20:23 ` ✓ CI.KUnit: success for Attempt to fixup reset, wedge, unload corner cases Patchwork
2026-01-20 20:35 ` [PATCH v3 0/6] " Matthew Brost
2026-01-20 21:50   ` Dong, Zhanjun
2026-01-20 20:56 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-01-21  3:20 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aW/rhHiZc8Ty+L6d@lstrano-desk.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=zhanjun.dong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox