From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <dev@lankhorst.se>
Subject: [i915-rt v5 02/21] drm/i915/display: Make get_vblank_counter use intel_de_read_fw()
Date: Wed, 21 Jan 2026 14:52:58 +0100 [thread overview]
Message-ID: <20260121135318.651622-3-dev@lankhorst.se> (raw)
In-Reply-To: <20260121135318.651622-1-dev@lankhorst.se>
Fixes the following lockdep splat on PREEMPT_RT:
<3> BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
<3> in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 1373, name: xe_module_load
<3> preempt_count: 1, expected: 0
<3> RCU nest depth: 0, expected: 0
<4> 11 locks held by xe_module_load/1373:
<4> #0: ffff888107b691a0 (&dev->mutex){....}-{3:3}, at: __driver_attach+0x104/0x220
<4> #1: ffff88813cd30280 (&dev->clientlist_mutex){+.+.}-{3:3}, at: drm_client_register+0x32/0xe0
<4> #2: ffffffff837f88f8 (registration_lock){+.+.}-{3:3}, at: register_framebuffer+0x1b/0x50
<4> #3: ffffffff835985e0 (console_lock){+.+.}-{0:0}, at: fbcon_fb_registered+0x6f/0x90
<4> #4: ffff88812589e6a0 (&helper->lock){+.+.}-{3:3}, at: __drm_fb_helper_restore_fbdev_mode_unlocked+0x7b/0x110
<4> #5: ffff88813cd30158 (&dev->master_mutex){+.+.}-{3:3}, at: drm_master_internal_acquire+0x20/0x50
<4> #6: ffff88812589e488 (&client->modeset_mutex){+.+.}-{3:3}, at: drm_client_modeset_commit_locked+0x2a/0x1b0
<4> #7: ffffc9000031eef0 (crtc_ww_class_acquire){+.+.}-{0:0}, at: drm_client_modeset_commit_atomic+0x4c/0x2b0
<4> #8: ffffc9000031ef18 (crtc_ww_class_mutex){+.+.}-{3:3}, at: drm_client_modeset_commit_atomic+0x4c/0x2b0
<4> #9: ffff888114f7b8b8 (&intel_dp->psr.lock){+.+.}-{3:3}, at: intel_psr_lock+0xc5/0xf0 [xe]
<4> #10: ffff88812a0cbbc0 (&wl->lock){+.+.}-{2:2}, at: intel_dmc_wl_get+0x3c/0x140 [xe]
This splat will happen otherwise on all tracepoints too, for similar reasons.
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
drivers/gpu/drm/i915/display/intel_vblank.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
index 1b7cfe226ff8f..a85796f9d29ba 100644
--- a/drivers/gpu/drm/i915/display/intel_vblank.c
+++ b/drivers/gpu/drm/i915/display/intel_vblank.c
@@ -132,7 +132,7 @@ u32 g4x_get_vblank_counter(struct drm_crtc *crtc)
if (!vblank->max_vblank_count)
return 0;
- return intel_de_read(display, PIPE_FRMCOUNT_G4X(display, pipe));
+ return intel_de_read_fw(display, PIPE_FRMCOUNT_G4X(display, pipe));
}
static u32 intel_crtc_scanlines_since_frame_timestamp(struct intel_crtc *crtc)
--
2.51.0
next prev parent reply other threads:[~2026-01-21 13:53 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 13:52 [i915-rt v5 00/21] drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe Maarten Lankhorst
2026-01-21 13:52 ` [i915-rt v5 01/21] drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT Maarten Lankhorst
2026-02-02 19:31 ` Shankar, Uma
2026-01-21 13:52 ` Maarten Lankhorst [this message]
2026-02-02 19:33 ` [i915-rt v5 02/21] drm/i915/display: Make get_vblank_counter use intel_de_read_fw() Shankar, Uma
2026-01-21 13:52 ` [i915-rt v5 03/21] drm/i915/display: Use intel_de_write_fw in intel_pipe_fastset Maarten Lankhorst
2026-02-02 19:43 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 04/21] drm/i915/display: Make set_pipeconf use the fw variants Maarten Lankhorst
2026-02-02 19:45 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 05/21] drm/i915/display: Move vblank put until after critical section Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 06/21] drm/i915/display: Remove locking from intel_vblank_evade " Maarten Lankhorst
2026-02-02 20:17 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 07/21] drm/i915/display: Handle vlv dsi workaround in scanline_in_safe_range too Maarten Lankhorst
2026-02-02 20:24 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 08/21] drm/i915/display: Make icl_dsi_frame_update use _fw too Maarten Lankhorst
2026-02-02 20:31 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 09/21] drm/i915/display: Enable interrupts earlier on PREEMPT_RT Maarten Lankhorst
2026-02-02 20:59 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 10/21] drm/i915: Use preempt_disable/enable_rt() where recommended Maarten Lankhorst
2026-02-02 21:07 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 11/21] drm/i915/display: Use intel_de_read/write_fw in colorops Maarten Lankhorst
2026-02-02 21:08 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 12/21] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 13/21] drm/i915: Drop the irqs_disabled() check Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 14/21] drm/i915/guc: Consider also RCU depth in busy loop Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 15/21] Revert "drm/i915: Depend on !PREEMPT_RT." Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 16/21] drm/i915/gt: Fix selftests on PREEMPT_RT Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 17/21] drm/i915/gt: Set stop_timeout() correctly on PREEMPT-RT Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 18/21] drm/i915/display: Do not take uncore lock in i915_get_vblank_counter Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 19/21] drm/i915/display: Remove uncore lock from vlv_atomic_update_fifo Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 20/21] PREEMPT_RT injection Maarten Lankhorst
2026-01-21 23:57 ` kernel test robot
2026-01-22 2:30 ` kernel test robot
2026-01-21 13:53 ` [i915-rt v5 21/21] FOR-CI: drm/i915: Reset lockdep after selftest unload Maarten Lankhorst
2026-01-21 16:56 ` [i915-rt v5] " Maarten Lankhorst
2026-01-22 0:04 ` [i915-rt v5] FOR-CI: try bumping MAX_STACK_TRACE_ENTRIES? Maarten Lankhorst
2026-01-21 14:03 ` ✗ CI.checkpatch: warning for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev9) Patchwork
2026-01-21 14:04 ` ✓ CI.KUnit: success " Patchwork
2026-01-21 17:19 ` ✗ CI.checkpatch: warning for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev10) Patchwork
2026-01-21 17:21 ` ✓ CI.KUnit: success " Patchwork
2026-01-21 17:36 ` ✗ CI.checksparse: warning " Patchwork
2026-01-21 17:59 ` ✓ Xe.CI.BAT: success " Patchwork
2026-01-22 1:48 ` ✗ CI.checkpatch: warning for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev11) Patchwork
2026-01-22 1:49 ` ✓ CI.KUnit: success " Patchwork
2026-01-22 2:04 ` ✗ CI.checksparse: warning " Patchwork
2026-01-22 2:27 ` ✓ Xe.CI.BAT: success " Patchwork
2026-01-22 3:03 ` ✗ Xe.CI.Full: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev10) Patchwork
2026-01-22 13:27 ` ✗ Xe.CI.Full: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev11) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121135318.651622-3-dev@lankhorst.se \
--to=dev@lankhorst.se \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox