From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <dev@lankhorst.se>
Subject: [i915-rt v5 07/21] drm/i915/display: Handle vlv dsi workaround in scanline_in_safe_range too
Date: Wed, 21 Jan 2026 14:53:03 +0100 [thread overview]
Message-ID: <20260121135318.651622-8-dev@lankhorst.se> (raw)
In-Reply-To: <20260121135318.651622-1-dev@lankhorst.se>
Now that we have a macro, might as well handle the VLV dsi workaround
too.
This makes the vblank evasion code slightly more deterministic, by not
looping with interrupts disabled.
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
drivers/gpu/drm/i915/display/intel_vblank.c | 36 ++++++++++-----------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
index 58c374a7530fe..6bc784563a7c1 100644
--- a/drivers/gpu/drm/i915/display/intel_vblank.c
+++ b/drivers/gpu/drm/i915/display/intel_vblank.c
@@ -739,6 +739,24 @@ static bool scanline_in_safe_range(struct intel_vblank_evade_ctx *evade, int *sc
else
*scanline = __intel_get_crtc_scanline(evade->crtc);
+ /*
+ * On VLV/CHV DSI the scanline counter would appear to
+ * increment approx. 1/3 of a scanline before start of vblank.
+ * The registers still get latched at start of vblank however.
+ * This means we must not write any registers on the first
+ * line of vblank (since not the whole line is actually in
+ * vblank). And unfortunately we can't use the interrupt to
+ * wait here since it will fire too soon. We could use the
+ * frame start interrupt instead since it will fire after the
+ * critical scanline, but that would require more changes
+ * in the interrupt code. So for now we'll just do the nasty
+ * thing and poll for the bad scanline to pass us by.
+ *
+ * FIXME figure out if BXT+ DSI suffers from this as well
+ */
+ if (evade->need_vlv_dsi_wa && *scanline == evade->vblank_start)
+ return false;
+
return *scanline < evade->min || *scanline > evade->max;
}
@@ -769,24 +787,6 @@ int intel_vblank_evade(struct intel_vblank_evade_ctx *evade)
local_irq_disable();
}
- /*
- * On VLV/CHV DSI the scanline counter would appear to
- * increment approx. 1/3 of a scanline before start of vblank.
- * The registers still get latched at start of vblank however.
- * This means we must not write any registers on the first
- * line of vblank (since not the whole line is actually in
- * vblank). And unfortunately we can't use the interrupt to
- * wait here since it will fire too soon. We could use the
- * frame start interrupt instead since it will fire after the
- * critical scanline, but that would require more changes
- * in the interrupt code. So for now we'll just do the nasty
- * thing and poll for the bad scanline to pass us by.
- *
- * FIXME figure out if BXT+ DSI suffers from this as well
- */
- while (evade->need_vlv_dsi_wa && scanline == evade->vblank_start)
- scanline = intel_get_crtc_scanline(crtc);
-
return scanline;
}
--
2.51.0
next prev parent reply other threads:[~2026-01-21 13:53 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 13:52 [i915-rt v5 00/21] drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe Maarten Lankhorst
2026-01-21 13:52 ` [i915-rt v5 01/21] drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT Maarten Lankhorst
2026-02-02 19:31 ` Shankar, Uma
2026-01-21 13:52 ` [i915-rt v5 02/21] drm/i915/display: Make get_vblank_counter use intel_de_read_fw() Maarten Lankhorst
2026-02-02 19:33 ` Shankar, Uma
2026-01-21 13:52 ` [i915-rt v5 03/21] drm/i915/display: Use intel_de_write_fw in intel_pipe_fastset Maarten Lankhorst
2026-02-02 19:43 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 04/21] drm/i915/display: Make set_pipeconf use the fw variants Maarten Lankhorst
2026-02-02 19:45 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 05/21] drm/i915/display: Move vblank put until after critical section Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 06/21] drm/i915/display: Remove locking from intel_vblank_evade " Maarten Lankhorst
2026-02-02 20:17 ` Shankar, Uma
2026-01-21 13:53 ` Maarten Lankhorst [this message]
2026-02-02 20:24 ` [i915-rt v5 07/21] drm/i915/display: Handle vlv dsi workaround in scanline_in_safe_range too Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 08/21] drm/i915/display: Make icl_dsi_frame_update use _fw too Maarten Lankhorst
2026-02-02 20:31 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 09/21] drm/i915/display: Enable interrupts earlier on PREEMPT_RT Maarten Lankhorst
2026-02-02 20:59 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 10/21] drm/i915: Use preempt_disable/enable_rt() where recommended Maarten Lankhorst
2026-02-02 21:07 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 11/21] drm/i915/display: Use intel_de_read/write_fw in colorops Maarten Lankhorst
2026-02-02 21:08 ` Shankar, Uma
2026-01-21 13:53 ` [i915-rt v5 12/21] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 13/21] drm/i915: Drop the irqs_disabled() check Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 14/21] drm/i915/guc: Consider also RCU depth in busy loop Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 15/21] Revert "drm/i915: Depend on !PREEMPT_RT." Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 16/21] drm/i915/gt: Fix selftests on PREEMPT_RT Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 17/21] drm/i915/gt: Set stop_timeout() correctly on PREEMPT-RT Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 18/21] drm/i915/display: Do not take uncore lock in i915_get_vblank_counter Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 19/21] drm/i915/display: Remove uncore lock from vlv_atomic_update_fifo Maarten Lankhorst
2026-01-21 13:53 ` [i915-rt v5 20/21] PREEMPT_RT injection Maarten Lankhorst
2026-01-21 23:57 ` kernel test robot
2026-01-22 2:30 ` kernel test robot
2026-01-21 13:53 ` [i915-rt v5 21/21] FOR-CI: drm/i915: Reset lockdep after selftest unload Maarten Lankhorst
2026-01-21 16:56 ` [i915-rt v5] " Maarten Lankhorst
2026-01-22 0:04 ` [i915-rt v5] FOR-CI: try bumping MAX_STACK_TRACE_ENTRIES? Maarten Lankhorst
2026-01-21 14:03 ` ✗ CI.checkpatch: warning for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev9) Patchwork
2026-01-21 14:04 ` ✓ CI.KUnit: success " Patchwork
2026-01-21 17:19 ` ✗ CI.checkpatch: warning for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev10) Patchwork
2026-01-21 17:21 ` ✓ CI.KUnit: success " Patchwork
2026-01-21 17:36 ` ✗ CI.checksparse: warning " Patchwork
2026-01-21 17:59 ` ✓ Xe.CI.BAT: success " Patchwork
2026-01-22 1:48 ` ✗ CI.checkpatch: warning for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev11) Patchwork
2026-01-22 1:49 ` ✓ CI.KUnit: success " Patchwork
2026-01-22 2:04 ` ✗ CI.checksparse: warning " Patchwork
2026-01-22 2:27 ` ✓ Xe.CI.BAT: success " Patchwork
2026-01-22 3:03 ` ✗ Xe.CI.Full: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev10) Patchwork
2026-01-22 13:27 ` ✗ Xe.CI.Full: failure for drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe. (rev11) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121135318.651622-8-dev@lankhorst.se \
--to=dev@lankhorst.se \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox