Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Varun Gupta <varun.gupta@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.brost@intel.com, matthew.d.roper@intel.com,
	priyanka.dandamudi@intel.com, himal.prasad.ghimiray@intel.com
Subject: [PATCH v2 1/2] drm/xe: Rename xe_pagefault_print to xe_pagefault_error_account
Date: Tue, 27 Jan 2026 17:27:12 +0530	[thread overview]
Message-ID: <20260127115713.869000-2-varun.gupta@intel.com> (raw)
In-Reply-To: <20260127115713.869000-1-varun.gupta@intel.com>

Rename the function to better reflect its purpose of error handling.
Add an err parameter to the function signature.

v2: Clarified commit message to describe only the changes made in this
    commit (Matt Roper)

Originally-by: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Varun Gupta <varun.gupta@intel.com>
---
 drivers/gpu/drm/xe/xe_pagefault.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c
index 6bee53d6ffc3..34dac4280b9d 100644
--- a/drivers/gpu/drm/xe/xe_pagefault.c
+++ b/drivers/gpu/drm/xe/xe_pagefault.c
@@ -221,7 +221,7 @@ static bool xe_pagefault_queue_pop(struct xe_pagefault_queue *pf_queue,
 	return found_fault;
 }
 
-static void xe_pagefault_print(struct xe_pagefault *pf)
+static void xe_pagefault_error_account(struct xe_pagefault *pf, int err)
 {
 	xe_gt_info(pf->gt, "\n\tASID: %d\n"
 		   "\tFaulted Address: 0x%08x%08x\n"
@@ -259,7 +259,7 @@ static void xe_pagefault_queue_work(struct work_struct *w)
 
 		err = xe_pagefault_service(&pf);
 		if (err) {
-			xe_pagefault_print(&pf);
+			xe_pagefault_error_account(&pf, err);
 			xe_gt_info(pf.gt, "Fault response: Unsuccessful %pe\n",
 				   ERR_PTR(err));
 		}
-- 
2.43.0


  reply	other threads:[~2026-01-27 11:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27 11:57 [PATCH v2 0/2] drm/xe: Add prefetch pagefault support for Xe3p Varun Gupta
2026-01-27 11:57 ` Varun Gupta [this message]
2026-01-27 20:32   ` [PATCH v2 1/2] drm/xe: Rename xe_pagefault_print to xe_pagefault_error_account Matthew Brost
2026-01-27 11:57 ` [PATCH v2 2/2] drm/xe: Add prefetch fault support for Xe3p Varun Gupta
2026-01-27 20:31   ` Matthew Brost
2026-01-27 20:47     ` Matthew Brost
2026-01-28  9:53 ` ✗ CI.checkpatch: warning for drm/xe: Add prefetch pagefault support for Xe3p (rev2) Patchwork
2026-01-28  9:55 ` ✓ CI.KUnit: success " Patchwork
2026-01-28 10:43 ` ✓ Xe.CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260127115713.869000-2-varun.gupta@intel.com \
    --to=varun.gupta@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=priyanka.dandamudi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox