Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@linux.intel.com, imre.deak@intel.com,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 2/2] drm/i915/dp: Restore the missing check for intel_dp_has_joiner
Date: Fri,  6 Feb 2026 10:17:53 +0530	[thread overview]
Message-ID: <20260206044753.808631-1-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20260205083623.793902-3-ankit.k.nautiyal@intel.com>

Commit ad121a62d566 ("drm/i915/dp: Rework pipe joiner logic in mode_valid")
replaced intel_dp_num_joined_pipes() with an explicit joiner candidate
iteration. The previous code implicitly checked for DP joiner capability
via intel_dp_has_joiner(), but this check was lost during the refactor.

Restore the missing intel_dp_has_joiner() check in intel_dp_can_join() so
that DP specific joiner conditions are taken into account.

v2: Derive intel_dp from intel_attached_dp(). (Imre)

Fixes: ad121a62d566 ("drm/i915/dp: Rework pipe joiner logic in mode_valid")
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 4f5b89f80e55..7da4310b399e 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1397,9 +1397,14 @@ bool intel_dp_has_dsc(const struct intel_connector *connector)
 }
 
 static
-bool intel_dp_can_join(struct intel_display *display,
+bool intel_dp_can_join(struct intel_dp *intel_dp,
 		       int num_joined_pipes)
 {
+	struct intel_display *display = to_intel_display(intel_dp);
+
+	if (num_joined_pipes > 1 && !intel_dp_has_joiner(intel_dp))
+		return false;
+
 	switch (num_joined_pipes) {
 	case 1:
 		return true;
@@ -7218,8 +7223,9 @@ bool intel_dp_joiner_candidate_valid(struct intel_connector *connector,
 				     int num_joined_pipes)
 {
 	struct intel_display *display = to_intel_display(connector);
+	struct intel_dp *intel_dp = intel_attached_dp(connector);
 
-	if (!intel_dp_can_join(display, num_joined_pipes))
+	if (!intel_dp_can_join(intel_dp, num_joined_pipes))
 		return false;
 
 	if (hdisplay > num_joined_pipes * intel_dp_max_hdisplay_per_pipe(display))
-- 
2.45.2


  parent reply	other threads:[~2026-02-06  5:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-05  8:36 [PATCH 0/2] drm/i915/dp: Joiner cleanups and fix Ankit Nautiyal
2026-02-05  8:36 ` [PATCH 1/2] drm/i915/dp: Make intel_dp_can_join() static Ankit Nautiyal
2026-02-05  9:44   ` Imre Deak
2026-02-05  8:36 ` [PATCH 2/2] drm/i915/dp: Restore the missing check for intel_dp_has_joiner Ankit Nautiyal
2026-02-05  9:41   ` Imre Deak
2026-02-05 12:37     ` Nautiyal, Ankit K
2026-02-05 12:53       ` Imre Deak
2026-02-05 14:20         ` Nautiyal, Ankit K
2026-02-06  4:47   ` Ankit Nautiyal [this message]
2026-02-06 10:33     ` Imre Deak
2026-02-05  9:37 ` ✗ CI.checkpatch: warning for drm/i915/dp: Joiner cleanups and fix Patchwork
2026-02-05  9:38 ` ✓ CI.KUnit: success " Patchwork
2026-02-05 10:16 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-06  5:10 ` ✓ CI.KUnit: success for drm/i915/dp: Joiner cleanups and fix (rev2) Patchwork
2026-02-06  5:25 ` ✗ CI.checksparse: warning " Patchwork
2026-02-06  5:48 ` ✗ Xe.CI.FULL: failure for drm/i915/dp: Joiner cleanups and fix Patchwork
2026-02-06  5:51 ` ✓ Xe.CI.BAT: success for drm/i915/dp: Joiner cleanups and fix (rev2) Patchwork
2026-02-07  8:06 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260206044753.808631-1-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox