From: Imre Deak <imre.deak@intel.com>
To: <intel-gfx@lists.freedesktop.org>, <intel-xe@lists.freedesktop.org>
Cc: Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH v3 10/20] drm/i915/dp: Fix the link service IRQ DPCD_REV check
Date: Wed, 25 Feb 2026 18:46:08 +0200 [thread overview]
Message-ID: <20260225164618.1261368-11-imre.deak@intel.com> (raw)
In-Reply-To: <20260225164618.1261368-1-imre.deak@intel.com>
The DP_LINK_SERVICE_IRQ_VECTOR_ESI0 DPCD register is supported only
since DPCD REV 1.2, so fix the revision check accordingly.
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 88be5a03af912..9feda949570ec 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -5799,7 +5799,7 @@ static bool intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
bool reprobe_needed = false;
u8 val;
- if (intel_dp->dpcd[DP_DPCD_REV] < 0x11)
+ if (intel_dp->dpcd[DP_DPCD_REV] < DP_DPCD_REV_12)
return false;
if (drm_dp_dpcd_readb(&intel_dp->aux,
--
2.49.1
next prev parent reply other threads:[~2026-02-25 16:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 16:45 [PATCH v3 00/20] drm/i915/dp: Fix few SST HPD IRQ handling issues Imre Deak
2026-02-25 16:45 ` [PATCH v3 01/20] drm/i915/dp_mst: Reprobe connector if the IRQ ESI read failed Imre Deak
2026-02-25 16:46 ` [PATCH v3 02/20] drm/i915/dp_mst: Verify the link status always the same way Imre Deak
2026-02-25 16:46 ` [PATCH v3 03/20] drm/i915/dp_mst: Reuse intel_dp_check_link_state() in the HPD IRQ handler Imre Deak
2026-02-25 16:46 ` [PATCH v3 04/20] drm/i915/dp: Handle a tunneling IRQ after acking it Imre Deak
2026-02-25 16:46 ` [PATCH v3 05/20] drm/i915/dp: Handle the RX_CAP_CHANGED HPD IRQ Imre Deak
2026-02-25 16:46 ` [PATCH v3 06/20] drm/i915/dp: Handle the DOWNSTREAM_PORT_STATUS_CHANGED event Imre Deak
2026-02-25 16:46 ` [PATCH v3 07/20] drm/i915/dp: Don't clobber the encoder state in the HPD IRQ handler Imre Deak
2026-02-25 16:46 ` [PATCH v3 08/20] drm/i915/dp: Remove the device service IRQ handling from connector detect Imre Deak
2026-02-25 16:46 ` [PATCH v3 09/20] drm/i915/dp: Fix the device service IRQ DPCD_REV check Imre Deak
2026-02-25 16:46 ` Imre Deak [this message]
2026-02-25 16:46 ` [PATCH v3 11/20] drm/i915/dp: Reprobe connector if getting/acking device IRQs fails Imre Deak
2026-02-25 16:46 ` [PATCH v3 12/20] drm/i915/dp: Reprobe connector if getting/acking link service " Imre Deak
2026-02-25 16:46 ` [PATCH v3 13/20] drm/i915/dp: Return early if getting/acking device " Imre Deak
2026-02-25 16:46 ` [PATCH v3 14/20] drm/i915/dp: Return early if getting/ackink link " Imre Deak
2026-02-25 16:46 ` [PATCH v3 15/20] drm/i915/dp: Read/ack sink count and sink IRQs for SST as it's done for MST Imre Deak
2026-02-25 16:46 ` [PATCH v3 16/20] drm/i915/dp: Print debug message for a sink connected off request Imre Deak
2026-02-25 16:46 ` [PATCH v3 17/20] drm/i915/dp: Check SST link status while handling link service IRQs Imre Deak
2026-02-25 16:46 ` [PATCH v3 18/20] drm/i915/dp_mst: Reuse intel_dp_handle_link_service_irq() Imre Deak
2026-02-25 16:46 ` [PATCH v3 19/20] drm/i915/dp: Ack only the handled device service IRQs Imre Deak
2026-02-25 16:46 ` [PATCH v3 20/20] drm/i915/dp: Ack only the handled link " Imre Deak
2026-02-25 17:33 ` ✓ CI.KUnit: success for drm/i915/dp: Fix few SST HPD IRQ handling issues (rev3) Patchwork
2026-02-25 18:13 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-25 20:48 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260225164618.1261368-11-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox