From: Arun R Murthy <arun.r.murthy@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: animesh.manna@intel.com, ankit.k.nautiyal@intel.com,
jani.nikula@intel.com, jouni.hogander@intel.com,
Arun R Murthy <arun.r.murthy@intel.com>
Subject: [PATCHv4] drm/i915/dp: Read ALPM caps after DPCD init
Date: Wed, 4 Mar 2026 09:35:51 +0530 [thread overview]
Message-ID: <20260304040551.754483-1-arun.r.murthy@intel.com> (raw)
In-Reply-To: <20260302033630.428913-1-arun.r.murthy@intel.com>
For eDP read the ALPM DPCD caps after DPCD initalization and just before
the PSR init.
v2: Move intel_alpm_init to intel_edp_init_dpcd (Jouni)
v3: Add Fixes with commit-id (Jouni)
v4: Separated the alpm dpcd read caps from alpm_init and moved to
intel_edp_init_dpcd.
Fixes: 15438b325987 ("drm/i915/alpm: Add compute config for lobf")
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_alpm.c | 6 ------
drivers/gpu/drm/i915/display/intel_dp.c | 9 +++++++++
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index b3334bc4d0f9..a7350ce8e716 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -44,12 +44,6 @@ bool intel_alpm_is_alpm_aux_less(struct intel_dp *intel_dp,
void intel_alpm_init(struct intel_dp *intel_dp)
{
- u8 dpcd;
-
- if (drm_dp_dpcd_readb(&intel_dp->aux, DP_RECEIVER_ALPM_CAP, &dpcd) < 0)
- return;
-
- intel_dp->alpm_dpcd = dpcd;
mutex_init(&intel_dp->alpm.lock);
}
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 025e906b63a9..e781d4d0dd1b 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4709,6 +4709,7 @@ static bool
intel_edp_init_dpcd(struct intel_dp *intel_dp, struct intel_connector *connector)
{
struct intel_display *display = to_intel_display(intel_dp);
+ int ret;
/* this function is meant to be called only once */
drm_WARN_ON(display->drm, intel_dp->dpcd[DP_DPCD_REV] != 0);
@@ -4748,6 +4749,14 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp, struct intel_connector *connector
*/
intel_dp_init_source_oui(intel_dp);
+ /* Read the ALPM DPCD caps */
+ if (intel_dp->edp_dpcd[0] >= DP_EDP_14) {
+ ret = drm_dp_dpcd_readb(&intel_dp->aux, DP_RECEIVER_ALPM_CAP,
+ &intel_dp->alpm_dpcd);
+ if (ret < 0)
+ return false;
+ }
+
/*
* This has to be called after intel_dp->edp_dpcd is filled, PSR checks
* for SET_POWER_CAPABLE bit in intel_dp->edp_dpcd[1]
--
2.25.1
next prev parent reply other threads:[~2026-03-04 4:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 3:36 [PATCH] drm/i915/dp: ALPM init to be done after DPCD init Arun R Murthy
2026-03-02 3:44 ` ✓ CI.KUnit: success for " Patchwork
2026-03-02 4:27 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-02 5:31 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-02 6:44 ` [PATCH] " Hogander, Jouni
2026-03-02 7:20 ` Murthy, Arun R
2026-03-02 8:00 ` Hogander, Jouni
2026-03-02 8:11 ` Murthy, Arun R
2026-03-02 8:40 ` [PATCHv2 1/2] drm/i915/dp: Read ALPM caps " Arun R Murthy
2026-03-02 8:40 ` [PATCHv2 2/2] drm/i915/dp: Rename alpm_init to alpm_init_dpcd Arun R Murthy
2026-03-02 14:58 ` Dibin Moolakadan Subrahmanian
2026-03-03 4:10 ` Murthy, Arun R
2026-03-03 11:30 ` Hogander, Jouni
2026-03-04 4:05 ` Arun R Murthy [this message]
2026-03-04 6:05 ` [PATCHv4] drm/i915/dp: Read ALPM caps after DPCD init Manna, Animesh
2026-03-04 6:17 ` Hogander, Jouni
2026-03-04 6:22 ` Hogander, Jouni
2026-03-04 6:24 ` Murthy, Arun R
2026-03-04 4:13 ` ✓ CI.KUnit: success for drm/i915/dp: ALPM init to be done after DPCD init (rev4) Patchwork
2026-03-04 4:56 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-03-04 6:38 ` [PATCHv5] drm/i915/dp: Read ALPM caps after DPCD init Arun R Murthy
2026-03-04 6:53 ` Hogander, Jouni
2026-03-04 6:46 ` ✓ CI.KUnit: success for drm/i915/dp: ALPM init to be done after DPCD init (rev5) Patchwork
2026-03-04 7:21 ` [PATCHv6] drm/i915/dp: Read ALPM caps after DPCD init Arun R Murthy
2026-03-09 9:38 ` Manna, Animesh
2026-03-12 11:43 ` Jani Nikula
2026-03-04 7:34 ` ✗ Xe.CI.BAT: failure for drm/i915/dp: ALPM init to be done after DPCD init (rev5) Patchwork
2026-03-04 8:20 ` ✓ CI.KUnit: success for drm/i915/dp: ALPM init to be done after DPCD init (rev6) Patchwork
2026-03-04 9:00 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-03-05 6:06 ` ✗ Xe.CI.FULL: " Patchwork
2026-03-05 9:40 ` ✗ Xe.CI.BAT: " Patchwork
2026-03-05 10:43 ` ✗ Xe.CI.FULL: " Patchwork
2026-03-06 4:49 ` ✓ CI.KUnit: success for drm/i915/dp: ALPM init to be done after DPCD init (rev7) Patchwork
2026-03-06 5:38 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-07 4:01 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304040551.754483-1-arun.r.murthy@intel.com \
--to=arun.r.murthy@intel.com \
--cc=animesh.manna@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox