Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
To: intel-xe@lists.freedesktop.org, rodrigo.vivi@intel.com,
	matthew.brost@intel.com
Cc: anshuman.gupta@intel.com, badal.nilawar@intel.com,
	riana.tauro@intel.com, karthik.poosa@intel.com,
	sk.anirban@intel.com, raag.jadav@intel.com,
	Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Subject: [PATCH] drm/xe/xe_survivability: Fix runtime survivability error handling
Date: Tue, 14 Apr 2026 18:14:27 +0530	[thread overview]
Message-ID: <20260414124426.566929-2-mallesh.koujalagi@intel.com> (raw)

When enabling survivability mode at runtime, the code tries to create
a sysfs entry. If that step fails, the error is only logged, but the
function still reports success. This makes it look like survivability
mode was enabled even though part of it failed.

Fixes: a2ca0633a0fe ("drm/xe/xe_survivability: Add support for Runtime survivability mode")
Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
---
 drivers/gpu/drm/xe/xe_survivability_mode.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
index db64cac39c94..c2dfc7ea7b83 100644
--- a/drivers/gpu/drm/xe/xe_survivability_mode.c
+++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
@@ -413,8 +413,10 @@ int xe_survivability_mode_runtime_enable(struct xe_device *xe)
 	populate_survivability_info(xe);
 
 	ret = create_survivability_sysfs(pdev);
-	if (ret)
+	if (ret) {
 		dev_err(&pdev->dev, "Failed to create survivability mode sysfs\n");
+		return ret;
+	}
 
 	survivability->type = XE_SURVIVABILITY_TYPE_RUNTIME;
 	dev_err(&pdev->dev, "Runtime Survivability mode enabled\n");
-- 
2.34.1


             reply	other threads:[~2026-04-14 12:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14 12:44 Mallesh Koujalagi [this message]
2026-04-14 12:54 ` ✓ CI.KUnit: success for drm/xe/xe_survivability: Fix runtime survivability error handling Patchwork
2026-04-14 13:58 ` [PATCH] " Rodrigo Vivi
2026-04-14 14:11   ` Raag Jadav
2026-04-14 14:35     ` Tauro, Riana
2026-04-14 14:00 ` ✗ Xe.CI.BAT: failure for " Patchwork
2026-04-14 14:55 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260414124426.566929-2-mallesh.koujalagi@intel.com \
    --to=mallesh.koujalagi@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=karthik.poosa@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=sk.anirban@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox