Re: [PATCH] drm/xe/xe_survivability: Fix runtime survivability error handling

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Apr 14, 2026 at 06:14:27PM +0530, Mallesh Koujalagi wrote:
> When enabling survivability mode at runtime, the code tries to create
> a sysfs entry. If that step fails, the error is only logged, but the
> function still reports success. This makes it look like survivability
> mode was enabled even though part of it failed.
> 
> Fixes: a2ca0633a0fe ("drm/xe/xe_survivability: Add support for Runtime survivability mode")
> Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_survivability_mode.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
> index db64cac39c94..c2dfc7ea7b83 100644
> --- a/drivers/gpu/drm/xe/xe_survivability_mode.c
> +++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
> @@ -413,8 +413,10 @@ int xe_survivability_mode_runtime_enable(struct xe_device *xe)
>  	populate_survivability_info(xe);
>  
>  	ret = create_survivability_sysfs(pdev);
> -	if (ret)
> +	if (ret) {
>  		dev_err(&pdev->dev, "Failed to create survivability mode sysfs\n");
> +		return ret;

Perhaps this is intentional?
But if so, this function needs to be changed to void and
the extra msg removed from csc_hw_error_work()

Riana, Raag?

> +	}
>  
>  	survivability->type = XE_SURVIVABILITY_TYPE_RUNTIME;
>  	dev_err(&pdev->dev, "Runtime Survivability mode enabled\n");
> -- 
> 2.34.1
>