From: Luca Coelho <luciano.coelho@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, jani.nikula@linux.intel.com,
ville.syrjala@linux.intel.com
Subject: [PATCH v3 8/8] drm/i915: remove HAS_PCH_NOP() dependency from clock gating
Date: Mon, 20 Apr 2026 13:30:50 +0300 [thread overview]
Message-ID: <20260420103705.3453499-9-luciano.coelho@intel.com> (raw)
In-Reply-To: <20260420103705.3453499-1-luciano.coelho@intel.com>
intel_pch_init_clock_gating() already handles unsupported PCH types,
including PCH_NOP, by doing nothing.
Drop the explicit HAS_PCH_NOP() check from the IVB clock gating
path and always call the display helper directly. This removes one
more direct dependency on display-side PCH macros from
intel_clock_gating.c.
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
drivers/gpu/drm/i915/intel_clock_gating.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_clock_gating.c b/drivers/gpu/drm/i915/intel_clock_gating.c
index 12559db84cf4..d185199c43b8 100644
--- a/drivers/gpu/drm/i915/intel_clock_gating.c
+++ b/drivers/gpu/drm/i915/intel_clock_gating.c
@@ -290,8 +290,7 @@ static void ivb_init_clock_gating(struct drm_i915_private *i915)
intel_uncore_rmw(&i915->uncore, GEN6_MBCUNIT_SNPCR, GEN6_MBC_SNPCR_MASK,
GEN6_MBC_SNPCR_MED);
- if (!HAS_PCH_NOP(display))
- intel_pch_init_clock_gating(display);
+ intel_pch_init_clock_gating(display);
gen6_check_mch_setup(i915);
}
--
2.53.0
next prev parent reply other threads:[~2026-04-20 10:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 10:30 [PATCH v3 0/8] drm/i915: move more display dependencies from i915 Luca Coelho
2026-04-20 10:30 ` [PATCH v3 1/8] drm/i915: move SKL clock gating init to display Luca Coelho
2026-04-20 10:30 ` [PATCH v3 2/8] drm/i915: move KBL " Luca Coelho
2026-04-20 10:30 ` [PATCH v3 3/8] drm/i915/display: move CFL " Luca Coelho
2026-04-20 10:30 ` [PATCH v3 4/8] drm/i915/display: move BXT " Luca Coelho
2026-04-20 10:30 ` [PATCH v3 5/8] drm/i915/display: move GLK " Luca Coelho
2026-04-20 12:18 ` Jani Nikula
2026-04-20 20:08 ` Luca Coelho
2026-04-20 10:30 ` [PATCH v3 6/8] drm/i915/display: move HSW and BDW " Luca Coelho
2026-04-20 10:30 ` [PATCH v3 7/8] drm/i915/display: move pre-HSW " Luca Coelho
2026-04-20 10:30 ` Luca Coelho [this message]
2026-04-20 12:21 ` [PATCH v3 8/8] drm/i915: remove HAS_PCH_NOP() dependency from clock gating Jani Nikula
2026-04-20 20:09 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260420103705.3453499-9-luciano.coelho@intel.com \
--to=luciano.coelho@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox