From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Carlos Santa" <carlos.santa@intel.com>,
"Matthew Auld" <matthew.auld@intel.com>
Subject: [PATCH 3/3] drm/xe: Avoid shrinker reclaim from kswapd under fragmentation
Date: Mon, 20 Apr 2026 18:26:08 -0700 [thread overview]
Message-ID: <20260421012608.1474950-4-matthew.brost@intel.com> (raw)
In-Reply-To: <20260421012608.1474950-1-matthew.brost@intel.com>
When the Xe shrinker is invoked from kswapd, a large amount of free
memory in ZONE_NORMAL relative to the high watermark is a strong signal
that reclaim is being driven by fragmentation rather than true memory
pressure.
In this case, shrinking Xe memory is unlikely to help kswapd make
forward progress. Instead it can evict active GPU memory despite the
system still having substantial free memory, increasing residency churn
and reducing GPU forward progress.
Detect this case and bail out early from the Xe shrinker when running in
kswapd and ZONE_NORMAL has more than 2x its high watermark free.
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Carlos Santa <carlos.santa@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_shrinker.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_shrinker.c b/drivers/gpu/drm/xe/xe_shrinker.c
index 83374cd57660..e56afde83de6 100644
--- a/drivers/gpu/drm/xe/xe_shrinker.c
+++ b/drivers/gpu/drm/xe/xe_shrinker.c
@@ -236,6 +236,19 @@ static unsigned long xe_shrinker_scan(struct shrinker *shrink, struct shrink_con
if (nr_scanned >= nr_to_scan || !can_backup)
goto out;
+ if (current_is_kswapd()) {
+ struct zone *zone = &NODE_DATA(sc->nid)->node_zones[ZONE_NORMAL];
+ unsigned long free_pages = zone_page_state(zone, NR_FREE_PAGES);
+ unsigned long high_wmark = high_wmark_pages(zone);
+
+ /*
+ * If we have 2x the high watermark free, this is definitely
+ * fragmentation
+ */
+ if (free_pages > (high_wmark * 2))
+ goto out;
+ }
+
/* If we didn't wake before, try to do it now if needed. */
if (!runtime_pm)
runtime_pm = xe_shrinker_runtime_pm_get(shrinker, true, 0, can_backup);
--
2.34.1
next prev parent reply other threads:[~2026-04-21 1:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 1:26 [PATCH 0/3] drm/ttm, drm/xe: Avoid reclaim/eviction loops under fragmentation Matthew Brost
2026-04-21 1:26 ` [PATCH 1/3] drm/ttm: Issue direct reclaim at beneficial_order Matthew Brost
2026-04-21 6:11 ` Christian König
2026-04-22 4:12 ` Matthew Brost
2026-04-22 6:41 ` Christian König
2026-04-22 7:32 ` Tvrtko Ursulin
2026-04-22 7:41 ` Christian König
2026-04-22 20:41 ` Matthew Brost
2026-04-23 8:44 ` Christian König
2026-04-28 13:45 ` Tvrtko Ursulin
2026-04-29 22:52 ` Daniel Colascione
2026-04-30 0:11 ` Dave Airlie
2026-04-30 7:59 ` Thomas Hellström
2026-04-30 8:14 ` Christian König
2026-04-30 7:34 ` Christian König
2026-04-30 3:00 ` Matthew Brost
2026-05-01 20:04 ` Thadeu Lima de Souza Cascardo
2026-04-21 1:26 ` [PATCH 2/3] drm/xe: Set TTM device beneficial_order to 9 (2M) Matthew Brost
2026-04-21 1:26 ` Matthew Brost [this message]
2026-04-22 8:22 ` [PATCH 3/3] drm/xe: Avoid shrinker reclaim from kswapd under fragmentation Thomas Hellström
2026-04-22 20:27 ` Matthew Brost
2026-04-21 5:56 ` ✓ CI.KUnit: success for drm/ttm, drm/xe: Avoid reclaim/eviction loops " Patchwork
2026-04-21 6:43 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-21 8:29 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421012608.1474950-4-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=carlos.santa@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox