From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com,
Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [RESEND PATCH 6/7] drm/dp: Add a helper to get the SDP type as a string
Date: Fri, 24 Apr 2026 15:04:23 +0530 [thread overview]
Message-ID: <20260424093424.3060805-7-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20260424093424.3060805-1-ankit.k.nautiyal@intel.com>
Introduce dp_sdp_type_get_name() to get the SDP type as a string.
Use this to log the SDP type based on the sdp_type fields of the
VSC and AS SDPs instead of the hardcoded strings.
While at it, rename "SDP : AS_SDP" to "SDP : Adaptive Sync"
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/display/drm_dp_helper.c | 36 ++++++++++++++++++++++---
1 file changed, 32 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
index e29958f8b0b6..102328d9022d 100644
--- a/drivers/gpu/drm/display/drm_dp_helper.c
+++ b/drivers/gpu/drm/display/drm_dp_helper.c
@@ -3487,10 +3487,38 @@ static const char *dp_content_type_get_name(enum dp_content_type content_type)
}
}
+static const char *dp_sdp_type_get_name(unsigned char type)
+{
+ switch (type) {
+ case DP_SDP_AUDIO_TIMESTAMP:
+ return "Audio Timestamp";
+ case DP_SDP_AUDIO_STREAM:
+ return "Audio Stream";
+ case DP_SDP_EXTENSION:
+ return "Extension";
+ case DP_SDP_AUDIO_COPYMANAGEMENT:
+ return "Audio Copy Management";
+ case DP_SDP_ISRC:
+ return "ISRC";
+ case DP_SDP_VSC:
+ return "VSC";
+ case DP_SDP_PPS:
+ return "PPS";
+ case DP_SDP_VSC_EXT_VESA:
+ return "VSC EXT VESA";
+ case DP_SDP_VSC_EXT_CEA:
+ return "VSC EXT CEA";
+ case DP_SDP_ADAPTIVE_SYNC:
+ return "Adaptive Sync";
+ default:
+ return "Unknown";
+ }
+}
+
void drm_dp_vsc_sdp_log(struct drm_printer *p, const struct drm_dp_vsc_sdp *vsc)
{
- drm_printf(p, "DP SDP: VSC, revision %u, length %u\n",
- vsc->revision, vsc->length);
+ drm_printf(p, "DP SDP: %s, revision %u, length %u\n",
+ dp_sdp_type_get_name(vsc->sdp_type), vsc->revision, vsc->length);
drm_printf(p, " pixelformat: %s\n",
dp_pixelformat_get_name(vsc->pixelformat));
drm_printf(p, " colorimetry: %s\n",
@@ -3505,8 +3533,8 @@ EXPORT_SYMBOL(drm_dp_vsc_sdp_log);
void drm_dp_as_sdp_log(struct drm_printer *p, const struct drm_dp_as_sdp *as_sdp)
{
- drm_printf(p, "DP SDP: AS_SDP, revision %u, length %u\n",
- as_sdp->revision, as_sdp->length);
+ drm_printf(p, "DP SDP: %s, revision %u, length %u\n",
+ dp_sdp_type_get_name(as_sdp->sdp_type), as_sdp->revision, as_sdp->length);
drm_printf(p, " vtotal: %d\n", as_sdp->vtotal);
drm_printf(p, " target_rr: %d\n", as_sdp->target_rr);
drm_printf(p, " duration_incr_ms: %d\n", as_sdp->duration_incr_ms);
--
2.45.2
next prev parent reply other threads:[~2026-04-24 9:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 9:34 [RESEND PATCH 0/7] AS SDP cleanups and additions for Panel Replay + VRR Ankit Nautiyal
2026-04-24 9:34 ` [RESEND PATCH 1/7] drm/dp: Rename and relocate AS SDP payload field masks Ankit Nautiyal
2026-04-24 9:34 ` [RESEND PATCH 2/7] drm/dp: Clean up DPRX feature enumeration macros Ankit Nautiyal
2026-04-24 9:34 ` [RESEND PATCH 3/7] drm/dp: Add bits for AS SDP FAVT Payload Fields Parsing support Ankit Nautiyal
2026-04-24 9:34 ` [RESEND PATCH 4/7] drm/dp: Add DPCD for configuring AS SDP for PR + VRR Ankit Nautiyal
2026-04-24 9:34 ` [RESEND PATCH 5/7] drm/dp: Store coasting vtotal in struct drm_dp_as_sdp Ankit Nautiyal
2026-04-27 12:42 ` Ville Syrjälä
2026-04-27 12:52 ` Jani Nikula
2026-04-28 7:48 ` Nautiyal, Ankit K
2026-04-28 7:43 ` Nautiyal, Ankit K
2026-04-24 9:34 ` Ankit Nautiyal [this message]
2026-04-27 12:57 ` [RESEND PATCH 6/7] drm/dp: Add a helper to get the SDP type as a string Ville Syrjälä
2026-04-28 7:42 ` Nautiyal, Ankit K
2026-04-24 9:34 ` [RESEND PATCH 7/7] drm/dp: Add target_rr_divider field in AS SDP logging Ankit Nautiyal
2026-04-27 12:58 ` Ville Syrjälä
2026-04-24 10:22 ` ✗ CI.checkpatch: warning for AS SDP cleanups and additions for Panel Replay + VRR Patchwork
2026-04-24 10:23 ` ✓ CI.KUnit: success " Patchwork
2026-04-24 11:29 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-24 12:35 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260424093424.3060805-7-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox