Re: [RESEND PATCH 5/7] drm/dp: Store coasting vtotal in struct drm_dp_as_sdp

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 4/27/2026 6:12 PM, Ville Syrjälä wrote:
> On Fri, Apr 24, 2026 at 03:04:22PM +0530, Ankit Nautiyal wrote:
>> Add new field in struct drm_dp_as_sdp to store coasting vtotal.
>> This is used by the sinks that support Panel Replay and Asynchronous
>> timing during PR Active to derive refresh rate, when AS SDP transmission
>> is stopped by the source.
>>
>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> ---
>>   drivers/gpu/drm/display/drm_dp_helper.c | 1 +
>>   include/drm/display/drm_dp_helper.h     | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
>> index a697cc227e28..e29958f8b0b6 100644
>> --- a/drivers/gpu/drm/display/drm_dp_helper.c
>> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
>> @@ -3512,6 +3512,7 @@ void drm_dp_as_sdp_log(struct drm_printer *p, const struct drm_dp_as_sdp *as_sdp
>>   	drm_printf(p, "    duration_incr_ms: %d\n", as_sdp->duration_incr_ms);
>>   	drm_printf(p, "    duration_decr_ms: %d\n", as_sdp->duration_decr_ms);
>>   	drm_printf(p, "    operation_mode: %d\n", as_sdp->mode);
>> +	drm_printf(p, "    coasting vtotal: %d\n", as_sdp->coasting_vtotal);
> For some reason the existing fields are using '_', this one ' '.
> Looks like VSC uses ' ' as well. So the existing stuff in
> drm_dp_as_sdp_log() should be fixed to conform to the common
> style, in a separate patch.

Sure I will fix the existing things to be consistent with rest of the thing.


Thanks,

Ankit

>
> Otherwise this looks fine
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>>   }
>>   EXPORT_SYMBOL(drm_dp_as_sdp_log);
>>   
>> diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h
>> index 1d0acd58f486..8c2d77a032f0 100644
>> --- a/include/drm/display/drm_dp_helper.h
>> +++ b/include/drm/display/drm_dp_helper.h
>> @@ -126,6 +126,7 @@ struct drm_dp_as_sdp {
>>   	int duration_decr_ms;
>>   	bool target_rr_divider;
>>   	enum operation_mode mode;
>> +	int coasting_vtotal;
>>   };
>>   
>>   void drm_dp_as_sdp_log(struct drm_printer *p,
>> -- 
>> 2.45.2