From: Raag Jadav <raag.jadav@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: rodrigo.vivi@intel.com, vinay.belgaumkar@intel.com,
badal.nilawar@intel.com, sk.anirban@intel.com,
Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v2 2/3] drm/xe/guc_pc: Reorder forcewake in xe_guc_pc_fini_hw()
Date: Mon, 27 Apr 2026 14:59:27 +0530 [thread overview]
Message-ID: <20260427092928.1181893-3-raag.jadav@intel.com> (raw)
In-Reply-To: <20260427092928.1181893-1-raag.jadav@intel.com>
xe_guc_pc_stop() doesn't perform any MMIO operation that requires
forcewake in it's code path. Move it before pc_set_cur_freq() which
writes to RPNSWREQ and actually requires it.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
v2: Split forcewake reordering to separate patch (Rodrigo)
---
drivers/gpu/drm/xe/xe_guc_pc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
index 9530cddbd11d..59f2fa79ad42 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.c
+++ b/drivers/gpu/drm/xe/xe_guc_pc.c
@@ -1340,10 +1340,10 @@ static void xe_guc_pc_fini_hw(void *arg)
if (xe_device_wedged(xe))
return;
- CLASS(xe_force_wake, fw_ref)(gt_to_fw(pc_to_gt(pc)), XE_FW_GT);
xe_guc_pc_stop(pc);
/* Bind requested freq to mert_freq_cap before unload */
+ CLASS(xe_force_wake, fw_ref)(gt_to_fw(pc_to_gt(pc)), XE_FW_GT);
pc_set_cur_freq(pc, min(pc_max_freq_cap(pc), xe_guc_pc_get_rpe_freq(pc)));
}
--
2.43.0
next prev parent reply other threads:[~2026-04-27 9:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 9:29 [PATCH v2 0/3] Minor GuC PC cleanups Raag Jadav
2026-04-27 9:29 ` [PATCH v2 1/3] drm/xe/guc_pc: Make xe_guc_pc_stop() void Raag Jadav
2026-04-27 22:07 ` Rodrigo Vivi
2026-04-27 9:29 ` Raag Jadav [this message]
2026-04-27 22:08 ` [PATCH v2 2/3] drm/xe/guc_pc: Reorder forcewake in xe_guc_pc_fini_hw() Rodrigo Vivi
2026-04-27 9:29 ` [PATCH v2 3/3] drm/xe/gt: Drop redundant forcewake Raag Jadav
2026-04-27 22:11 ` Rodrigo Vivi
2026-04-29 12:25 ` Raag Jadav
2026-04-30 20:59 ` Rodrigo Vivi
2026-04-27 12:20 ` ✓ CI.KUnit: success for Minor GuC PC cleanups (rev2) Patchwork
2026-04-27 13:12 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-27 14:48 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427092928.1181893-3-raag.jadav@intel.com \
--to=raag.jadav@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=sk.anirban@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox