From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <vinay.belgaumkar@intel.com>,
<badal.nilawar@intel.com>, <sk.anirban@intel.com>
Subject: Re: [PATCH v2 3/3] drm/xe/gt: Drop redundant forcewake
Date: Mon, 27 Apr 2026 18:11:39 -0400 [thread overview]
Message-ID: <ae_fG5yyH5jyXztd@intel.com> (raw)
In-Reply-To: <20260427092928.1181893-4-raag.jadav@intel.com>
On Mon, Apr 27, 2026 at 02:59:28PM +0530, Raag Jadav wrote:
> xe_gt_suspend_prepare() doesn't perform any MMIO operation that requires
> forcewake in it's code path. Drop it.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
it makes sense... for a moment I thought that the gsc work would require it,
but it has its own forcewake if needed...
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>$
> ---
> v2: Expand commit message (Rodrigo)
> ---
> drivers/gpu/drm/xe/xe_gt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 3c031175f737..e5065f46c748 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -1027,7 +1027,6 @@ void xe_gt_reset_async(struct xe_gt *gt)
>
> void xe_gt_suspend_prepare(struct xe_gt *gt)
> {
> - CLASS(xe_force_wake, fw_ref)(gt_to_fw(gt), XE_FORCEWAKE_ALL);
> xe_uc_suspend_prepare(>->uc);
> }
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-04-27 22:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 9:29 [PATCH v2 0/3] Minor GuC PC cleanups Raag Jadav
2026-04-27 9:29 ` [PATCH v2 1/3] drm/xe/guc_pc: Make xe_guc_pc_stop() void Raag Jadav
2026-04-27 22:07 ` Rodrigo Vivi
2026-04-27 9:29 ` [PATCH v2 2/3] drm/xe/guc_pc: Reorder forcewake in xe_guc_pc_fini_hw() Raag Jadav
2026-04-27 22:08 ` Rodrigo Vivi
2026-04-27 9:29 ` [PATCH v2 3/3] drm/xe/gt: Drop redundant forcewake Raag Jadav
2026-04-27 22:11 ` Rodrigo Vivi [this message]
2026-04-27 12:20 ` ✓ CI.KUnit: success for Minor GuC PC cleanups (rev2) Patchwork
2026-04-27 13:12 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-27 14:48 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae_fG5yyH5jyXztd@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=raag.jadav@intel.com \
--cc=sk.anirban@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox