From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@linux.intel.com, ville.syrjala@linux.intel.com,
Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 0/5] drm/i915/intel_panel: Reduce redundant intel_panel_fixed_mode() calls
Date: Thu, 30 Apr 2026 18:42:15 +0530 [thread overview]
Message-ID: <20260430131220.3891497-1-ankit.k.nautiyal@intel.com> (raw)
This series addresses feedback from Jani Nikula to reduce
intel_panel_fixed_mode() calls in encoder code [1].
Currently, encoder code calls intel_panel_fixed_mode() directly to check
for or get fixed mode state, then calls intel_panel_mode_valid() or
intel_panel_compute_config(), which repeat the lookup internally.
This series avoids those redundant calls by:
- Extending intel_panel_mode_valid() to return the effective target clock
via out parameter
- Dropping direct intel_panel_fixed_mode() calls from encoder mode_valid
paths
- Dropping redundant fixed mode checks from compute_config paths
Note: intel_sdvo.c retains two intel_panel_fixed_mode() calls in
intel_sdvo_create_preferred_input_timing() and intel_sdvo_pre_enable()
as they seem to indeed need the fixed modes.
It might need a bit more work to get rid of them.
[1] https://lore.kernel.org/intel-gfx/0fb737c2484e116721b944befff146d9069ecee3@intel.com/
Ankit Nautiyal (5):
drm/i915/intel_sdvo: Check fixed_mode->clock against max_dotclock in
mode_valid
drm/i915/intel_panel: Avoid calls to intel_panel_fixed_mode() in
mode_valid
drm/i915/intel_dvo: Drop call to intel_panel_fixed_mode() from
compute_config
drm/i915/intel_sdvo: Drop call to intel_panel_fixed_mode() from
compute_config
drm/i915/dp: Drop call to intel_panel_fixed_mode() from compute_config
drivers/gpu/drm/i915/display/intel_dp.c | 12 +++------
drivers/gpu/drm/i915/display/intel_dsi.c | 7 +++---
drivers/gpu/drm/i915/display/intel_dvo.c | 29 ++++++----------------
drivers/gpu/drm/i915/display/intel_lvds.c | 7 +++---
drivers/gpu/drm/i915/display/intel_panel.c | 9 ++++++-
drivers/gpu/drm/i915/display/intel_panel.h | 3 ++-
drivers/gpu/drm/i915/display/intel_sdvo.c | 11 +++++---
7 files changed, 34 insertions(+), 44 deletions(-)
--
2.45.2
next reply other threads:[~2026-04-30 13:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 13:12 Ankit Nautiyal [this message]
2026-04-30 13:12 ` [PATCH 1/5] drm/i915/intel_sdvo: Check fixed_mode->clock against max_dotclock in mode_valid Ankit Nautiyal
2026-05-04 5:22 ` Kandpal, Suraj
2026-04-30 13:12 ` [PATCH 2/5] drm/i915/intel_panel: Avoid calls to intel_panel_fixed_mode() " Ankit Nautiyal
2026-05-04 5:37 ` Kandpal, Suraj
2026-05-04 13:50 ` Nautiyal, Ankit K
2026-05-04 14:10 ` Kandpal, Suraj
2026-05-06 13:17 ` Nautiyal, Ankit K
2026-05-07 4:14 ` Kandpal, Suraj
2026-04-30 13:12 ` [PATCH 3/5] drm/i915/intel_dvo: Drop call to intel_panel_fixed_mode() from compute_config Ankit Nautiyal
2026-05-04 5:52 ` Kandpal, Suraj
2026-05-04 13:52 ` Nautiyal, Ankit K
2026-04-30 13:12 ` [PATCH 4/5] drm/i915/intel_sdvo: " Ankit Nautiyal
2026-05-04 9:34 ` Kandpal, Suraj
2026-04-30 13:12 ` [PATCH 5/5] drm/i915/dp: " Ankit Nautiyal
2026-05-04 9:37 ` Kandpal, Suraj
2026-04-30 13:34 ` ✓ CI.KUnit: success for drm/i915/intel_panel: Reduce redundant intel_panel_fixed_mode() calls Patchwork
2026-04-30 14:23 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-01 1:30 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260430131220.3891497-1-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox