Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@linux.intel.com, ville.syrjala@linux.intel.com,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 3/5] drm/i915/intel_dvo: Drop call to intel_panel_fixed_mode() from compute_config
Date: Thu, 30 Apr 2026 18:42:18 +0530	[thread overview]
Message-ID: <20260430131220.3891497-4-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20260430131220.3891497-1-ankit.k.nautiyal@intel.com>

The function intel_dvo_compute_config() calls intel_panel_fixed_mode() only
to check if there is a valid fixed_mode and based on that it then calls
intel_panel_compute_config().

However, since the intel_panel_compute_config() already checks for
fixed_mode and we can drop the call to intel_panel_fixed_mode().

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dvo.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dvo.c b/drivers/gpu/drm/i915/display/intel_dvo.c
index 65015477abed..dd1a995c2979 100644
--- a/drivers/gpu/drm/i915/display/intel_dvo.c
+++ b/drivers/gpu/drm/i915/display/intel_dvo.c
@@ -246,11 +246,9 @@ static int intel_dvo_compute_config(struct intel_encoder *encoder,
 				    struct intel_crtc_state *pipe_config,
 				    struct drm_connector_state *conn_state)
 {
-	struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
 	struct intel_connector *connector = to_intel_connector(conn_state->connector);
 	struct drm_display_mode *adjusted_mode = &pipe_config->hw.adjusted_mode;
-	const struct drm_display_mode *fixed_mode =
-		intel_panel_fixed_mode(intel_dvo->attached_connector, adjusted_mode);
+	int ret;
 
 	/*
 	 * If we have timings from the BIOS for the panel, put them in
@@ -258,13 +256,9 @@ static int intel_dvo_compute_config(struct intel_encoder *encoder,
 	 * with the panel scaling set up to source from the H/VDisplay
 	 * of the original mode.
 	 */
-	if (fixed_mode) {
-		int ret;
-
-		ret = intel_panel_compute_config(connector, adjusted_mode);
-		if (ret)
-			return ret;
-	}
+	ret = intel_panel_compute_config(connector, adjusted_mode);
+	if (ret)
+		return ret;
 
 	if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
 		return -EINVAL;
-- 
2.45.2


  parent reply	other threads:[~2026-04-30 13:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 13:12 [PATCH 0/5] drm/i915/intel_panel: Reduce redundant intel_panel_fixed_mode() calls Ankit Nautiyal
2026-04-30 13:12 ` [PATCH 1/5] drm/i915/intel_sdvo: Check fixed_mode->clock against max_dotclock in mode_valid Ankit Nautiyal
2026-05-04  5:22   ` Kandpal, Suraj
2026-04-30 13:12 ` [PATCH 2/5] drm/i915/intel_panel: Avoid calls to intel_panel_fixed_mode() " Ankit Nautiyal
2026-05-04  5:37   ` Kandpal, Suraj
2026-05-04 13:50     ` Nautiyal, Ankit K
2026-05-04 14:10       ` Kandpal, Suraj
2026-05-06 13:17         ` Nautiyal, Ankit K
2026-05-07  4:14           ` Kandpal, Suraj
2026-04-30 13:12 ` Ankit Nautiyal [this message]
2026-05-04  5:52   ` [PATCH 3/5] drm/i915/intel_dvo: Drop call to intel_panel_fixed_mode() from compute_config Kandpal, Suraj
2026-05-04 13:52     ` Nautiyal, Ankit K
2026-04-30 13:12 ` [PATCH 4/5] drm/i915/intel_sdvo: " Ankit Nautiyal
2026-05-04  9:34   ` Kandpal, Suraj
2026-04-30 13:12 ` [PATCH 5/5] drm/i915/dp: " Ankit Nautiyal
2026-05-04  9:37   ` Kandpal, Suraj
2026-04-30 13:34 ` ✓ CI.KUnit: success for drm/i915/intel_panel: Reduce redundant intel_panel_fixed_mode() calls Patchwork
2026-04-30 14:23 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-01  1:30 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260430131220.3891497-4-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox